From 3991880b446366ca2f5666604707e03c8307d224 Mon Sep 17 00:00:00 2001 From: Jonathan Rainville Date: Wed, 5 Sep 2018 09:45:34 -0400 Subject: [PATCH 1/2] no warning in development --- lib/core/config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/core/config.js b/lib/core/config.js index 18ad623d..a56e33c2 100644 --- a/lib/core/config.js +++ b/lib/core/config.js @@ -183,7 +183,7 @@ Config.prototype.loadBlockchainConfigFile = function() { if (!configFilePath) { this.blockchainConfig.default = true; } - if(!this.blockchainConfig.account && !this.blockchainConfig.isDev) { + if(!this.blockchainConfig.account && !this.blockchainConfig.isDev && this.env !== 'development') { this.logger.warn( __('Account settings are needed for this chain.' + ' Please put a valid address and possibly a password in your blockchain config or use a dev chain.') From 55bb028a13142dc645b5a59637e6411911fdef0e Mon Sep 17 00:00:00 2001 From: Jonathan Rainville Date: Wed, 5 Sep 2018 12:35:45 -0400 Subject: [PATCH 2/2] add test too --- lib/core/config.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/core/config.js b/lib/core/config.js index a56e33c2..0c9aa15c 100644 --- a/lib/core/config.js +++ b/lib/core/config.js @@ -183,10 +183,11 @@ Config.prototype.loadBlockchainConfigFile = function() { if (!configFilePath) { this.blockchainConfig.default = true; } - if(!this.blockchainConfig.account && !this.blockchainConfig.isDev && this.env !== 'development') { + if (!this.blockchainConfig.account && !this.blockchainConfig.isDev && + this.env !== 'development' && this.env !== 'test') { this.logger.warn( __('Account settings are needed for this chain.' + - ' Please put a valid address and possibly a password in your blockchain config or use a dev chain.') + ' Please put a valid address and possibly a password in your blockchain config or use a dev chain.') ); } };