From 46c4aea5207bebf4de867d2823d68af59d5b8fd3 Mon Sep 17 00:00:00 2001 From: "Michael Bradley, Jr" Date: Sat, 18 Aug 2018 22:14:43 -0500 Subject: [PATCH] rev comment re: NODE_PATH in webpack config --- lib/pipeline/webpack.config.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/pipeline/webpack.config.js b/lib/pipeline/webpack.config.js index 4096b0c2..4737824a 100644 --- a/lib/pipeline/webpack.config.js +++ b/lib/pipeline/webpack.config.js @@ -5,15 +5,15 @@ // in the dapp's own package.json, perhaps with a different version/range or // other specifier -// NOTE: embark modifies process.env.NODE_PATH so that embark's own -// node_modules directory will be searched by node's require(). That allows an -// ejected version of this config, inside a dapp, to function correctly without -// embark being an explicit dependency of the dapp. However, webpack and babel -// do not directly support NODE_PATH, so in various parts of the config, -// modules such as plugins and presets must be resolved with -// require.resolve(). That is only necessary if a plugin/preset is in embark's -// node_modules; if it's in the dapp's node_modules then it can be specified -// directly +// NOTE: embark modifies process.env.NODE_PATH so that when running dapp +// scripts in embark's child processes, embark's own node_modules directory +// will be searched by node's require(); that allows an ejected version of this +// config, inside a dapp, to function correctly without embark being an +// explicit dependency of the dapp; however, webpack and babel do not directly +// support NODE_PATH, so in various parts of the config, modules such as babel +// plugins and presets must be resolved with require.resolve(); that is only +// necessary if a plugin/preset is in embark's node_modules vs. the dapp's +// node_modules // there's a bug in pkg clone-deep re: regex; for now use lodash.clonedeep // see: https://github.com/jonschlinkert/clone-deep/pull/14