status-im/dotherside
2
0
Fork 0
mirror of https://github.com/status-im/dotherside.git synced 2025-02-11 20:16:47 +00:00
Code Issues Projects Releases Wiki Activity

fix(Translations): Retranslate call disabled

Browse Source 
Retranslate call disabled for all OS --> Workaround to temporary resolve the crash we have when language is changed in desktop app (`startupModule` in desktop is null and some qml bindings, during retranslate evaluation, are still calling this dead pointer).
This commit is contained in:
Noelia 2022-10-07 15:48:39 +02:00
parent 9feb81883c
commit bcbc59e9ed
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/src/DOtherSide.cpp
View File

@ -385,7 +385,8 @@ void dos_qguiapplication_load_translation(::DosQQmlApplicationEngine *vptr, cons
if (m_translator->load(translationPackage)) {
bool success = QGuiApplication::installTranslator(m_translator);
auto engine = static_cast<QQmlApplicationEngine *>(vptr);
if (shouldRetranslate) engine->retranslate();
// IMPORTANT: Workaround to temporary resolve the crash we have when language is changed (`startupModule` is null and some qml bindings are still calling this dead pointer)
// if (shouldRetranslate) engine->retranslate();
} else {
printf("Failed to load translation file %s\n", translationPackage);
}