status-im
/
discover-dapps
mirror of https://github.com/status-im/discover-dapps.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use Math.ceil() to overcome rounding & precision issues

This commit is contained in:
Andy Tudhope 2019-04-09 17:13:02 +02:00
parent 25efb90aa3
commit 82bb4751f9
No known key found for this signature in database
GPG Key ID: 02A3DFA93BF26AD2
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/dappstore_spec.js
View File

@ -394,15 +394,13 @@ contract("DAppStore", function () {
let available = Math.round(balance * rate);
let v_minted = Math.round((available/decimals) ** (decimals/rate));
let v_cast = parseInt(initial.votes_cast, 10);
let e_balance = Math.round(balance - ((v_cast*rate/decimals)*(available/decimals/v_minted)));
let e_balance = Math.ceil(balance - ((v_cast*rate/decimals)*(available/decimals/v_minted)));
let effective_balance = parseInt(receipt.newEffectiveBalance, 10);
// We begin to run into rounding & estimation issues in the BancorFormula here
// The higher the amount, the less accurate it becomes. In this setup, it is off by 1.
console.log("Calculated in JS test: " + e_balance);
console.log("Returned by contract: " + effective_balance)
//assert.strictEqual(e_balance, effective_balance);
// We begin to run into precision limitations in the BancorFormula here.
// The higher the amount, the less accurate it becomes. Hence Math.ceil() for now.
assert.strictEqual(e_balance, effective_balance);
// Having withdrawn the SNT, check that it updates the particular DApp's storage values properly
let check = await DAppStore.methods.dapps(0).call();