fix `<Button />` icon only colors (#616)

* f: adds compound variants for missing cases

* f: changeset
This commit is contained in:
marcelines 2024-10-15 20:50:24 +01:00 committed by GitHub
parent f1fa827d42
commit e9979fdad2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 55 additions and 1 deletions

View File

@ -0,0 +1,5 @@
---
'@status-im/components': patch
---
updates icon color for missing compound variants

View File

@ -1,3 +1,7 @@
import { Fragment } from 'react'
import { PlaceholderIcon } from '@status-im/icons/20'
import { Button } from './button' import { Button } from './button'
import type { Meta, StoryObj } from '@storybook/react' import type { Meta, StoryObj } from '@storybook/react'
@ -51,7 +55,22 @@ const meta: Meta<
).map(variant => ( ).map(variant => (
<div key={variant} className="flex items-center gap-4"> <div key={variant} className="flex items-center gap-4">
{(['40', '32', '24'] as const).map(size => ( {(['40', '32', '24'] as const).map(size => (
<Button key={size} {...args} variant={variant} size={size} /> <Fragment key={size}>
<Button {...args} variant={variant} size={size} />
{/* With icon */}
<Button
{...args}
size={size}
variant={variant}
iconBefore={<PlaceholderIcon />}
/>
<Button
aria-label="Button with icon only"
size={size}
variant={variant}
icon={<PlaceholderIcon />}
/>
</Fragment>
))} ))}
</div> </div>
))} ))}

View File

@ -193,11 +193,41 @@ const iconStyles = cva({
placement: 'after', placement: 'after',
className: '-mr-0.5', className: '-mr-0.5',
}, },
{
variant: 'grey',
iconOnly: true,
className: '!text-neutral-100 dark:!text-white-100',
},
{ {
variant: 'outline', variant: 'outline',
iconOnly: true, iconOnly: true,
className: '!text-neutral-100 dark:!text-white-100', className: '!text-neutral-100 dark:!text-white-100',
}, },
{
variant: 'darkGrey',
iconOnly: true,
className: '!text-neutral-100 dark:!text-white-100',
},
{
variant: 'ghost',
iconOnly: true,
className: '!text-neutral-100 dark:!text-white-100',
},
{
variant: 'primary',
iconOnly: true,
className: '!text-white-100',
},
{
variant: 'positive',
iconOnly: true,
className: '!text-white-100',
},
{
variant: 'danger',
iconOnly: true,
className: '!text-white-100',
},
], ],
}) })