status-im/dagger-contracts
2
0
Fork 0
mirror of https://github.com/status-im/dagger-contracts.git synced 2025-01-12 23:35:49 +00:00
Code Issues Projects Releases Wiki Activity

fix: ensure requestStorage() reverts if maxSlotloss > slots (#140)

Browse Source
This commit is contained in:
r4bbit 2024-08-05 10:58:51 +02:00 committed by GitHub
parent 8b3761c1a7
commit e62ebf6b0e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contracts/Marketplace.sol
View File

@ -95,6 +95,10 @@ contract Marketplace is Proofs, StateRetrieval, Endian {
request.expiry > 0 && request.expiry < request.ask.duration, request.expiry > 0 && request.expiry < request.ask.duration,
"Expiry not in range" "Expiry not in range"
); );
require(
request.ask.maxSlotLoss <= request.ask.slots,
"maxSlotLoss exceeds slots"
);
_requests[id] = request; _requests[id] = request;
_requestContexts[id].endsAt = block.timestamp + request.ask.duration; _requestContexts[id].endsAt = block.timestamp + request.ask.duration;

7
test/Marketplace.test.js
View File

@ -185,6 +185,13 @@ describe("Marketplace", function () {
) )
}) })
it("is rejected when maxSlotLoss exceeds slots", async function () {
request.ask.maxSlotLoss = request.ask.slots + 1
await expect(marketplace.requestStorage(request)).to.be.revertedWith(
"maxSlotLoss exceeds slots"
)
})
it("rejects resubmission of request", async function () { it("rejects resubmission of request", async function () {
await token.approve(marketplace.address, price(request) * 2) await token.approve(marketplace.address, price(request) * 2)
await marketplace.requestStorage(request) await marketplace.requestStorage(request)