mirror of https://github.com/status-im/consul.git
ef3b81ab13
* Allow to rename nodes with IDs, will fix #3974 and #4413 This change allow to rename any well behaving recent agent with an ID to be renamed safely, ie: without taking the name of another one with case insensitive comparison. Deprecated behaviour warning ---------------------------- Due to asceding compatibility, it is still possible however to "take" the name of another name by not providing any ID. Note that when not providing any ID, it is possible to have 2 nodes having similar names with case differences, ie: myNode and mynode which might lead to DB corruption on Consul server side and lead to server not properly restarting. See #3983 and #4399 for Context about this change. Disabling registration of nodes without IDs as specified in #4414 should probably be the way to go eventually. * Removed the case-insensitive search when adding a node within the else block since it breaks the test TestAgentAntiEntropy_Services While the else case is probably legit, it will be fixed with #4414 in a later release. * Added again the test in the else to avoid duplicated names, but enforce this test only for nodes having IDs. Thus most tests without any ID will work, and allows us fixing * Added more tests regarding request with/without IDs. `TestStateStore_EnsureNode` now test registration and renaming with IDs `TestStateStore_EnsureNodeDeprecated` tests registration without IDs and tests removing an ID from a node as well as updated a node without its ID (deprecated behaviour kept for backwards compatibility) * Do not allow renaming in case of conflict, including when other node has no ID * Fixed function GetNodeID that was not working due to wrong type when searching node from its ID Thus, all tests about renaming were not working properly. Added the full test cas that allowed me to detect it. * Better error messages, more tests when nodeID is not a valid UUID in GetNodeID() * Added separate TestStateStore_GetNodeID to test GetNodeID. More complete test coverage for GetNodeID * Added new unit test `TestStateStore_ensureNoNodeWithSimilarNameTxn` Also fixed comments to be clearer after remarks from @banks * Fixed error message in unit test to match test case * Use uuid.ParseUUID to parse Node.ID as requested by @mkeeler |
||
|---|---|---|
| .. | ||
| ae | ||
| cache | ||
| cache-types | ||
| checks | ||
| config | ||
| connect | ||
| consul | ||
| exec | ||
| local | ||
| metadata | ||
| mock | ||
| pool | ||
| proxy | ||
| router | ||
| structs | ||
| systemd | ||
| token | ||
| acl.go | ||
| acl_endpoint.go | ||
| acl_endpoint_test.go | ||
| acl_test.go | ||
| agent.go | ||
| agent_endpoint.go | ||
| agent_endpoint_test.go | ||
| agent_test.go | ||
| bindata_assetfs.go | ||
| blacklist.go | ||
| blacklist_test.go | ||
| catalog_endpoint.go | ||
| catalog_endpoint_test.go | ||
| check.go | ||
| config.go | ||
| connect_ca_endpoint.go | ||
| connect_ca_endpoint_test.go | ||
| coordinate_endpoint.go | ||
| coordinate_endpoint_test.go | ||
| dns.go | ||
| dns_test.go | ||
| enterprise_delegate_oss.go | ||
| event_endpoint.go | ||
| event_endpoint_test.go | ||
| health_endpoint.go | ||
| health_endpoint_test.go | ||
| http.go | ||
| http_oss.go | ||
| http_oss_test.go | ||
| http_test.go | ||
| intentions_endpoint.go | ||
| intentions_endpoint_test.go | ||
| keyring.go | ||
| keyring_test.go | ||
| kvs_endpoint.go | ||
| kvs_endpoint_test.go | ||
| notify.go | ||
| notify_test.go | ||
| operator_endpoint.go | ||
| operator_endpoint_test.go | ||
| prepared_query_endpoint.go | ||
| prepared_query_endpoint_test.go | ||
| remote_exec.go | ||
| remote_exec_test.go | ||
| retry_join.go | ||
| retry_join_test.go | ||
| session_endpoint.go | ||
| session_endpoint_test.go | ||
| snapshot_endpoint.go | ||
| snapshot_endpoint_test.go | ||
| status_endpoint.go | ||
| status_endpoint_test.go | ||
| testagent.go | ||
| testagent_test.go | ||
| translate_addr.go | ||
| txn_endpoint.go | ||
| txn_endpoint_test.go | ||
| ui_endpoint.go | ||
| ui_endpoint_test.go | ||
| user_event.go | ||
| user_event_test.go | ||
| util.go | ||
| util_test.go | ||
| watch_handler.go | ||
| watch_handler_test.go | ||