Michael Klein 03a1a86dfe
ui: chore - upgrade ember and friends (#14518)
* v3.20.2...v3.24.0

* Fix handle undefined outlet in route component

* Don't use template helper for optional modal.open

Using the optional-helper here will trigger a computation
in the same runloop error. This is because we are setting
the `modal`-property when the `<Ref>` component gets
rendered which will update the `this.modal`-property which
will then recompute the `optional`-helper leading to this
error.

Instead we will create an action that will call the `open`-method
on the modal when it is defined. This gets rid of the double
computation error as we will not access the modal property
twice in the same runloop when `modal` is getting set.

* Fix - fn needs to be passed function tab-nav

We create functions in the component file instead
so that fn-helper stops complaining about the
need to pass a function.

* Update ember-exam to 6.1 version

"Makes it compatible" with ember-qunit v5

* scheduleOnce setMaxHeight paged-collection

We need to schedule to get around double-computation error.

* Fix - model.data is removed from ember-data

This has been private API all along - we need to
work around the removal.

Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310

* Fix `propContains` instead of `deepEqual` policy

Recent model.data works differently than iterating attributes.
We use `propContains` instead of `deepEqual`. We are only
interested in the properties we assert against and match
the previous behavior with this change.

* Fix `propContains` instead of `deepEqual` token

* Better handling single-records repo test-helper

`model.data` has been removed we need to handle proxies and
model instances differently.

* Fix remaining repository tests with propContains

We don't want to match entire objects - we don't care
about properties we haven't defined in the assertion.

* Don't use template helper for optional modal.open

Using a template helper will give us a recomputation error -
we work around it by creating an explicit action on
the component instead.

* Await `I $verb the $pageObject object` step

* Fix no more customization ember-can

No need to customize, the helper handles destruction
fine on its own.

* Fix - don't pass `optional` functions to fn

We will declare the functions on the component instead.
This gives us the same behavior but no error from
`fn`, which expects a function to be passed.

* Fix - handle `undefined` state on validate modifier

StateChart can yield out an undefined `state` we need
to handle that in the validate modifier

* Fix linting errors tests directory

* Warn / turn off new ember linting issues

We will tackle them one by one and don't want to
autofix issues that could be dangerous to auto-fix.

* Auto-fix linting issues

* More linting configuration

* Fix remaining linting issues

* Fix linting issues new files after rebase

* ui: Remove ember-cli-uglify config now we are using terser (#14574)

Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
2022-09-15 09:43:17 +01:00

98 lines
3.4 KiB
JavaScript

export default function (scenario, find, fillIn, triggerKeyEvent, currentPage) {
const dont = `( don't| shouldn't| can't)?`;
const fillInElement = async function (page, name, value) {
const cm = document.querySelector(`textarea[name="${name}"] + .CodeMirror`);
if (cm) {
if (!cm.CodeMirror.options.readOnly) {
cm.CodeMirror.setValue(value);
} else {
throw new Error(`The ${name} editor is set to readonly`);
}
return page;
} else {
const $el = document.querySelector(`[name="${name}"]`);
await fillIn($el, value);
return page;
}
};
scenario
.when('I submit', function (selector) {
return currentPage().submit();
})
.then('I fill in "$name" with "$value"', function (name, value) {
return currentPage().fillIn(name, value);
})
.then(['I fill in with yaml\n$yaml', 'I fill in with json\n$json'], async function (data) {
const res = Object.keys(data).reduce(function (prev, item, i, arr) {
return fillInElement(prev, item, data[item]);
}, currentPage());
await new Promise((resolve) => setTimeout(resolve, 0));
return res;
})
.then(
[
`I${dont} fill in the $property form with yaml\n$yaml`,
`I${dont} fill in $property with yaml\n$yaml`,
`I${dont} fill in the $property with yaml\n$yaml`,
`I${dont} fill in the property form with json\n$json`,
`I${dont} fill in the $property form on the $component component with yaml\n$yaml`,
`I${dont} fill in the $property form on the $component component with json\n$json`,
`I${dont} fill in the $property on the $component component with yaml\n$yaml`,
],
async function (negative, property, component, data, next) {
switch (true) {
case typeof component === 'string':
property = `${component}.${property}`;
// fallthrough
case typeof data === 'undefined':
data = component;
// // fallthrough
// case typeof property !== 'string':
// data = property;
}
let obj;
try {
obj = find(property);
} catch (e) {
obj = currentPage();
}
const res = Object.keys(data).reduce(async function (prev, item, i, arr) {
await prev;
const name = `${obj.prefix || property}[${item}]`;
if (negative) {
try {
await fillInElement(obj, name, data[item]);
throw new TypeError(`${item} is editable`);
} catch (e) {
if (e instanceof TypeError) {
throw e;
}
}
} else {
return await fillInElement(obj, name, data[item]);
}
}, Promise.resolve());
return res;
}
)
.then(['I type "$text" into "$selector"'], function (text, selector) {
return fillIn(selector, text);
})
.then(['I type with yaml\n$yaml'], function (data) {
const keys = Object.keys(data);
return keys
.reduce(function (prev, item, i, arr) {
return prev.fillIn(item, data[item]);
}, currentPage())
.then(function () {
return Promise.all(
keys.map(function (item) {
return triggerKeyEvent(`[name="${item}"]`, 'keyup', 83); // TODO: This is 's', be more generic
})
);
});
});
}