mirror of https://github.com/status-im/consul.git
9bfa9afb5a
* ui: Move all our icons to use CSS custom properties The good thing about SASS vars is, if you don't use them they get removed from the final build. Whereas with CSS we have no tree-shaking to get rid of unused CSS custom properties. We can mostly work around this and for some things like colors its no big deal if we have some hex-codes in the build that we don't use as hex-codes are relatively small. We've been slowly but surely moving all of our colors (and other things) to use CSS custom properties instead of SASS vars now that we have them available. This commit makes use of the 'tree-shaking' abilities of @extend to ensure that we only compile in the icons that we use. This commit is mostly churn-less as we already use @extend for the majority of our icons, so generally there is zero change here for working on the UI, but I did spot one single place where we were using SASS vars instead of @extend. This now uses the new form (second commit) Interestingly this reduces our CSS payload by ~2kb to ~53kb (around 25kb of that is these icons) |
||
|---|---|---|
| .. | ||
| base | ||
| components | ||
| layouts | ||
| routes/dc | ||
| variables | ||
| app.scss | ||
| components.scss | ||
| debug.scss | ||
| layout.scss | ||
| prism-coldark-cold.scss | ||
| prism-coldark-dark.scss | ||
| routes.scss | ||
| themes.scss | ||
| typography.scss | ||
| variables.scss | ||