mirror of
https://github.com/status-im/consul.git
synced 2025-01-09 21:35:52 +00:00
cf638ee551
* ui: Ignore response from API for KV permissions Currently there is no way for us to use our HTTP authorization API endpoint to tell us whether a user has access to any KVs (including the case where a user may not have access to the root KV store, but do have access to a sub item) This is a little weird still as in the above case the user would click on this link and still get a 403 for the root, and then have to manually type in the URL for the KV they do have access to. Despite this we think this change makes sense as at least something about KV is visible in the main navigation. Once we have the ability to know if any KVs are accessible, we can add this guard back in. We'd initially just removed the logic around the button, but then noticed there may be further related KV issues due to the nested nature of KVs so we finally decided on simply ignoring the responses from the HTTP API, essentially reverting the KV area back to being a thin client. This means when things are revisited in the backend we can undo this easily change in one place. * Move acceptance tests to use ACLs perms instead of KV ones
34 lines
827 B
Gherkin
34 lines
827 B
Gherkin
@setupApplicationTest
|
|
Feature: navigation-links: Main Navigation link visibility
|
|
Scenario: No read access to Key/Values
|
|
Given 1 datacenter model with the value "dc-1"
|
|
And the url "/v1/internal/acl/authorize" responds with from yaml
|
|
---
|
|
body:
|
|
- Resource: operator
|
|
Access: write
|
|
Allow: true
|
|
- Resource: service
|
|
Access: read
|
|
Allow: true
|
|
- Resource: node
|
|
Access: read
|
|
Allow: true
|
|
- Resource: key
|
|
Access: read
|
|
Allow: true
|
|
- Resource: intention
|
|
Access: read
|
|
Allow: true
|
|
- Resource: acl
|
|
Access: read
|
|
Allow: false
|
|
---
|
|
When I visit the services page for yaml
|
|
---
|
|
dc: dc-1
|
|
---
|
|
Then I see services on the navigation
|
|
Then I don't see roles on the navigation
|
|
|