mirror of
https://github.com/status-im/consul.git
synced 2025-01-21 02:59:48 +00:00
92f0eb3bdc
We've always had this idea of being able to markup up information
semantically without thinking about what it should look like, then
applying our %h* placeholder styles to control what the information
should look like.
Back when we originally made our set of %h* placeholders, we tried to
follow Structure as much as possible, which defined the largest header
(which we thought would have been the h1 style) as a super large 3.5rem.
Therefore we made our set of %h* placeholders the same as Structure
beginning at a huge 3.5 size. We then re-overwrote those sizes only in
Consul specific CSS files thinking that this was due to us existing
before Structure did.
Lately we saw an extra clue in Structure - the extra large 3.5 header was
called 'h0'.
This commit moves all our headers to use a zero based scale, and
additionally uses our 3 digit scale as opposed to 1 digit (h1 vs h100),
similar to our color scales (note we don't use a hypen, which we can
alter later if need be), which means we can insert additional h150 etc
if need be.
Additional we stop styling our headers globally (h1 { @extend %h100; }
). This means there is no reason not to use headers for marking up
content depending on what it is rather than what it should look like,
and as a consequence means we can be more purposeful in ordering h*
tags.
Lastly, we use the new scale over the entire codebase and update a
couple of places where we were using using header tags due to what the
styleing for them looked like rather than what the meaning/order was.
32 lines
722 B
SCSS
32 lines
722 B
SCSS
%app-view-content-empty {
|
|
@extend %frame-gray-500;
|
|
}
|
|
%app-view-title {
|
|
border-bottom: $decor-border-100;
|
|
}
|
|
%app-view-title > *:first-child {
|
|
@extend %h100;
|
|
}
|
|
%app-view-content form:not(.filter-bar) fieldset {
|
|
border-bottom: $decor-border-200;
|
|
}
|
|
%app-view-header h1 > em {
|
|
color: $gray-600;
|
|
}
|
|
%app-view-header dd > a {
|
|
color: $black;
|
|
}
|
|
%app-view-content div > dl > dd {
|
|
color: $gray-400;
|
|
}
|
|
%app-view-title,
|
|
%app-view-content form:not(.filter-bar) fieldset {
|
|
border-color: $gray-200;
|
|
}
|
|
// We know that any sibling navs might have a top border
|
|
// by default. As its squashed up to a %app-view-title, in this
|
|
// case hide its border to avoid double border
|
|
%app-view-title ~ nav {
|
|
border-top: 0 !important;
|
|
}
|