mirror of https://github.com/status-im/consul.git
831d84c940
When the metadata server is scanning the agents for potential servers it is parsing the version number which the agent provided when it joined. This version number has to conform to a certain format, i.e. 'n.n.n'. Without this version number properly set some tests fail with error messages that disguise the root cause. The default version number is currently set to 'unknown' in version/version.go which does not parse and triggers the tests to fail. The work around is to use a build tag 'consul' which will use the version number set in version_base.go instead which has the correct format and is set to the current release version. In addition, some parts of the code also require the version number to be of a certain value. Setting it to '0.0.0' for example makes some tests pass and others fail since they don't pass the semantic check. When using go build/install/test one has to remember to use '-tags consul' or tests will fail with non-obvious error messages. Using build tags makes the build process more complex and error prone since it prevents the use of the plain go toolchain and - at least in its current form - introduces subtle build and test issues. We should try to eliminate build tags for anything else but platform specific code. This patch removes all references to specific version numbers in the code and tests and sets the default version to '9.9.9' which is syntactically correct and passes the semantic check. This solves the issue of running go build/install/test without tags for the OSS build. |
||
|---|---|---|
| .. | ||
| agent.go | ||
| agent_test.go | ||
| base.go | ||
| catalog_command.go | ||
| catalog_command_test.go | ||
| catalog_list_datacenters.go | ||
| catalog_list_datacenters_test.go | ||
| catalog_list_nodes.go | ||
| catalog_list_nodes_test.go | ||
| catalog_list_services.go | ||
| catalog_list_services_test.go | ||
| commands.go | ||
| configtest.go | ||
| configtest_test.go | ||
| event.go | ||
| event_test.go | ||
| exec.go | ||
| exec_test.go | ||
| force_leave.go | ||
| force_leave_test.go | ||
| info.go | ||
| info_test.go | ||
| join.go | ||
| join_test.go | ||
| keygen.go | ||
| keygen_test.go | ||
| keyring.go | ||
| keyring_test.go | ||
| kv_command.go | ||
| kv_command_test.go | ||
| kv_delete.go | ||
| kv_delete_test.go | ||
| kv_export.go | ||
| kv_export_test.go | ||
| kv_get.go | ||
| kv_get_test.go | ||
| kv_import.go | ||
| kv_import_test.go | ||
| kv_put.go | ||
| kv_put_test.go | ||
| leave.go | ||
| leave_test.go | ||
| lock.go | ||
| lock_test.go | ||
| maint.go | ||
| maint_test.go | ||
| members.go | ||
| members_test.go | ||
| monitor.go | ||
| operator.go | ||
| operator_autopilot.go | ||
| operator_autopilot_get.go | ||
| operator_autopilot_get_test.go | ||
| operator_autopilot_set.go | ||
| operator_autopilot_set_test.go | ||
| operator_autopilot_test.go | ||
| operator_raft.go | ||
| operator_raft_list.go | ||
| operator_raft_list_test.go | ||
| operator_raft_remove.go | ||
| operator_raft_remove_test.go | ||
| operator_raft_test.go | ||
| operator_test.go | ||
| reload.go | ||
| reload_test.go | ||
| rtt.go | ||
| rtt_test.go | ||
| snapshot_command.go | ||
| snapshot_command_test.go | ||
| snapshot_inspect.go | ||
| snapshot_inspect_test.go | ||
| snapshot_restore.go | ||
| snapshot_restore_test.go | ||
| snapshot_save.go | ||
| snapshot_save_test.go | ||
| util_test.go | ||
| util_unix.go | ||
| util_windows.go | ||
| validate.go | ||
| validate_test.go | ||
| version.go | ||
| version_test.go | ||
| watch.go | ||
| watch_test.go | ||