mirror of
https://github.com/status-im/consul.git
synced 2025-02-22 18:38:19 +00:00
03a1a86dfe
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
56 lines
2.1 KiB
JavaScript
56 lines
2.1 KiB
JavaScript
import { readOnly } from '@ember/object/computed';
|
|
import Component from '@ember/component';
|
|
import { isPresent } from '@ember/utils';
|
|
import { get, set, defineProperty, computed } from '@ember/object';
|
|
import layout from '../templates/components/block-slot';
|
|
import Slots from '../mixins/slots';
|
|
import YieldSlot from './yield-slot';
|
|
const BlockSlot = Component.extend({
|
|
layout,
|
|
tagName: '',
|
|
_name: computed('name', function () {
|
|
return this.name;
|
|
}),
|
|
didInsertElement: function () {
|
|
const slottedComponent = this.nearestOfType(Slots);
|
|
if (!slottedComponent._isRegistered(this._name)) {
|
|
slottedComponent._activateSlot(this._name);
|
|
set(this, 'slottedComponent', slottedComponent);
|
|
return;
|
|
}
|
|
const yieldSlot = this.nearestOfType(YieldSlot);
|
|
if (yieldSlot) {
|
|
set(this, '_yieldSlot', yieldSlot);
|
|
// The slotted component will yield multiple times - once to register
|
|
// the activate slots and once more per active slot - only display this
|
|
// block when its associated slot is the one yielding
|
|
const isTargetSlotYielding = get(yieldSlot, '_name') === this._name;
|
|
set(this, 'isTargetSlotYielding', isTargetSlotYielding);
|
|
|
|
// If the associated slot has block params, create a computed property
|
|
// for each block param. Technically this could be an unlimited, but
|
|
// hbs lacks a spread operator so params are currently limited to 9
|
|
// (see the yield in the block-slot template)
|
|
//
|
|
// Spread PR: https://github.com/wycats/handlebars.js/pull/1149
|
|
const params = get(yieldSlot, '_blockParams');
|
|
if (isTargetSlotYielding && isPresent(params)) {
|
|
// p0 p1 p2...
|
|
params.forEach((param, index) => {
|
|
defineProperty(this, `p${index}`, readOnly(`_yieldSlot._blockParams.${index}`));
|
|
});
|
|
}
|
|
}
|
|
},
|
|
willDestroyElement: function () {
|
|
if (this.slottedComponent) {
|
|
// Deactivate the yield slot using the slots interface when the block
|
|
// is destroyed to allow the yield slot default {{else}} to take effect
|
|
// dynamically
|
|
this.slottedComponent._deactivateSlot(this._name);
|
|
}
|
|
},
|
|
});
|
|
|
|
export default BlockSlot;
|