Michael Klein 03a1a86dfe
ui: chore - upgrade ember and friends (#14518)
* v3.20.2...v3.24.0

* Fix handle undefined outlet in route component

* Don't use template helper for optional modal.open

Using the optional-helper here will trigger a computation
in the same runloop error. This is because we are setting
the `modal`-property when the `<Ref>` component gets
rendered which will update the `this.modal`-property which
will then recompute the `optional`-helper leading to this
error.

Instead we will create an action that will call the `open`-method
on the modal when it is defined. This gets rid of the double
computation error as we will not access the modal property
twice in the same runloop when `modal` is getting set.

* Fix - fn needs to be passed function tab-nav

We create functions in the component file instead
so that fn-helper stops complaining about the
need to pass a function.

* Update ember-exam to 6.1 version

"Makes it compatible" with ember-qunit v5

* scheduleOnce setMaxHeight paged-collection

We need to schedule to get around double-computation error.

* Fix - model.data is removed from ember-data

This has been private API all along - we need to
work around the removal.

Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310

* Fix `propContains` instead of `deepEqual` policy

Recent model.data works differently than iterating attributes.
We use `propContains` instead of `deepEqual`. We are only
interested in the properties we assert against and match
the previous behavior with this change.

* Fix `propContains` instead of `deepEqual` token

* Better handling single-records repo test-helper

`model.data` has been removed we need to handle proxies and
model instances differently.

* Fix remaining repository tests with propContains

We don't want to match entire objects - we don't care
about properties we haven't defined in the assertion.

* Don't use template helper for optional modal.open

Using a template helper will give us a recomputation error -
we work around it by creating an explicit action on
the component instead.

* Await `I $verb the $pageObject object` step

* Fix no more customization ember-can

No need to customize, the helper handles destruction
fine on its own.

* Fix - don't pass `optional` functions to fn

We will declare the functions on the component instead.
This gives us the same behavior but no error from
`fn`, which expects a function to be passed.

* Fix - handle `undefined` state on validate modifier

StateChart can yield out an undefined `state` we need
to handle that in the validate modifier

* Fix linting errors tests directory

* Warn / turn off new ember linting issues

We will tackle them one by one and don't want to
autofix issues that could be dangerous to auto-fix.

* Auto-fix linting issues

* More linting configuration

* Fix remaining linting issues

* Fix linting issues new files after rebase

* ui: Remove ember-cli-uglify config now we are using terser (#14574)

Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
2022-09-15 09:43:17 +01:00

149 lines
3.6 KiB
JavaScript

import LinkComponent from '@ember/routing/link-component';
export class HrefTo {
constructor(container, target) {
this.applicationInstance = container;
this.target = target;
const hrefAttr = this.target.attributes.href;
this.url = hrefAttr && hrefAttr.value;
}
handle(e) {
if (this.shouldHandle(e)) {
e.preventDefault();
this.applicationInstance.lookup('router:main').location.transitionTo(this.url);
}
}
shouldHandle(e) {
return (
this.isUnmodifiedLeftClick(e) &&
!this.isIgnored(this.target) &&
!this.isExternal(this.target) &&
!this.hasActionHelper(this.target) &&
!this.hasDownload(this.target) &&
!this.isLinkComponent(this.target)
);
// && this.recognizeUrl(this.url);
}
isUnmodifiedLeftClick(e) {
return (e.which === undefined || e.which === 1) && !e.ctrlKey && !e.metaKey;
}
isExternal($el) {
return $el.getAttribute('target') === '_blank';
}
isIgnored($el) {
return $el.dataset.nativeHref;
}
hasActionHelper($el) {
return $el.dataset.emberAction;
}
hasDownload($el) {
return $el.hasAttribute('download');
}
isLinkComponent($el) {
let isLinkComponent = false;
const id = $el.id;
if (id) {
const componentInstance = this.applicationInstance.lookup('-view-registry:main')[id];
isLinkComponent = componentInstance && componentInstance instanceof LinkComponent;
}
return isLinkComponent;
}
recognizeUrl(url) {
let didRecognize = false;
if (url) {
const router = this._getRouter();
const rootUrl = this._getRootUrl();
const isInternal = url.indexOf(rootUrl) === 0;
const urlWithoutRoot = this.getUrlWithoutRoot();
const routerMicrolib = router._router._routerMicrolib || router._router.router;
didRecognize = isInternal && routerMicrolib.recognizer.recognize(urlWithoutRoot);
}
return didRecognize;
}
getUrlWithoutRoot() {
const location = this.applicationInstance.lookup('router:main').location;
let url = location.getURL.apply(
{
getHash: () => '',
location: {
pathname: this.url,
},
baseURL: location.baseURL,
rootURL: location.rootURL,
env: location.env,
},
[]
);
const pos = url.indexOf('?');
if (pos !== -1) {
url = url.substr(0, pos - 1);
}
return url;
}
_getRouter() {
return this.applicationInstance.lookup('service:router');
}
_getRootUrl() {
let router = this._getRouter();
let rootURL = router.get('rootURL');
if (rootURL.charAt(rootURL.length - 1) !== '/') {
rootURL = rootURL + '/';
}
return rootURL;
}
}
function closestLink(el) {
if (el.closest) {
return el.closest('a');
} else {
el = el.parentElement;
while (el && el.tagName !== 'A') {
el = el.parentElement;
}
return el;
}
}
export default {
name: 'href-to',
initialize(container) {
// we only want this to run in the browser, not in fastboot
if (typeof FastBoot === 'undefined') {
const dom = container.lookup('service:dom');
const doc = dom.document();
const listener = (e) => {
const link = e.target.tagName === 'A' ? e.target : closestLink(e.target);
if (link) {
const hrefTo = new HrefTo(container, link);
hrefTo.handle(e);
}
};
doc.body.addEventListener('click', listener);
container.reopen({
willDestroy() {
doc.body.removeEventListener('click', listener);
return this._super(...arguments);
},
});
}
},
};