mirror of
https://github.com/status-im/consul.git
synced 2025-01-15 16:26:06 +00:00
b16a6fa033
This PR mainly adds partition to our HTTP adapter. Additionally and perhaps most importantly, we've also taken the opportunity to move our 'conditional namespaces' deeper into the app. The reason for doing this was, we like that namespaces should be thought of as required instead of conditional, 'special' things and would like the same thinking to be applied to partitions. Now, instead of using code throughout the app throughout the adapters to add/remove namespaces or partitions depending on whether they are enabled or not. As a UI engineer you just pretend that namespaces and partitions are always enabled, and we remove them for you deeper in the app, out of the way of you forgetting to treat these properties as a special case. Notes: Added a PartitionAbility while we were there (not used as yet) Started to remove the CONSTANT variables we had just for property names. I prefer that our adapters are as readable and straightforwards as possible, it just looks like HTTP. We'll probably remove our formatDatacenter method we use also at some point, it was mainly too make it look the same as our previous formatNspace, but now we don't have that, it instead now looks different! We enable parsing of partition in the UIs URL, but this is feature flagged so still does nothing just yet. All of the test changes were related to the fact that we were treating client.url as a function rather than a method, and now that we reference this in client.url (etc) it needs binding to client.
108 lines
4.0 KiB
JavaScript
108 lines
4.0 KiB
JavaScript
import { get as httpGet } from 'consul-ui/tests/helpers/api';
|
|
import { get, set } from '@ember/object';
|
|
import measure from 'consul-ui/tests/helpers/measure';
|
|
|
|
/** Stub an ember-data adapter response using the private method
|
|
*
|
|
* Allows you to easily specify a HTTP response for the Adapter. The stub only works
|
|
* during the 'lifetime' of `cb` and is reset to normal unstubbed functionality afterwards.
|
|
*
|
|
* Please Note: This overwrites a private ember-data Adapter method, please understand
|
|
* the consequences of doing this if you are using it
|
|
*
|
|
* @param {function} cb - The callback, or test case, to run using the stubbed response
|
|
* @param {object} payload - The payload to use as the response
|
|
* @param {DS.Adapter} adapter - An instance of an ember-data Adapter
|
|
*/
|
|
const stubAdapterResponse = function(cb, payload, adapter) {
|
|
const payloadClone = JSON.parse(JSON.stringify(payload));
|
|
const client = get(adapter, 'client');
|
|
set(adapter, 'client', {
|
|
request: function(cb) {
|
|
return cb(function() {
|
|
const params = client.requestParams(...arguments);
|
|
payload.headers['X-Consul-Namespace'] = params.data.ns || 'default';
|
|
return Promise.resolve(function(cb) {
|
|
return cb(payload.headers, payloadClone.payload);
|
|
});
|
|
});
|
|
},
|
|
});
|
|
return cb(payload.payload).then(function(result) {
|
|
set(adapter, 'client', client);
|
|
return result;
|
|
});
|
|
};
|
|
/** `repo` a helper function to faciliate easy integration testing of ember-data Service 'repo' layers
|
|
*
|
|
* Test performance is also measured using `consul-ui/tests/helpers/measure` and therefore results
|
|
* can optionally be sent to a centralized metrics collection stack
|
|
*
|
|
* @param {string} name - The name of your repo Service (only used for meta purposes)
|
|
* @param {string} payload - The method you are testing (only used for meta purposes)
|
|
* @param {Service} service - An instance of an ember-data based repo Service
|
|
* @param {function} stub - A function that receives a `stub` function allowing you to stub
|
|
* an API endpoint with a set of cookies/env vars used by the double
|
|
* @param {function} test - Your test case. This function receives an instance of the Service provided
|
|
* above as a first and only argument, it should return the result of your test
|
|
* @param {function} assert - Your assertion. This receives the result of the previous function as the first
|
|
* argument and a function to that receives the stubbed payload giving you an
|
|
* opportunity to mutate it before returning for use in your assertion
|
|
*/
|
|
export default function(name, method, service, stub, test, assert) {
|
|
const adapter = get(service, 'store').adapterFor(name.toLowerCase());
|
|
let tags = {};
|
|
const requestHeaders = function(url, cookies = {}) {
|
|
const key = Object.keys(cookies).find(function(item) {
|
|
return item.indexOf('COUNT') !== -1;
|
|
});
|
|
tags = {
|
|
count: typeof key !== 'undefined' ? parseInt(cookies[key]) : 1,
|
|
};
|
|
return httpGet(url, {
|
|
headers: {
|
|
cookie: cookies,
|
|
},
|
|
}).then(function(payload) {
|
|
return {
|
|
headers: {},
|
|
payload: payload,
|
|
};
|
|
});
|
|
};
|
|
const parseResponse = function(response) {
|
|
let actual;
|
|
if (typeof response.toArray === 'function') {
|
|
actual = response.toArray().map(function(item) {
|
|
return get(item, 'data');
|
|
});
|
|
} else {
|
|
if (typeof response.get === 'function') {
|
|
actual = get(response, 'data');
|
|
} else {
|
|
actual = response;
|
|
}
|
|
}
|
|
return actual;
|
|
};
|
|
return stub(requestHeaders).then(function(payload) {
|
|
return stubAdapterResponse(
|
|
function(payload) {
|
|
return measure(
|
|
function() {
|
|
return test(service);
|
|
},
|
|
`${name}Service.${method}`,
|
|
tags
|
|
).then(function(response) {
|
|
assert(parseResponse(response), function(cb) {
|
|
return cb(payload);
|
|
});
|
|
});
|
|
},
|
|
payload,
|
|
adapter
|
|
);
|
|
});
|
|
}
|