mirror of
https://github.com/status-im/consul.git
synced 2025-02-15 07:07:18 +00:00
This patch refactors the commands that use the mitchellh/cli library to populate the command line flag set in both the Run() and the Help() method. Earlier versions of the mitchellh/cli library relied on the Run() method to populuate the flagset for generating the usage screen. This has changed in later versions and was previously solved with a small monkey patch to the library to restore the old behavior. However, this makes upgrading the library difficult since the patch has to be restored every time. This patch addresses this by moving the command line flags into an initFlags() method where appropriate and also moving all variables for the flags from the Run() method into the command itself. Fixes #3536
153 lines
3.7 KiB
Go
153 lines
3.7 KiB
Go
package command
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/hashicorp/consul/api"
|
|
)
|
|
|
|
// KVDeleteCommand is a Command implementation that is used to delete a key or
|
|
// prefix of keys from the key-value store.
|
|
type KVDeleteCommand struct {
|
|
BaseCommand
|
|
|
|
// flags
|
|
cas bool
|
|
modifyIndex uint64
|
|
recurse bool
|
|
}
|
|
|
|
func (c *KVDeleteCommand) initFlags() {
|
|
c.InitFlagSet()
|
|
c.FlagSet.BoolVar(&c.cas, "cas", false,
|
|
"Perform a Check-And-Set operation. Specifying this value also requires "+
|
|
"the -modify-index flag to be set. The default value is false.")
|
|
c.FlagSet.Uint64Var(&c.modifyIndex, "modify-index", 0,
|
|
"Unsigned integer representing the ModifyIndex of the key. This is "+
|
|
"used in combination with the -cas flag.")
|
|
c.FlagSet.BoolVar(&c.recurse, "recurse", false,
|
|
"Recursively delete all keys with the path. The default value is false.")
|
|
}
|
|
|
|
func (c *KVDeleteCommand) Help() string {
|
|
c.initFlags()
|
|
return c.HelpCommand(`
|
|
Usage: consul kv delete [options] KEY_OR_PREFIX
|
|
|
|
Removes the value from Consul's key-value store at the given path. If no
|
|
key exists at the path, no action is taken.
|
|
|
|
To delete the value for the key named "foo" in the key-value store:
|
|
|
|
$ consul kv delete foo
|
|
|
|
To delete all keys which start with "foo", specify the -recurse option:
|
|
|
|
$ consul kv delete -recurse foo
|
|
|
|
This will delete the keys named "foo", "food", and "foo/bar/zip" if they
|
|
existed.
|
|
|
|
`)
|
|
}
|
|
|
|
func (c *KVDeleteCommand) Run(args []string) int {
|
|
c.initFlags()
|
|
if err := c.FlagSet.Parse(args); err != nil {
|
|
return 1
|
|
}
|
|
|
|
key := ""
|
|
|
|
// Check for arg validation
|
|
args = c.FlagSet.Args()
|
|
switch len(args) {
|
|
case 0:
|
|
key = ""
|
|
case 1:
|
|
key = args[0]
|
|
default:
|
|
c.UI.Error(fmt.Sprintf("Too many arguments (expected 1, got %d)", len(args)))
|
|
return 1
|
|
}
|
|
|
|
// This is just a "nice" thing to do. Since pairs cannot start with a /, but
|
|
// users will likely put "/" or "/foo", lets go ahead and strip that for them
|
|
// here.
|
|
if len(key) > 0 && key[0] == '/' {
|
|
key = key[1:]
|
|
}
|
|
|
|
// If the key is empty and we are not doing a recursive delete, this is an
|
|
// error.
|
|
if key == "" && !c.recurse {
|
|
c.UI.Error("Error! Missing KEY argument")
|
|
return 1
|
|
}
|
|
|
|
// ModifyIndex is required for CAS
|
|
if c.cas && c.modifyIndex == 0 {
|
|
c.UI.Error("Must specify -modify-index with -cas!")
|
|
return 1
|
|
}
|
|
|
|
// Specifying a ModifyIndex for a non-CAS operation is not possible.
|
|
if c.modifyIndex != 0 && !c.cas {
|
|
c.UI.Error("Cannot specify -modify-index without -cas!")
|
|
}
|
|
|
|
// It is not valid to use a CAS and recurse in the same call
|
|
if c.recurse && c.cas {
|
|
c.UI.Error("Cannot specify both -cas and -recurse!")
|
|
return 1
|
|
}
|
|
|
|
// Create and test the HTTP client
|
|
client, err := c.HTTPClient()
|
|
if err != nil {
|
|
c.UI.Error(fmt.Sprintf("Error connecting to Consul agent: %s", err))
|
|
return 1
|
|
}
|
|
|
|
switch {
|
|
case c.recurse:
|
|
if _, err := client.KV().DeleteTree(key, nil); err != nil {
|
|
c.UI.Error(fmt.Sprintf("Error! Did not delete prefix %s: %s", key, err))
|
|
return 1
|
|
}
|
|
|
|
c.UI.Info(fmt.Sprintf("Success! Deleted keys with prefix: %s", key))
|
|
return 0
|
|
case c.cas:
|
|
pair := &api.KVPair{
|
|
Key: key,
|
|
ModifyIndex: c.modifyIndex,
|
|
}
|
|
|
|
success, _, err := client.KV().DeleteCAS(pair, nil)
|
|
if err != nil {
|
|
c.UI.Error(fmt.Sprintf("Error! Did not delete key %s: %s", key, err))
|
|
return 1
|
|
}
|
|
if !success {
|
|
c.UI.Error(fmt.Sprintf("Error! Did not delete key %s: CAS failed", key))
|
|
return 1
|
|
}
|
|
|
|
c.UI.Info(fmt.Sprintf("Success! Deleted key: %s", key))
|
|
return 0
|
|
default:
|
|
if _, err := client.KV().Delete(key, nil); err != nil {
|
|
c.UI.Error(fmt.Sprintf("Error deleting key %s: %s", key, err))
|
|
return 1
|
|
}
|
|
|
|
c.UI.Info(fmt.Sprintf("Success! Deleted key: %s", key))
|
|
return 0
|
|
}
|
|
}
|
|
|
|
func (c *KVDeleteCommand) Synopsis() string {
|
|
return "Removes data from the KV store"
|
|
}
|