consul/agent/cache-types
Matt Keeler 12acdd7481
Disable background cache refresh for Connect Leaf Certs
The rationale behind removing them is that all of our own code (xDS, builtin connect proxy) use the cache notification mechanism. This ensures that the blocking fetch behind the scenes is always executing. Therefore the only way you might go to get a certificate and have to wait is when 1) the request has never been made for that cert before or 2) you are using the v1/agent/connect/ca/leaf API for retrieving the cert yourself.

In the first case, the refresh change doesn’t alter the behavior. In the second case, it can be mitigated by using blocking queries with that API which just like normal cache notification mechanism will cause the blocking fetch to be initiated and to get leaf certs as soon as needed.

If you are not using blocking queries, or Envoy/xDS, or the builtin connect proxy but are retrieving the certs yourself then the HTTP endpoint might take a little longer to respond.

This also renames the RefreshTimeout field on the register options to QueryTimeout to more accurately reflect that it is used for any type that supports blocking queries.
2020-07-21 12:19:25 -04:00
..
catalog_datacenters.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
catalog_datacenters_test.go ci: enable SA4006 staticcheck check 2020-06-16 13:10:11 -04:00
catalog_list_services.go agent/cache: Use AllowNotModifiedResponse in CatalogListServices 2020-07-14 18:58:20 -04:00
catalog_list_services_test.go agent/cache: Use AllowNotModifiedResponse in CatalogListServices 2020-07-14 18:58:20 -04:00
catalog_service_list.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
catalog_service_list_test.go Gateway Services Nodes UI Endpoint (#7685) 2020-05-11 11:35:17 -06:00
catalog_services.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
catalog_services_test.go Enable gofmt simplify 2020-06-16 13:21:11 -04:00
config_entry.go Add TLS option and DNS SAN support to ingress config 2020-05-06 15:12:02 -05:00
config_entry_test.go Add TLS option and DNS SAN support to ingress config 2020-05-06 15:12:02 -05:00
connect_ca_leaf.go Disable background cache refresh for Connect Leaf Certs 2020-07-21 12:19:25 -04:00
connect_ca_leaf_oss.go Updates to Config Entries and Connect for Namespaces (#7116) 2020-01-24 10:04:58 -05:00
connect_ca_leaf_test.go ci: Enabled SA2002 staticcheck check 2020-06-05 17:50:11 -04:00
connect_ca_root.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
connect_ca_root_test.go agent/cache-types: rename to separate root and leaf cache types 2018-06-14 09:42:01 -07:00
discovery_chain.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
discovery_chain_test.go connect: generate the full SNI names for discovery targets in the compiler rather than in the xds package (#6340) 2019-08-19 13:03:03 -05:00
federation_state_list_gateways.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
federation_state_list_gateways_test.go wan federation via mesh gateways (#6884) 2020-03-09 15:59:02 -05:00
gateway_services.go Move GatewayServices out of Internal 2020-06-12 13:46:47 -06:00
gateway_services_test.go Move compound service names to use ServiceName type 2020-06-12 13:47:43 -06:00
health_services.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
health_services_test.go bugfix: use ServiceTags to generate cache key hash (#4987) 2019-01-07 21:30:47 +00:00
intention_match.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
intention_match_test.go agent/cache: address PR feedback, lots of typos 2018-06-14 09:42:03 -07:00
mock_RPC.go agent/cache: Reorganize some files, RequestInfo struct, prepare for partitioning 2018-06-14 09:42:00 -07:00
node_services.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
node_services_test.go Allow DNS interface to use agent cache (#5300) 2019-02-25 14:06:01 -05:00
options.go Disable background cache refresh for Connect Leaf Certs 2020-07-21 12:19:25 -04:00
prepared_query.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
prepared_query_test.go Support Agent Caching for Service Discovery Results (#4541) 2018-10-10 16:55:34 +01:00
resolved_service_config.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
resolved_service_config_test.go Enable gofmt simplify 2020-06-16 13:21:11 -04:00
rpc.go agent/cache: Reorganize some files, RequestInfo struct, prepare for partitioning 2018-06-14 09:42:00 -07:00
service_checks.go ci: enable SA4006 staticcheck check 2020-06-16 13:10:11 -04:00
service_checks_test.go Fix a number of problems found by staticcheck 2020-05-19 16:50:14 -04:00
service_dump.go agent/cache: Make all cache options RegisterOptions 2020-04-16 18:56:34 -04:00
service_dump_test.go Implement Kind based ServiceDump and caching of the ServiceDump RPC 2019-07-01 16:28:30 -04:00
testing.go agent/cache-types: got basic CA leaf caching work, major problems still 2018-06-14 09:42:01 -07:00