mirror of
https://github.com/status-im/consul.git
synced 2025-02-22 18:38:19 +00:00
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
209 lines
5.4 KiB
JavaScript
209 lines
5.4 KiB
JavaScript
/* eslint no-console: ["error", { allow: ["debug"] }] */
|
|
import Component from '@glimmer/component';
|
|
import { inject as service } from '@ember/service';
|
|
import { tracked } from '@glimmer/tracking';
|
|
import { action, get } from '@ember/object';
|
|
import { schedule } from '@ember/runloop';
|
|
import { runInDebug } from '@ember/debug';
|
|
|
|
/**
|
|
* Utility function to set, but actually replace if we should replace
|
|
* then call a function on the thing to be replaced (usually a clean up function)
|
|
*
|
|
* @param obj - target object with the property to replace
|
|
* @param prop {string} - property to replace on the target object
|
|
* @param value - value to use for replacement
|
|
* @param destroy {(prev: any, value: any) => any} - teardown function
|
|
*/
|
|
const replace = function (
|
|
obj,
|
|
prop,
|
|
value,
|
|
destroy = (prev = null, value) => (typeof prev === 'function' ? prev() : null)
|
|
) {
|
|
const prev = obj[prop];
|
|
if (prev !== value) {
|
|
destroy(prev, value);
|
|
}
|
|
return (obj[prop] = value);
|
|
};
|
|
|
|
const noop = () => {};
|
|
const optional = (op) => (typeof op === 'function' ? op : noop);
|
|
|
|
// possible values for @loading=""
|
|
const LOADING = ['eager', 'lazy'];
|
|
|
|
export default class DataSource extends Component {
|
|
@service('data-source/service') dataSource;
|
|
@service('dom') dom;
|
|
@service('logger') logger;
|
|
|
|
@tracked isIntersecting = false;
|
|
@tracked data;
|
|
@tracked error;
|
|
|
|
constructor(owner, args) {
|
|
super(...arguments);
|
|
this._listeners = this.dom.listeners();
|
|
this._lazyListeners = this.dom.listeners();
|
|
}
|
|
|
|
get loading() {
|
|
return LOADING.includes(this.args.loading) ? this.args.loading : LOADING[0];
|
|
}
|
|
|
|
get disabled() {
|
|
return typeof this.args.disabled !== 'undefined' ? this.args.disabled : false;
|
|
}
|
|
|
|
onchange(e) {
|
|
this.error = undefined;
|
|
this.data = e.data;
|
|
optional(this.args.onchange)(e);
|
|
}
|
|
|
|
onerror(e) {
|
|
this.error = e.error || e;
|
|
optional(this.args.onerror)(e);
|
|
}
|
|
|
|
@action
|
|
connect($el) {
|
|
// $el is only a DOM node when loading = lazy
|
|
// otherwise its an array from the did-insert-helper
|
|
if (!Array.isArray($el)) {
|
|
this._lazyListeners.add(
|
|
this.dom.isInViewport($el, (inViewport) => {
|
|
this.isIntersecting = inViewport;
|
|
if (!this.isIntersecting) {
|
|
this.close();
|
|
} else {
|
|
this.open();
|
|
}
|
|
})
|
|
);
|
|
} else {
|
|
this._lazyListeners.remove();
|
|
this.open();
|
|
}
|
|
}
|
|
|
|
@action
|
|
disconnect() {
|
|
// TODO: Should we be doing this here? Fairly sure we should be so if this
|
|
// TODO gets old enough (6 months/ 1 year or so) feel free to remove
|
|
if (
|
|
typeof this.data !== 'undefined' &&
|
|
typeof this.data.length === 'undefined' &&
|
|
typeof this.data.rollbackAttributes === 'function'
|
|
) {
|
|
this.data.rollbackAttributes();
|
|
}
|
|
this.close();
|
|
this._listeners.remove();
|
|
this._lazyListeners.remove();
|
|
}
|
|
|
|
@action
|
|
attributeChanged([name, value]) {
|
|
switch (name) {
|
|
case 'src':
|
|
if (this.loading === 'eager' || this.isIntersecting) {
|
|
this.open();
|
|
}
|
|
break;
|
|
}
|
|
}
|
|
|
|
// keep this argumentless
|
|
@action
|
|
open() {
|
|
const src = this.args.src;
|
|
// get a new source and replace the old one, cleaning up as we go
|
|
const source = replace(
|
|
this,
|
|
'source',
|
|
this.dataSource.open(src, this, this.open),
|
|
(prev, source) => {
|
|
// Makes sure any previous source (if different) is ALWAYS closed
|
|
this.dataSource.close(prev, this);
|
|
}
|
|
);
|
|
const error = (err) => {
|
|
try {
|
|
const error = get(err, 'error.errors.firstObject') || {};
|
|
if (get(error, 'status') !== '429') {
|
|
this.onerror(err);
|
|
}
|
|
this.logger.execute(err);
|
|
} catch (err) {
|
|
this.logger.execute(err);
|
|
}
|
|
};
|
|
// set up the listeners (which auto cleanup on component destruction)
|
|
const remove = this._listeners.add(this.source, {
|
|
message: (e) => {
|
|
try {
|
|
this.onchange(e);
|
|
} catch (err) {
|
|
error(err);
|
|
}
|
|
},
|
|
error: (e) => {
|
|
error(e);
|
|
},
|
|
});
|
|
replace(this, '_remove', remove);
|
|
// dispatch the current data of the source if we have any
|
|
if (typeof source.getCurrentEvent === 'function') {
|
|
const currentEvent = source.getCurrentEvent();
|
|
if (currentEvent) {
|
|
let method;
|
|
if (typeof currentEvent.error !== 'undefined') {
|
|
method = 'onerror';
|
|
this.error = currentEvent.error;
|
|
} else {
|
|
this.error = undefined;
|
|
this.data = currentEvent.data;
|
|
method = 'onchange';
|
|
}
|
|
|
|
// avoid the re-render error
|
|
schedule('afterRender', () => {
|
|
try {
|
|
this[method](currentEvent);
|
|
} catch (err) {
|
|
error(err);
|
|
}
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
@action
|
|
async invalidate() {
|
|
this.source.readyState = 2;
|
|
this.disconnect();
|
|
schedule('afterRender', () => {
|
|
// TODO: Support lazy data-sources by keeping a reference to $el
|
|
runInDebug((_) =>
|
|
console.debug(
|
|
`Invalidation is only supported for non-lazy data sources. If you want to use this you should fixup support for lazy data sources`
|
|
)
|
|
);
|
|
this.connect([]);
|
|
});
|
|
}
|
|
|
|
// keep this argumentless
|
|
@action
|
|
close() {
|
|
if (typeof this.source !== 'undefined') {
|
|
this.dataSource.close(this.source, this);
|
|
replace(this, '_remove', undefined);
|
|
this.source = undefined;
|
|
}
|
|
}
|
|
}
|