mirror of
https://github.com/status-im/consul.git
synced 2025-01-09 21:35:52 +00:00
b16a6fa033
This PR mainly adds partition to our HTTP adapter. Additionally and perhaps most importantly, we've also taken the opportunity to move our 'conditional namespaces' deeper into the app. The reason for doing this was, we like that namespaces should be thought of as required instead of conditional, 'special' things and would like the same thinking to be applied to partitions. Now, instead of using code throughout the app throughout the adapters to add/remove namespaces or partitions depending on whether they are enabled or not. As a UI engineer you just pretend that namespaces and partitions are always enabled, and we remove them for you deeper in the app, out of the way of you forgetting to treat these properties as a special case. Notes: Added a PartitionAbility while we were there (not used as yet) Started to remove the CONSTANT variables we had just for property names. I prefer that our adapters are as readable and straightforwards as possible, it just looks like HTTP. We'll probably remove our formatDatacenter method we use also at some point, it was mainly too make it look the same as our previous formatNspace, but now we don't have that, it instead now looks different! We enable parsing of partition in the UIs URL, but this is feature flagged so still does nothing just yet. All of the test changes were related to the fact that we were treating client.url as a function rather than a method, and now that we reference this in client.url (etc) it needs binding to client.
58 lines
1.8 KiB
Gherkin
58 lines
1.8 KiB
Gherkin
@setupApplicationTest
|
|
Feature: dc / acls / tokens / update: ACL Token Update
|
|
Background:
|
|
Given 1 datacenter model with the value "datacenter"
|
|
And 1 token model from yaml
|
|
---
|
|
AccessorID: key
|
|
Policies: ~
|
|
---
|
|
When I visit the token page for yaml
|
|
---
|
|
dc: datacenter
|
|
token: key
|
|
---
|
|
Then the url should be /datacenter/acls/tokens/key
|
|
And the title should be "Edit Token - Consul"
|
|
Scenario: Update to [Name]
|
|
Then I fill in with yaml
|
|
---
|
|
Description: [Description]
|
|
---
|
|
And I submit
|
|
Then a PUT request was made to "/v1/acl/token/key?dc=datacenter&ns=@!namespace" from yaml
|
|
---
|
|
body:
|
|
Description: [Description]
|
|
---
|
|
Then the url should be /datacenter/acls/tokens
|
|
And "[data-notification]" has the "notification-update" class
|
|
And "[data-notification]" has the "success" class
|
|
Where:
|
|
---------------------------
|
|
| Description |
|
|
| description |
|
|
| description with spaces |
|
|
---------------------------
|
|
Scenario: There was an error saving the key
|
|
Given the url "/v1/acl/token/key" responds with a 500 status
|
|
And I submit
|
|
Then the url should be /datacenter/acls/tokens/key
|
|
Then "[data-notification]" has the "notification-update" class
|
|
And "[data-notification]" has the "error" class
|
|
|
|
@notNamespaceable
|
|
Scenario: Updating a simple ACL token when Namespaces are disabled does not send Namespace
|
|
Then I fill in with yaml
|
|
---
|
|
Description: Description
|
|
---
|
|
And I submit
|
|
Then a PUT request was made to "/v1/acl/token/key?dc=datacenter" without properties from yaml
|
|
---
|
|
- Namespace
|
|
---
|
|
Then the url should be /datacenter/acls/tokens
|
|
And "[data-notification]" has the "notification-update" class
|
|
And "[data-notification]" has the "success" class
|