Michael Klein 03a1a86dfe
ui: chore - upgrade ember and friends (#14518)
* v3.20.2...v3.24.0

* Fix handle undefined outlet in route component

* Don't use template helper for optional modal.open

Using the optional-helper here will trigger a computation
in the same runloop error. This is because we are setting
the `modal`-property when the `<Ref>` component gets
rendered which will update the `this.modal`-property which
will then recompute the `optional`-helper leading to this
error.

Instead we will create an action that will call the `open`-method
on the modal when it is defined. This gets rid of the double
computation error as we will not access the modal property
twice in the same runloop when `modal` is getting set.

* Fix - fn needs to be passed function tab-nav

We create functions in the component file instead
so that fn-helper stops complaining about the
need to pass a function.

* Update ember-exam to 6.1 version

"Makes it compatible" with ember-qunit v5

* scheduleOnce setMaxHeight paged-collection

We need to schedule to get around double-computation error.

* Fix - model.data is removed from ember-data

This has been private API all along - we need to
work around the removal.

Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310

* Fix `propContains` instead of `deepEqual` policy

Recent model.data works differently than iterating attributes.
We use `propContains` instead of `deepEqual`. We are only
interested in the properties we assert against and match
the previous behavior with this change.

* Fix `propContains` instead of `deepEqual` token

* Better handling single-records repo test-helper

`model.data` has been removed we need to handle proxies and
model instances differently.

* Fix remaining repository tests with propContains

We don't want to match entire objects - we don't care
about properties we haven't defined in the assertion.

* Don't use template helper for optional modal.open

Using a template helper will give us a recomputation error -
we work around it by creating an explicit action on
the component instead.

* Await `I $verb the $pageObject object` step

* Fix no more customization ember-can

No need to customize, the helper handles destruction
fine on its own.

* Fix - don't pass `optional` functions to fn

We will declare the functions on the component instead.
This gives us the same behavior but no error from
`fn`, which expects a function to be passed.

* Fix - handle `undefined` state on validate modifier

StateChart can yield out an undefined `state` we need
to handle that in the validate modifier

* Fix linting errors tests directory

* Warn / turn off new ember linting issues

We will tackle them one by one and don't want to
autofix issues that could be dangerous to auto-fix.

* Auto-fix linting issues

* More linting configuration

* Fix remaining linting issues

* Fix linting issues new files after rebase

* ui: Remove ember-cli-uglify config now we are using terser (#14574)

Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
2022-09-15 09:43:17 +01:00

158 lines
5.3 KiB
JavaScript

import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
import { env } from '../../../env';
const shouldHaveNspace = function (nspace) {
return typeof nspace !== 'undefined' && env('CONSUL_NSPACES_ENABLED');
};
module('Integration | Adapter | kv', function (hooks) {
setupTest(hooks);
const dc = 'dc-1';
const id = 'key-name/here';
const undefinedNspace = 'default';
[undefinedNspace, 'team-1', undefined].forEach((nspace) => {
test(`requestForQuery returns the correct url/method when nspace is ${nspace}`, async function (assert) {
const adapter = this.owner.lookup('adapter:kv');
const client = this.owner.lookup('service:client/http');
const request = function () {
return () => client.requestParams.bind(client)(...arguments);
};
const expected = `GET /v1/kv/${id}?keys&dc=${dc}${
shouldHaveNspace(nspace) ? `&ns=${nspace}` : ``
}`;
let actual = await adapter.requestForQuery(request, {
dc: dc,
id: id,
ns: nspace,
});
actual = actual();
assert.equal(`${actual.method} ${actual.url}`, expected);
});
test(`requestForQueryRecord returns the correct url/method when nspace is ${nspace}`, async function (assert) {
const adapter = this.owner.lookup('adapter:kv');
const client = this.owner.lookup('service:client/http');
const request = function () {
return () => client.requestParams.bind(client)(...arguments);
};
const expected = `GET /v1/kv/${id}?dc=${dc}${
shouldHaveNspace(nspace) ? `&ns=${nspace}` : ``
}`;
let actual = await adapter.requestForQueryRecord(request, {
dc: dc,
id: id,
ns: nspace,
});
actual = actual();
assert.equal(`${actual.method} ${actual.url}`, expected);
});
test(`requestForCreateRecord returns the correct url/method when nspace is ${nspace}`, function (assert) {
const adapter = this.owner.lookup('adapter:kv');
const client = this.owner.lookup('service:client/http');
const request = client.url.bind(client);
const expected = `PUT /v1/kv/${id}?dc=${dc}${
shouldHaveNspace(nspace) ? `&ns=${nspace}` : ``
}`;
let actual = adapter
.requestForCreateRecord(
request,
{},
{
Datacenter: dc,
Key: id,
Value: '',
Namespace: nspace,
}
)
.split('\n')
.shift();
assert.equal(actual, expected);
});
test(`requestForUpdateRecord returns the correct url/method when nspace is ${nspace}`, function (assert) {
const adapter = this.owner.lookup('adapter:kv');
const client = this.owner.lookup('service:client/http');
const request = client.url.bind(client);
const flags = 12;
const expected = `PUT /v1/kv/${id}?dc=${dc}${
shouldHaveNspace(nspace) ? `&ns=${nspace}` : ``
}&flags=${flags}`;
let actual = adapter
.requestForUpdateRecord(
request,
{},
{
Datacenter: dc,
Key: id,
Value: '',
Namespace: nspace,
Flags: flags,
}
)
.split('\n')
.shift();
assert.equal(actual, expected);
});
test(`requestForDeleteRecord returns the correct url/method when the nspace is ${nspace}`, function (assert) {
const adapter = this.owner.lookup('adapter:kv');
const client = this.owner.lookup('service:client/http');
const request = client.url.bind(client);
const expected = `DELETE /v1/kv/${id}?dc=${dc}${
shouldHaveNspace(nspace) ? `&ns=${nspace}` : ``
}`;
let actual = adapter
.requestForDeleteRecord(
request,
{},
{
Datacenter: dc,
Key: id,
Namespace: nspace,
}
)
.split('\n')
.shift();
assert.equal(actual, expected);
});
test(`requestForDeleteRecord returns the correct url/method for folders when nspace is ${nspace}`, function (assert) {
const adapter = this.owner.lookup('adapter:kv');
const client = this.owner.lookup('service:client/http');
const request = client.url.bind(client);
const folder = `${id}/`;
const expected = `DELETE /v1/kv/${folder}?dc=${dc}${
shouldHaveNspace(nspace) ? `&ns=${nspace}` : ``
}&recurse`;
let actual = adapter
.requestForDeleteRecord(
request,
{},
{
Datacenter: dc,
Key: folder,
Namespace: nspace,
}
)
.split('\n')
.shift();
assert.equal(actual, expected);
});
});
test("requestForQuery throws if you don't specify an id", function (assert) {
const adapter = this.owner.lookup('adapter:kv');
const client = this.owner.lookup('service:client/http');
const request = client.url.bind(client);
assert.rejects(
adapter.requestForQuery(request, {
dc: dc,
})
);
});
test("requestForQueryRecord throws if you don't specify an id", function (assert) {
const adapter = this.owner.lookup('adapter:kv');
const client = this.owner.lookup('service:client/http');
const request = client.url.bind(client);
assert.rejects(
adapter.requestForQueryRecord(request, {
dc: dc,
})
);
});
});