mirror of https://github.com/status-im/consul.git
8b365f8271
This test is super racy (it's not just a single line).
This test also starts failing once streaming is enabled, because the
cache rate limit no longer applies to the requests in the test. The
queries use streaming instead of the cache.
This test is no longer valid, and the functionality is already well
tested by TestCacheThrottle. Instead of spending time rewriting this
test, let's remove it.
```
WARNING: DATA RACE
Read at 0x00c01de410fc by goroutine 735:
github.com/hashicorp/consul/agent.TestCacheRateLimit.func1()
/home/daniel/pers/code/consul/agent/agent_test.go:1024 +0x9af
github.com/hashicorp/consul/testrpc.WaitForTestAgent()
/home/daniel/pers/code/consul/testrpc/wait.go:99 +0x209
github.com/hashicorp/consul/agent.TestCacheRateLimit.func1()
/home/daniel/pers/code/consul/agent/agent_test.go:966 +0x1ad
testing.tRunner()
/usr/lib/go/src/testing/testing.go:1193 +0x202
Previous write at 0x00c01de410fc by goroutine 605:
github.com/hashicorp/consul/agent.TestCacheRateLimit.func1.2()
/home/daniel/pers/code/consul/agent/agent_test.go:998 +0xe9
Goroutine 735 (running) created at:
testing.(*T).Run()
/usr/lib/go/src/testing/testing.go:1238 +0x5d7
github.com/hashicorp/consul/agent.TestCacheRateLimit()
/home/daniel/pers/code/consul/agent/agent_test.go:961 +0x375
testing.tRunner()
/usr/lib/go/src/testing/testing.go:1193 +0x202
Goroutine 605 (finished) created at:
github.com/hashicorp/consul/agent.TestCacheRateLimit.func1()
/home/daniel/pers/code/consul/agent/agent_test.go:1022 +0x91e
github.com/hashicorp/consul/testrpc.WaitForTestAgent()
/home/daniel/pers/code/consul/testrpc/wait.go:99 +0x209
github.com/hashicorp/consul/agent.TestCacheRateLimit.func1()
/home/daniel/pers/code/consul/agent/agent_test.go:966 +0x1ad
testing.tRunner()
/usr/lib/go/src/testing/testing.go:1193 +0x202
```
|
||
|---|---|---|
| .. | ||
| ae | ||
| auto-config | ||
| cache | ||
| cache-types | ||
| checks | ||
| config | ||
| connect | ||
| consul | ||
| debug | ||
| dns | ||
| exec | ||
| grpc | ||
| local | ||
| metadata | ||
| mock | ||
| pool | ||
| proxycfg | ||
| router | ||
| routine-leak-checker | ||
| rpc/subscribe | ||
| rpcclient/health | ||
| structs | ||
| submatview | ||
| systemd | ||
| token | ||
| uiserver | ||
| xds | ||
| acl.go | ||
| acl_endpoint.go | ||
| acl_endpoint_legacy.go | ||
| acl_endpoint_legacy_test.go | ||
| acl_endpoint_test.go | ||
| acl_test.go | ||
| agent.go | ||
| agent_endpoint.go | ||
| agent_endpoint_test.go | ||
| agent_oss.go | ||
| agent_test.go | ||
| apiserver.go | ||
| apiserver_test.go | ||
| catalog_endpoint.go | ||
| catalog_endpoint_test.go | ||
| check.go | ||
| config_endpoint.go | ||
| config_endpoint_test.go | ||
| connect_auth.go | ||
| connect_ca_endpoint.go | ||
| connect_ca_endpoint_test.go | ||
| coordinate_endpoint.go | ||
| coordinate_endpoint_test.go | ||
| denylist.go | ||
| denylist_test.go | ||
| discovery_chain_endpoint.go | ||
| discovery_chain_endpoint_test.go | ||
| dns.go | ||
| dns_oss.go | ||
| dns_test.go | ||
| enterprise_delegate_oss.go | ||
| event_endpoint.go | ||
| event_endpoint_test.go | ||
| federation_state_endpoint.go | ||
| health_endpoint.go | ||
| health_endpoint_test.go | ||
| http.go | ||
| http_decode_test.go | ||
| http_oss.go | ||
| http_oss_test.go | ||
| http_register.go | ||
| http_test.go | ||
| intentions_endpoint.go | ||
| intentions_endpoint_oss_test.go | ||
| intentions_endpoint_test.go | ||
| keyring.go | ||
| keyring_test.go | ||
| kvs_endpoint.go | ||
| kvs_endpoint_test.go | ||
| nodeid.go | ||
| nodeid_test.go | ||
| notify.go | ||
| notify_test.go | ||
| operator_endpoint.go | ||
| operator_endpoint_oss.go | ||
| operator_endpoint_test.go | ||
| prepared_query_endpoint.go | ||
| prepared_query_endpoint_test.go | ||
| reload.go | ||
| remote_exec.go | ||
| remote_exec_test.go | ||
| retry_join.go | ||
| retry_join_test.go | ||
| service_checks_test.go | ||
| service_manager.go | ||
| service_manager_test.go | ||
| session_endpoint.go | ||
| session_endpoint_test.go | ||
| setup.go | ||
| setup_oss.go | ||
| sidecar_service.go | ||
| sidecar_service_test.go | ||
| signal_unix.go | ||
| signal_windows.go | ||
| snapshot_endpoint.go | ||
| snapshot_endpoint_test.go | ||
| status_endpoint.go | ||
| status_endpoint_test.go | ||
| streaming_test.go | ||
| testagent.go | ||
| testagent_test.go | ||
| translate_addr.go | ||
| txn_endpoint.go | ||
| txn_endpoint_test.go | ||
| ui_endpoint.go | ||
| ui_endpoint_oss_test.go | ||
| ui_endpoint_test.go | ||
| user_event.go | ||
| user_event_test.go | ||
| util.go | ||
| util_test.go | ||
| watch_handler.go | ||
| watch_handler_test.go | ||