mirror of
https://github.com/status-im/consul.git
synced 2025-01-22 19:50:36 +00:00
40e71f1b91
* Move notification texts to a slightly different layer (#4572) * Further Simplify/refactor the actions/notification layer (#4573) 1. Move the 'with-feedback' actions to a 'with-blocking-action' mixin which better describes what it does 2. Additional set of unit tests almost over the entire layer to prove things work/add confidence for further changes The multiple 'with-action' mixins used for every 'index/edit' combo are now reduced down to only contain the functionality related to their specific routes, i.e. where to redirect. The actual functionality to block and carry out the action and then notify are 'almost' split out so that their respective classes/objects do one thing and one thing 'well'. Mixins are chosen for the moment as the decoration approach used by mixins feels better than multiple levels of inheritence, but I would like to take this fuether in the future to a 'compositional' based approach. There is still possible further work to be done here, but I'm a lot happier now this is reduced down into separate parts.
42 lines
1.4 KiB
Gherkin
42 lines
1.4 KiB
Gherkin
@setupApplicationTest
|
|
Feature: dc / intentions / update: Intention Update
|
|
Background:
|
|
Given 1 datacenter model with the value "datacenter"
|
|
And 1 intention model from yaml
|
|
---
|
|
ID: intention-id
|
|
---
|
|
When I visit the intention page for yaml
|
|
---
|
|
dc: datacenter
|
|
intention: intention-id
|
|
---
|
|
Then the url should be /datacenter/intentions/intention-id
|
|
Scenario: Update to [Description], [Action], [Rules]
|
|
Then I fill in with yaml
|
|
---
|
|
Description: [Name]
|
|
---
|
|
And I click "[value=[Action]]"
|
|
And I submit
|
|
Then a PUT request is made to "/v1/connect/intentions/intention-id?dc=datacenter" with the body from yaml
|
|
---
|
|
Description: [Name]
|
|
Action: [Action]
|
|
---
|
|
Then the url should be /datacenter/intentions
|
|
And "[data-notification]" has the "notification-update" class
|
|
And "[data-notification]" has the "success" class
|
|
Where:
|
|
------------------------------
|
|
| Description | Action |
|
|
| Desc | allow |
|
|
------------------------------
|
|
Scenario: There was an error saving the intention
|
|
Given the url "/v1/connect/intentions/intention-id" responds with a 500 status
|
|
And I submit
|
|
Then the url should be /datacenter/intentions/intention-id
|
|
Then "[data-notification]" has the "notification-update" class
|
|
And "[data-notification]" has the "error" class
|
|
|