mirror of https://github.com/status-im/consul.git
92f0eb3bdc
We've always had this idea of being able to markup up information
semantically without thinking about what it should look like, then
applying our %h* placeholder styles to control what the information
should look like.
Back when we originally made our set of %h* placeholders, we tried to
follow Structure as much as possible, which defined the largest header
(which we thought would have been the h1 style) as a super large 3.5rem.
Therefore we made our set of %h* placeholders the same as Structure
beginning at a huge 3.5 size. We then re-overwrote those sizes only in
Consul specific CSS files thinking that this was due to us existing
before Structure did.
Lately we saw an extra clue in Structure - the extra large 3.5 header was
called 'h0'.
This commit moves all our headers to use a zero based scale, and
additionally uses our 3 digit scale as opposed to 1 digit (h1 vs h100),
similar to our color scales (note we don't use a hypen, which we can
alter later if need be), which means we can insert additional h150 etc
if need be.
Additional we stop styling our headers globally (h1 { @extend %h100; }
). This means there is no reason not to use headers for marking up
content depending on what it is rather than what it should look like,
and as a consequence means we can be more purposeful in ordering h*
tags.
Lastly, we use the new scale over the entire codebase and update a
couple of places where we were using using header tags due to what the
styleing for them looked like rather than what the meaning/order was.
|
||
|---|---|---|
| .. | ||
| app-view | ||
| auth-form | ||
| auth-modal | ||
| brand-loader | ||
| card | ||
| code-editor | ||
| composite-row | ||
| confirmation-dialog | ||
| definition-table | ||
| dom-recycling-table | ||
| empty-state | ||
| expanded-single-select | ||
| flash-message | ||
| footer | ||
| icon-definition | ||
| list-row | ||
| loader | ||
| oidc-select | ||
| progress | ||
| radio-card | ||
| secret-button | ||
| tabular-details | ||
| tag-list | ||
| tooltip-panel | ||
| anchors.scss | ||
| app-view.scss | ||
| auth-form.scss | ||
| auth-modal.scss | ||
| brand-loader.scss | ||
| breadcrumbs.scss | ||
| buttons.scss | ||
| code-editor.scss | ||
| composite-row.scss | ||
| confirmation-dialog.scss | ||
| definition-table.scss | ||
| empty-state.scss | ||
| flash-message.scss | ||
| footer.scss | ||
| form-elements.scss | ||
| icon-definition.scss | ||
| list-collection.scss | ||
| loader.scss | ||
| menu-panel.scss | ||
| more-popover-menu.scss | ||
| oidc-select.scss | ||
| pill.scss | ||
| popover-select.scss | ||
| progress.scss | ||
| radio-card.scss | ||
| secret-button.scss | ||
| table.scss | ||
| tabular-collection.scss | ||
| tabular-details.scss | ||
| tag-list.scss | ||
| tooltip-panel.scss | ||