consul/agent/connect/ca
Dhia Ayachi 543928d707 Format certificates properly (rfc7468) with a trailing new line (#10411)
* trim carriage return from certificates when inserting rootCA in the inMemDB

* format rootCA properly when returning the CA on the connect CA endpoint

* Fix linter warnings

* Fix providers to trim certs before returning it

* trim newlines on write when possible

* add changelog

* make sure all provider return a trailing newline after the root and intermediate certs

* Fix endpoint to return trailing new line

* Fix failing test with vault provider

* make test more robust

* make sure all provider return a trailing newline after the leaf certs

* Check for suffix before removing newline and use function

* Add comment to consul provider

* Update change log

Co-authored-by: R.B. Boyer <4903+rboyer@users.noreply.github.com>

* fix typo

* simplify code callflow

Co-authored-by: R.B. Boyer <4903+rboyer@users.noreply.github.com>

* extract requireNewLine as shared func

* remove dependency to testify in testing file

* remove extra newline in vault provider

* Add cert newline fix to envoy xds

* remove new line from mock provider

* Remove adding a new line from provider and fix it when the cert is read

* Add a comment to explain the fix

* Add missing for leaf certs

* fix missing new line

* fix missing new line in leaf certs

* remove extra new line in test

* updage changelog

Co-authored-by: Daniel Nephin <dnephin@hashicorp.com>

* fix in vault provider and when reading cache (RPC call)

* fix AWS provider

* fix failing test in the provider

* remove comments and empty lines

* add check for empty cert in test

* fix linter warnings

* add new line for leaf and private key

* use string concat instead of Sprintf

* fix new lines for leaf signing

* preallocate slice and remove append

* Add new line to `SignIntermediate` and `CrossSignCA`

Co-authored-by: R.B. Boyer <4903+rboyer@users.noreply.github.com>
Co-authored-by: Daniel Nephin <dnephin@hashicorp.com>
2021-07-01 00:49:03 +00:00
..
common.go Format certificates properly (rfc7468) with a trailing new line (#10411) 2021-07-01 00:49:03 +00:00
mock_Provider.go Ensure that CA initialization does not block leader election. 2021-01-19 15:27:48 -05:00
provider.go Ensure that CA initialization does not block leader election. 2021-01-19 15:27:48 -05:00
provider_aws.go Ensure that CA initialization does not block leader election. 2021-01-19 15:27:48 -05:00
provider_aws_test.go Format certificates properly (rfc7468) with a trailing new line (#10411) 2021-07-01 00:49:03 +00:00
provider_consul.go Ensure that CA initialization does not block leader election. 2021-01-19 15:27:48 -05:00
provider_consul_config.go Move IntermediateCertTTL to common CA config 2020-09-10 00:23:22 -07:00
provider_consul_test.go Format certificates properly (rfc7468) with a trailing new line (#10411) 2021-07-01 00:49:03 +00:00
provider_test.go Move IntermediateCertTTL to common CA config 2020-09-10 00:23:22 -07:00
provider_vault.go Format certificates properly (rfc7468) with a trailing new line (#10411) 2021-07-01 00:49:03 +00:00
provider_vault_test.go Format certificates properly (rfc7468) with a trailing new line (#10411) 2021-07-01 00:49:03 +00:00
testing.go Format certificates properly (rfc7468) with a trailing new line (#10411) 2021-07-01 00:49:03 +00:00