Dan Upton 73b9b407ba

grpc: fix data race in balancer registration (#16229) ...

Registering gRPC balancers is thread-unsafe because they are stored in a
global map variable that is accessed without holding a lock. Therefore,
it's expected that balancers are registered _once_ at the beginning of
your program (e.g. in a package `init` function) and certainly not after
you've started dialing connections, etc.

> NOTE: this function must only be called during initialization time
> (i.e. in an init() function), and is not thread-safe.

While this is fine for us in production, it's challenging for tests that
spin up multiple agents in-memory. We currently register a balancer per-
agent which holds agent-specific state that cannot safely be shared.

This commit introduces our own registry that _is_ thread-safe, and
implements the Builder interface such that we can call gRPC's `Register`
method once, on start-up. It uses the same pattern as our resolver
registry where we use the dial target's host (aka "authority"), which is
unique per-agent, to determine which builder to use.

2023-02-28 10:18:38 +00:00

..

ae

sdk: add TestLogLevel for setting log level in tests

2022-02-03 13:42:28 -05:00

auto-config

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

cache

xds: don't attempt to load-balance sessions for local proxies (#15789)

2023-01-18 12:33:21 -06:00

cache-types

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

checks

Fix TLS_BadVerify test assertions on macOS (#15903)

2023-01-05 11:47:45 -06:00

config

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

configentry

[OSS] Add Peer field to service-defaults upstream overrides (#15956)

2023-02-03 10:51:53 -05:00

connect

[API Gateway] Add integration test for HTTP routes (#16236)

2023-02-13 14:18:05 -05:00

consul

grpc: fix data race in balancer registration (#16229)

2023-02-28 10:18:38 +00:00

debug

…

dns

test: fix incorrect use of t instead of r in retry test (#13146)

2022-05-19 14:00:07 -05:00

envoyextensions

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

exec

…

grpc-external

Fix various flaky tests (#16396)

2023-02-23 14:52:18 -05:00

grpc-internal

grpc: fix data race in balancer registration (#16229)

2023-02-28 10:18:38 +00:00

grpc-middleware

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

hcp

xds: don't attempt to load-balance sessions for local proxies (#15789)

2023-01-18 12:33:21 -06:00

local

Use agent token for service/check deregistration during anti-entropy (#16097)

2023-02-03 08:45:11 -06:00

log-drop

inject logger and create logdrop sink (#15822)

2023-01-06 11:33:53 -07:00

metadata

Change serf-tag references to field references.

2022-08-31 16:38:42 -05:00

metrics

emit metrics for global rate limiting (#15891)

2023-01-06 17:49:33 -06:00

mock

…

pool

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

proxycfg

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

proxycfg-glue

Fix issue with peer services incorrectly appearing as connect-enabled. (#16339)

2023-02-21 13:59:36 -06:00

proxycfg-sources

xds: don't attempt to load-balance sessions for local proxies (#15789)

2023-01-18 12:33:21 -06:00

router

Regenerate files according to 1.19.2 formatter

2022-10-24 16:12:08 -04:00

routine-leak-checker

removes ioutil usage everywhere which was deprecated in go1.16 (#15297)

2022-11-10 10:26:01 -06:00

rpc

grpc: fix data race in balancer registration (#16229)

2023-02-28 10:18:38 +00:00

rpcclient/health

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

structs

[API Gateway] Fix infinite loop in controller and binding non-accepted routes and gateways (#16377)

2023-02-22 14:55:40 -05:00

submatview

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

systemd

…

token

Add new config_file_service_registration token (#15828)

2023-01-10 10:24:02 -06:00

uiserver

removes ioutil usage everywhere which was deprecated in go1.16 (#15297)

2022-11-10 10:26:01 -06:00

xds

Fix attempt for test fail panics in xDS (#16319)

2023-02-24 17:00:31 -05:00

acl_endpoint_test.go

ACL error improvements: incomplete bootstrapping and non-existent token (#16105)

2023-02-08 23:49:44 +00:00

acl_endpoint.go

ACL error improvements: incomplete bootstrapping and non-existent token (#16105)

2023-02-08 23:49:44 +00:00

acl_oss.go

…

acl_test.go

revert method name change in xds server protocol for version compatibility (#16195)

2023-02-07 14:19:09 -06:00

acl.go

Output user-friendly name for anonymous token (#15884)

2023-01-09 12:28:53 -06:00

agent_endpoint_oss_test.go

Add oss test

2022-05-09 10:07:19 -07:00

agent_endpoint_oss.go

Apply agent partition to load services and agent api (#16024)

2023-01-20 12:59:26 -05:00

agent_endpoint_test.go

Update token language to distinguish Accessor and Secret ID usage (#16044)

2023-02-07 12:26:30 -06:00

agent_endpoint.go

refactor: remove troubleshoot module dependency on consul top level module (#16162)

2023-02-06 09:14:35 -08:00

agent_oss.go

proxycfg: replace direct agent cache usage with interfaces (#13320)

2022-06-01 16:18:06 +01:00

agent_test.go

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

agent.go

grpc: fix data race in balancer registration (#16229)

2023-02-28 10:18:38 +00:00

apiserver_test.go

…

apiserver.go

…

catalog_endpoint_oss.go

…

catalog_endpoint_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

catalog_endpoint.go

Add the operator usage instances command and api endpoint (#16205)

2023-02-08 12:07:21 -08:00

check.go

Fixup acl.EnterpriseMeta

2022-04-05 15:11:49 -07:00

config_endpoint_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

config_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

connect_auth.go

Unify various status errors into one HTTP error type. (#12594)

2022-04-29 13:42:49 -04:00

connect_ca_endpoint_test.go

removes ioutil usage everywhere which was deprecated in go1.16 (#15297)

2022-11-10 10:26:01 -06:00

connect_ca_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

coordinate_endpoint_test.go

[OSS] security: update go to 1.20.1 (#16263)

2023-02-17 15:04:12 -05:00

coordinate_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

delegate_mock_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

denylist_test.go

…

denylist.go

…

discovery_chain_endpoint_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

discovery_chain_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

dns_oss_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

dns_oss.go

Add peering .service and .node DNS lookups. (#15596)

2022-11-29 12:23:18 -06:00

dns_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

dns.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

enterprise_delegate_oss.go

…

event_endpoint_test.go

Warn when the token query param is used for auth (#16009)

2023-01-24 16:21:41 +00:00

event_endpoint.go

Revert getPathSuffixUnescaped (#13256)

2022-06-01 13:17:14 -04:00

federation_state_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

health_endpoint_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

health_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

http_decode_test.go

Regenerate files according to 1.19.2 formatter

2022-10-24 16:12:08 -04:00

http_oss_test.go

…

http_oss.go

Unify various status errors into one HTTP error type. (#12594)

2022-04-29 13:42:49 -04:00

http_register.go

Add the operator usage instances command and api endpoint (#16205)

2023-02-08 12:07:21 -08:00

http_test.go

fix: add tls config to unix socket when https is used (#16301)

2023-02-21 08:28:13 -05:00

http.go

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

intentions_endpoint_oss_test.go

…

intentions_endpoint_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

intentions_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

keyring_test.go

removes ioutil usage everywhere which was deprecated in go1.16 (#15297)

2022-11-10 10:26:01 -06:00

keyring.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

kvs_endpoint_test.go

…

kvs_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

metrics_test.go

Correct WAL metrics registrations (#16388)

2023-02-23 14:07:17 +00:00

metrics.go

…

nodeid_test.go

removes ioutil usage everywhere which was deprecated in go1.16 (#15297)

2022-11-10 10:26:01 -06:00

nodeid.go

removes ioutil usage everywhere which was deprecated in go1.16 (#15297)

2022-11-10 10:26:01 -06:00

notify_test.go

…

notify.go

…

operator_endpoint_oss_test.go

Add the operator usage instances command and api endpoint (#16205)

2023-02-08 12:07:21 -08:00

operator_endpoint_oss.go

…

operator_endpoint_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

operator_endpoint.go

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

peering_endpoint_oss_test.go

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

peering_endpoint_test.go

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

peering_endpoint.go

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

prepared_query_endpoint_test.go

[OSS] security: update go to 1.20.1 (#16263)

2023-02-17 15:04:12 -05:00

prepared_query_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

reload.go

…

remote_exec_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

remote_exec.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

retry_join_test.go

add HCP integration component (#14723)

2022-09-26 14:58:15 -04:00

retry_join.go

Deprecate -join and -join-wan (#15598)

2022-12-14 20:28:25 +00:00

service_checks_test.go

Service http checks data source for agentless proxies (#14924)

2022-10-12 07:49:56 -07:00

service_manager_test.go

[OSS] Add Peer field to service-defaults upstream overrides (#15956)

2023-02-03 10:51:53 -05:00

service_manager.go

[OSS] Add Peer field to service-defaults upstream overrides (#15956)

2023-02-03 10:51:53 -05:00

session_endpoint_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

session_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

setup_oss.go

…

setup.go

grpc: fix data race in balancer registration (#16229)

2023-02-28 10:18:38 +00:00

sidecar_service_test.go

Backport test from ENT: "Fix missing test fields" (#15258)

2022-11-04 09:29:16 -05:00

sidecar_service.go

PR #14057 follow up fix: service id parsing from sidecar id (#14541)

2022-09-09 09:47:10 -05:00

signal_unix.go

…

signal_windows.go

…

snapshot_endpoint_test.go

Warn when the token query param is used for auth (#16009)

2023-01-24 16:21:41 +00:00

snapshot_endpoint.go

…

status_endpoint_test.go

…

status_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

streaming_test.go

…

testagent_test.go

…

testagent.go

[OSS] security: update go to 1.20.1 (#16263)

2023-02-17 15:04:12 -05:00

translate_addr.go

…

txn_endpoint_test.go

[OSS] security: update go to 1.20.1 (#16263)

2023-02-17 15:04:12 -05:00

txn_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

ui_endpoint_oss_test.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

ui_endpoint_test.go

Protobuf Refactoring for Multi-Module Cleanliness (#16302)

2023-02-17 16:14:46 -05:00

ui_endpoint.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

user_event_test.go

Add new config_file_service_registration token (#15828)

2023-01-10 10:24:02 -06:00

user_event.go

Pass remote addr of incoming HTTP requests through to RPC(..) calls (#15700)

2022-12-14 09:24:22 -06:00

util_test.go

…

util.go

…

watch_handler_test.go

removes ioutil usage everywhere which was deprecated in go1.16 (#15297)

2022-11-10 10:26:01 -06:00

watch_handler.go

…