status-im/consul
2
0
Fork 0
mirror of https://github.com/status-im/consul.git synced 2025-01-09 21:35:52 +00:00
Code Issues Projects Releases Wiki Activity
consul/agent
History
Daniel Nephin 678014de1d agent: fix a data race in a test 
The test was modifying a pointer to a struct that had been passed to
another goroutine. Instead create a new struct to modify.

```
WARNING: DATA RACE
Write at 0x00c01407c3c0 by goroutine 832:
  github.com/hashicorp/consul/agent.TestServiceManager_PersistService_API()
      /home/daniel/pers/code/consul/agent/service_manager_test.go:446 +0x1d86
  testing.tRunner()
      /usr/lib/go/src/testing/testing.go:1193 +0x202

Previous read at 0x00c01407c3c0 by goroutine 938:
  reflect.typedmemmove()
      /usr/lib/go/src/runtime/mbarrier.go:177 +0x0
  reflect.Value.Set()
      /usr/lib/go/src/reflect/value.go:1569 +0x13b
  github.com/mitchellh/copystructure.(*walker).Primitive()
      /home/daniel/go/pkg/mod/github.com/mitchellh/copystructure@v1.0.0/copystructure.go:289 +0x190
  github.com/mitchellh/reflectwalk.walkPrimitive()
      /home/daniel/go/pkg/mod/github.com/mitchellh/reflectwalk@v1.0.1/reflectwalk.go:252 +0x31b
  github.com/mitchellh/reflectwalk.walk()
      /home/daniel/go/pkg/mod/github.com/mitchellh/reflectwalk@v1.0.1/reflectwalk.go:179 +0x24d
  github.com/mitchellh/reflectwalk.walkStruct()
      /home/daniel/go/pkg/mod/github.com/mitchellh/reflectwalk@v1.0.1/reflectwalk.go:386 +0x4ec
  github.com/mitchellh/reflectwalk.walk()
      /home/daniel/go/pkg/mod/github.com/mitchellh/reflectwalk@v1.0.1/reflectwalk.go:188 +0x656
  github.com/mitchellh/reflectwalk.walkStruct()
      /home/daniel/go/pkg/mod/github.com/mitchellh/reflectwalk@v1.0.1/reflectwalk.go:386 +0x4ec
  github.com/mitchellh/reflectwalk.walk()
      /home/daniel/go/pkg/mod/github.com/mitchellh/reflectwalk@v1.0.1/reflectwalk.go:188 +0x656
  github.com/mitchellh/reflectwalk.Walk()
      /home/daniel/go/pkg/mod/github.com/mitchellh/reflectwalk@v1.0.1/reflectwalk.go:92 +0x164
  github.com/mitchellh/copystructure.Config.Copy()
      /home/daniel/go/pkg/mod/github.com/mitchellh/copystructure@v1.0.0/copystructure.go:69 +0xe7
  github.com/mitchellh/copystructure.Copy()
      /home/daniel/go/pkg/mod/github.com/mitchellh/copystructure@v1.0.0/copystructure.go:13 +0x84
  github.com/hashicorp/consul/agent.mergeServiceConfig()
      /home/daniel/pers/code/consul/agent/service_manager.go:362 +0x56
  github.com/hashicorp/consul/agent.(*serviceConfigWatch).handleUpdate()
      /home/daniel/pers/code/consul/agent/service_manager.go:279 +0x250
  github.com/hashicorp/consul/agent.(*serviceConfigWatch).runWatch()
      /home/daniel/pers/code/consul/agent/service_manager.go:246 +0x2d4

Goroutine 832 (running) created at:
  testing.(*T).Run()
      /usr/lib/go/src/testing/testing.go:1238 +0x5d7
  testing.runTests.func1()
      /usr/lib/go/src/testing/testing.go:1511 +0xa6
  testing.tRunner()
      /usr/lib/go/src/testing/testing.go:1193 +0x202
  testing.runTests()
      /usr/lib/go/src/testing/testing.go:1509 +0x612
  testing.(*M).Run()
      /usr/lib/go/src/testing/testing.go:1417 +0x3b3
  main.main()
      _testmain.go:1181 +0x236

Goroutine 938 (running) created at:
  github.com/hashicorp/consul/agent.(*serviceConfigWatch).start()
      /home/daniel/pers/code/consul/agent/service_manager.go:223 +0x4e4
  github.com/hashicorp/consul/agent.(*ServiceManager).AddService()
      /home/daniel/pers/code/consul/agent/service_manager.go:98 +0x344
  github.com/hashicorp/consul/agent.(*Agent).addServiceLocked()
      /home/daniel/pers/code/consul/agent/agent.go:1942 +0x2e4
  github.com/hashicorp/consul/agent.(*Agent).AddService()
      /home/daniel/pers/code/consul/agent/agent.go:1929 +0x337
  github.com/hashicorp/consul/agent.TestServiceManager_PersistService_API()
      /home/daniel/pers/code/consul/agent/service_manager_test.go:400 +0x17c4
  testing.tRunner()
      /usr/lib/go/src/testing/testing.go:1193 +0x202

```
2021-07-14 18:58:16 -04:00
..
ae
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
auto-config
connect: include optional partition prefixes in SPIFFE identifiers (#10507)
2021-06-25 16:47:47 -05:00
cache
cache: Fix bug where connection errors can cause early cache expiry (#9979)
2021-04-08 11:11:15 +01:00
cache-types
connect: include optional partition prefixes in SPIFFE identifiers (#10507)
2021-06-25 16:47:47 -05:00
checks
create separate function with its own context to shutdown http2 client conn in h2ping check
2021-04-29 18:05:50 -04:00
config
Apply suggestions from code review
2021-07-13 12:31:49 -04:00
connect
check expiry date of the root/intermediate before using it to sign a leaf (#10500)
2021-07-13 12:15:06 -04:00
consul
consul: fix data race in leader CA tests
2021-07-14 18:58:15 -04:00
debug
chore: upgrade to gopsutil/v3 (#9118)
2020-11-06 20:48:38 -05:00
dns
config: move NodeName validation to config validation
2020-08-17 17:25:02 -04:00
exec
…
grpc
fix 64-bit aligment for 32-bit platforms
2021-06-29 16:10:21 -04:00
local
make tests use a dummy node_name to avoid environment related failures (#10262)
2021-06-01 11:58:03 -04:00
metadata
Refactor of serf feature flag tags.
2021-05-20 12:57:06 -04:00
mock
…
pool
introduce certopts (#9606)
2021-03-22 10:16:41 +01:00
proxycfg
proxycfg: remove unused method
2021-06-21 15:54:40 -04:00
router
Correcting the changed function name in comment
2021-02-06 20:23:40 -05:00
routine-leak-checker
Preparation for changing where license management is done.
2021-05-24 10:19:31 -04:00
rpc/subscribe
structs: remove EnterpriseMeta.GetNamespace
2021-03-09 15:17:26 -05:00
rpcclient/health
streaming: support X-Cache-Hit header
2021-06-28 17:29:23 -04:00
structs
Add support for returning ACL secret IDs for accessors with acl:write (#10546)
2021-07-08 15:13:08 -07:00
submatview
streaming: support X-Cache-Hit header
2021-06-28 17:29:23 -04:00
systemd
…
token
token: OSS support for enterprise tokens
2020-08-31 15:10:15 -04:00
uiserver
auto-updated agent/uiserver/bindata_assetfs.go from commit 3e80e637b
2021-07-14 18:00:42 +00:00
xds
rename GRPC->XDS where appropriate
2021-07-09 12:17:45 -04:00
acl_endpoint_legacy_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
acl_endpoint_legacy.go
api: rename HTTPServer to HTTPHandlers
2020-09-18 17:38:23 -04:00
acl_endpoint_test.go
Add support for returning ACL secret IDs for accessors with acl:write (#10546)
2021-07-08 15:13:08 -07:00
acl_endpoint.go
Move static token resolution into the ACLResolver (#10013)
2021-04-14 12:39:35 -04:00
acl_test.go
Move static token resolution into the ACLResolver (#10013)
2021-04-14 12:39:35 -04:00
acl.go
Move static token resolution into the ACLResolver (#10013)
2021-04-14 12:39:35 -04:00
agent_endpoint_test.go
Omit empty tproxy config in JSON responses (#10402)
2021-06-15 13:53:35 -06:00
agent_endpoint.go
fix backwards compat for envoy command
2021-07-13 12:31:49 -04:00
agent_oss.go
Preparation for changing where license management is done.
2021-05-24 10:19:31 -04:00
agent_test.go
agent: fix two data race in agent tests
2021-07-14 18:58:16 -04:00
agent.go
Merge pull request #10588 from hashicorp/dnephin/config-fix-ports-grpc
2021-07-13 13:11:38 -04:00
apiserver_test.go
agent: add apiServers type for managing HTTP servers
2020-09-03 13:40:12 -04:00
apiserver.go
agent: fix bug with multiple listeners
2020-11-18 13:03:29 -05:00
catalog_endpoint_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
catalog_endpoint.go
http: add partition query param parsing
2021-07-14 12:07:38 -07:00
check.go
…
config_endpoint_test.go
Rename CatalogDestinationsOnly (#10397)
2021-06-14 14:15:09 -06:00
config_endpoint.go
connect: intentions are now managed as a new config entry kind "service-intentions" (#8834)
2020-10-06 13:24:05 -05:00
connect_auth.go
connect: include optional partition prefixes in SPIFFE identifiers (#10507)
2021-06-25 16:47:47 -05:00
connect_ca_endpoint_test.go
ca: remove unused RotationPeriod field
2021-07-05 19:15:44 -04:00
connect_ca_endpoint.go
Format certificates properly (rfc7468) with a trailing new line (#10411)
2021-06-30 20:48:29 -04:00
coordinate_endpoint_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
coordinate_endpoint.go
api: rename HTTPServer to HTTPHandlers
2020-09-18 17:38:23 -04:00
denylist_test.go
…
denylist.go
…
discovery_chain_endpoint_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
discovery_chain_endpoint.go
http: Check HTTPUseCache in a single place
2020-12-11 14:03:47 -05:00
dns_oss.go
…
dns_test.go
return an empty record when asked for an addr dns with type other then A, AAAA and ANY (#10401)
2021-06-24 20:44:44 -04:00
dns.go
return an empty record when asked for an addr dns with type other then A, AAAA and ANY (#10401)
2021-06-24 20:44:44 -04:00
enterprise_delegate_oss.go
…
event_endpoint_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
event_endpoint.go
Move static token resolution into the ACLResolver (#10013)
2021-04-14 12:39:35 -04:00
federation_state_endpoint.go
api: rename HTTPServer to HTTPHandlers
2020-09-18 17:38:23 -04:00
health_endpoint_test.go
streaming: fix enable of streaming in the client
2021-06-28 17:23:14 -04:00
health_endpoint.go
http: set consistency header properly
2021-05-06 13:19:45 -04:00
http_decode_test.go
Add support for configuring TLS ServerName for health checks
2021-03-16 18:16:44 -04:00
http_oss_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
http_oss.go
http: add partition query param parsing
2021-07-14 12:07:38 -07:00
http_register.go
Switch to using the external autopilot module
2020-11-09 09:22:11 -05:00
http_test.go
agent: fix two data race in agent tests
2021-07-14 18:58:16 -04:00
http.go
http: add an X-Consul-Query-Backend header to responses
2021-06-28 16:44:58 -04:00
intentions_endpoint_oss_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
intentions_endpoint_test.go
server: deletions of intentions by name using the intention API is now idempotent (#9278)
2021-01-04 11:27:00 -06:00
intentions_endpoint.go
agent: allow the /v1/connect/intentions/match endpoint to use the agent cache (#8875)
2020-10-08 14:51:53 -05:00
keyring_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
keyring.go
agent: Move setupKeyring functions to keyring.go
2020-08-13 11:58:21 -04:00
kvs_endpoint_test.go
Add content type headers to raw KV responses
2021-04-14 16:20:22 -04:00
kvs_endpoint.go
Add content type headers to raw KV responses
2021-04-14 16:20:22 -04:00
nodeid_test.go
testing: Remove all the defer os.Removeall
2020-08-14 19:58:53 -04:00
nodeid.go
chore: upgrade to gopsutil/v3 (#9118)
2020-11-06 20:48:38 -05:00
notify_test.go
…
notify.go
…
operator_endpoint_oss.go
Add a CLI command for retrieving the autopilot configuration. (#9142)
2020-11-11 13:19:02 -05:00
operator_endpoint_test.go
Fix defaults for autopilot config update
2021-07-06 18:39:40 -04:00
operator_endpoint.go
Fix defaults for autopilot config update
2021-07-06 18:39:40 -04:00
prepared_query_endpoint_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
prepared_query_endpoint.go
http: Check HTTPUseCache in a single place
2020-12-11 14:03:47 -05:00
reload.go
Refactor uiserver to separate package, cleaner Reloading
2020-10-01 11:32:25 +01:00
remote_exec_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
remote_exec.go
…
retry_join_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
retry_join.go
…
service_checks_test.go
agent: move deprecated AddServiceFromSource to a test file
2021-01-25 17:25:03 -05:00
service_manager_test.go
agent: fix a data race in a test
2021-07-14 18:58:16 -04:00
service_manager.go
Add flag for transparent proxies to dial individual instances (#10329)
2021-06-09 14:34:17 -06:00
session_endpoint_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
session_endpoint.go
api: rename HTTPServer to HTTPHandlers
2020-09-18 17:38:23 -04:00
setup_oss.go
Move some things around to allow for license updating via config reload
2021-05-25 09:57:50 -04:00
setup.go
connect: emit a metric for the number of seconds until root CA expiration
2021-06-14 16:57:01 -04:00
sidecar_service_test.go
agent: move deprecated AddServiceFromSource to a test file
2021-01-25 17:25:03 -05:00
sidecar_service.go
Replace use of 'sane' where appropriate
2021-07-02 12:18:46 -04:00
signal_unix.go
…
signal_windows.go
…
snapshot_endpoint_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
snapshot_endpoint.go
api: rename HTTPServer to HTTPHandlers
2020-09-18 17:38:23 -04:00
status_endpoint_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
status_endpoint.go
api: rename HTTPServer to HTTPHandlers
2020-09-18 17:38:23 -04:00
streaming_test.go
streaming: fix enable of streaming in the client
2021-06-28 17:23:14 -04:00
testagent_test.go
config: Make Source an interface
2020-08-10 12:46:28 -04:00
testagent.go
agent: fix a data race in DNS tests
2021-07-14 18:58:16 -04:00
translate_addr.go
…
txn_endpoint_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
txn_endpoint.go
Add support for configuring TLS ServerName for health checks
2021-03-16 18:16:44 -04:00
ui_endpoint_oss_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
ui_endpoint_test.go
Update viz endpoint to include topology from intentions
2021-04-14 10:20:15 -06:00
ui_endpoint.go
Merge pull request #10016 from hashicorp/topology-update
2021-04-15 14:11:23 -06:00
user_event_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
user_event.go
subscribe: Add steps to rpc/subscribe tests
2020-10-08 15:38:01 -04:00
util_test.go
testing: skip slow tests with -short
2020-12-07 13:42:55 -05:00
util.go
…
watch_handler_test.go
watch: Allow args from different types
2020-07-10 17:18:32 -04:00
watch_handler.go
watch: Allow args from different types
2020-07-10 17:18:32 -04:00