mirror of
https://github.com/status-im/consul.git
synced 2025-03-02 14:20:39 +00:00
a14a37a078
This commit includes several pieces of functionality to enable services to be removed and the page to present information that this has happened but also keep the deleted information on the page. Along with the more usual blocking query based listing. To enable this: 1. Implements `meta` on the model (only available on collections in ember) 2. Adds new `catchable` ComputedProperty alongside a `listen` helper for working with specific errors that can be thrown from EventSources in an ember-like way. Briefly, normal computed properties update when a property changes, EventSources can additionally throw errors so we can catch them and show different visuals based on that. Also: Add support for blocking queries on the service instance detail page 1. Previous we could return undefined when a service instance has no proxy, but this means we have nothing to attach `meta` to. We've changed this to return an almost empty object, so with only a meta property. At first glance there doesn't seem to be any way to provide a proxy object to templates and be able to detect whether it is actually null or not so we instead change some conditional logic in the templates to detect the property we are using to generate the anchor. 2. Made a `pauseUntil` test helper function for steps where we wait for things. This helps for DRYness but also means if we can move away from setInterval to something else later, we can do it in one place 3. Whilst running into point 1 here, we managed to make the blocking queries eternally loop. Whilst this is due to an error in the code and shouldn't ever happen whilst in actual use, we've added an extra check so that we only recur/loop the blocking query if the previous response has a `meta.cursor` Adds support for blocking queries on the node detail page (#5489) 1. Moves data re-shaping for the templates variables into a repository so they are easily covered by blocking queries (into coordinatesRepo) 2. The node API returns a 404 as signal for deregistration, we also close the sessions and coordinates blocking queries when this happens
78 lines
2.1 KiB
Gherkin
78 lines
2.1 KiB
Gherkin
@setupApplicationTest
|
|
Feature: dc / nodes / show: Show node
|
|
Background:
|
|
Given 1 datacenter model with the value "dc1"
|
|
Scenario: Given 2 nodes all the tabs are visible and clickable
|
|
Given 2 node models from yaml
|
|
When I visit the node page for yaml
|
|
---
|
|
dc: dc1
|
|
node: node-0
|
|
---
|
|
And I see healthChecksIsSelected on the tabs
|
|
|
|
When I click services on the tabs
|
|
And I see servicesIsSelected on the tabs
|
|
|
|
When I click roundTripTime on the tabs
|
|
And I see roundTripTimeIsSelected on the tabs
|
|
|
|
When I click lockSessions on the tabs
|
|
And I see lockSessionsIsSelected on the tabs
|
|
Scenario: Given 1 node all the tabs are visible and clickable and the RTT one isn't there
|
|
Given 1 node models from yaml
|
|
---
|
|
ID: node-0
|
|
---
|
|
When I visit the node page for yaml
|
|
---
|
|
dc: dc1
|
|
node: node-0
|
|
---
|
|
And I see healthChecksIsSelected on the tabs
|
|
|
|
When I click services on the tabs
|
|
And I see servicesIsSelected on the tabs
|
|
|
|
And I don't see roundTripTime on the tabs
|
|
|
|
When I click lockSessions on the tabs
|
|
And I see lockSessionsIsSelected on the tabs
|
|
Scenario: Given 1 node with no checks all the tabs are visible but the Services tab is selected
|
|
Given 1 node models from yaml
|
|
---
|
|
ID: node-0
|
|
Checks: []
|
|
---
|
|
When I visit the node page for yaml
|
|
---
|
|
dc: dc1
|
|
node: node-0
|
|
---
|
|
And I see healthChecks on the tabs
|
|
And I see services on the tabs
|
|
And I see roundTripTime on the tabs
|
|
And I see lockSessions on the tabs
|
|
And I see servicesIsSelected on the tabs
|
|
Scenario: A node warns when deregistered whilst blocking
|
|
Given 1 node model from yaml
|
|
---
|
|
ID: node-0
|
|
---
|
|
And settings from yaml
|
|
---
|
|
consul:client:
|
|
blocking: 1
|
|
throttle: 200
|
|
---
|
|
And a network latency of 100
|
|
When I visit the node page for yaml
|
|
---
|
|
dc: dc1
|
|
node: node-0
|
|
---
|
|
Then the url should be /dc1/nodes/node-0
|
|
And the url "/v1/internal/ui/node/node-0" responds with a 404 status
|
|
And pause until I see the text "no longer exists" in "[data-notification]"
|
|
|