consul/ui/packages/consul-ui/app/components/menu-panel
Michael Klein 03a1a86dfe
ui: chore - upgrade ember and friends (#14518)
* v3.20.2...v3.24.0

* Fix handle undefined outlet in route component

* Don't use template helper for optional modal.open

Using the optional-helper here will trigger a computation
in the same runloop error. This is because we are setting
the `modal`-property when the `<Ref>` component gets
rendered which will update the `this.modal`-property which
will then recompute the `optional`-helper leading to this
error.

Instead we will create an action that will call the `open`-method
on the modal when it is defined. This gets rid of the double
computation error as we will not access the modal property
twice in the same runloop when `modal` is getting set.

* Fix - fn needs to be passed function tab-nav

We create functions in the component file instead
so that fn-helper stops complaining about the
need to pass a function.

* Update ember-exam to 6.1 version

"Makes it compatible" with ember-qunit v5

* scheduleOnce setMaxHeight paged-collection

We need to schedule to get around double-computation error.

* Fix - model.data is removed from ember-data

This has been private API all along - we need to
work around the removal.

Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310

* Fix `propContains` instead of `deepEqual` policy

Recent model.data works differently than iterating attributes.
We use `propContains` instead of `deepEqual`. We are only
interested in the properties we assert against and match
the previous behavior with this change.

* Fix `propContains` instead of `deepEqual` token

* Better handling single-records repo test-helper

`model.data` has been removed we need to handle proxies and
model instances differently.

* Fix remaining repository tests with propContains

We don't want to match entire objects - we don't care
about properties we haven't defined in the assertion.

* Don't use template helper for optional modal.open

Using a template helper will give us a recomputation error -
we work around it by creating an explicit action on
the component instead.

* Await `I $verb the $pageObject object` step

* Fix no more customization ember-can

No need to customize, the helper handles destruction
fine on its own.

* Fix - don't pass `optional` functions to fn

We will declare the functions on the component instead.
This gives us the same behavior but no error from
`fn`, which expects a function to be passed.

* Fix - handle `undefined` state on validate modifier

StateChart can yield out an undefined `state` we need
to handle that in the validate modifier

* Fix linting errors tests directory

* Warn / turn off new ember linting issues

We will tackle them one by one and don't want to
autofix issues that could be dangerous to auto-fix.

* Auto-fix linting issues

* More linting configuration

* Fix remaining linting issues

* Fix linting issues new files after rebase

* ui: Remove ember-cli-uglify config now we are using terser (#14574)

Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
2022-09-15 09:43:17 +01:00
..
README.mdx ui: Transition App Chrome to use new Disclosure Menus (#12334) 2022-02-21 12:22:59 +00:00
deprecated.scss ui: Transition App Chrome to use new Disclosure Menus (#12334) 2022-02-21 12:22:59 +00:00
index.hbs ui: Transition App Chrome to use new Disclosure Menus (#12334) 2022-02-21 12:22:59 +00:00
index.js ui: chore - upgrade ember and friends (#14518) 2022-09-15 09:43:17 +01:00
index.scss ui: Icon related fixups (#13183) 2022-05-25 14:28:42 +01:00
layout.scss ui: Transition App Chrome to use new Disclosure Menus (#12334) 2022-02-21 12:22:59 +00:00
skin.scss ui: Transition App Chrome to use new Disclosure Menus (#12334) 2022-02-21 12:22:59 +00:00

README.mdx

# MenuPanel

```hbs preview-template

{{#each
  (array 'light' 'dark')
as |theme|}}
  <figure>
    <figcaption>Without a header</figcaption>
    <div
      class={{class-map
        'menu-panel'
        (array (concat 'theme-' theme))
      }}
    >
      <ul role="menu">
        <li aria-current="true" role="none">
          <Action role="menuitem">Item 1<span>Label</span><span>Label 2</span></Action>
        </li>
        <li role="separator">
          Item some title text
        </li>
        <li role="none">
          <Action role="menuitem">Item 2</Action>
        </li>
        <li role="separator"></li>
        <li role="none">
          <Action role="menuitem">Item 3</Action>
        </li>
      </ul>
    </div>
  </figure>
  <figure>
    <figcaption>With a header</figcaption>
    <div
      class={{class-map
        'menu-panel'
        (array (concat 'theme-' theme))
      }}
    >
      <div>
        <p>Some content explaining what the menu is about</p>
      </div>
      <ul role="menu">
        <li aria-current="true" role="none">
          <Action role="menuitem">Item 1<span>Label</span><span>Label 2</span></Action>
        </li>
        <li role="separator">
          Item some title text
        </li>
        <li role="none">
          <Action role="menuitem">Item 2</Action>
        </li>
        <li role="separator"></li>
        <li role="none">
          <Action role="menuitem">Item 3</Action>
        </li>
      </ul>
    </div>
  </figure>

  <figure>
    <StateChart
      @src={{state-chart 'boolean'}}
    as |State Guard StateAction dispatch state|>
      <Action>Focus Left</Action>
      <DisclosureMenu as |disclosure|>
        <disclosure.Action
          {{on 'click' disclosure.toggle}}
        >
          {{if disclosure.expanded 'Close' 'Open'}}
        </disclosure.Action>
        <disclosure.Menu
          style={{style-map
            (array 'max-height' (if (state-matches state 'true') (add 0 this.rect.height)) 'px')
          }}
          class={{class-map
            (array 'menu-panel')
            (array 'menu-panel-confirming' (state-matches state 'true'))
            (array (concat 'theme-' theme))
          }}

        as |panel|>
          <div
            {{on-resize
              (dom-position (set this 'header'))
            }}
          >
            <p>Some text in here</p>
          </div>
          <panel.Menu as |menu|>
            <menu.Item
              aria-current="true"
            >
              <menu.Action>
                Item 1
                <span>Label</span>
                <span>Label 2</span>
              </menu.Action>
            </menu.Item>
            <menu.Separator>
              Item some title text
            </menu.Separator>
            <menu.Item>
              <menu.Action>
                Item 2
              </menu.Action>
            </menu.Item>
            <menu.Separator />
            <menu.Item
              class="dangerous"
            >
              <menu.Action
                {{on "click" (fn dispatch 'TOGGLE')}}
              >
                Item 3
              </menu.Action>

              <div
                {{on-resize
                  (dom-position (set this 'rect'))
                }}
                style={{style-map
                  (array 'top' (if (state-matches state 'true') (sub 0 this.header.height)) 'px')
                }}
                class={{class-map
                  'menu-panel-confirmation'
                  'informed-action'
                  'confirmation-alert'
                  'warning'
                }}
              >
                <div>
                  <header>Hi</header>
                  <p>Body</p>
                </div>
                <ul>
                  <li>
                    <Action
                      @tabindex="-1"
                      {{on "click" (queue disclosure.close (fn dispatch 'TOGGLE'))}}
                    >
                      Confirm
                    </Action>
                  </li>
                  <li>
                    <Action
                      @tabindex="-1"
                      {{on "click" (fn dispatch 'TOGGLE')}}
                    >
                      Cancel
                    </Action>
                  </li>
                </ul>
              </div>

            </menu.Item>
          </panel.Menu>

        </disclosure.Menu>

      </DisclosureMenu>

      <Action>Focus Right</Action>
    </StateChart>
  </figure>

{{/each}}
```