mirror of
https://github.com/status-im/consul.git
synced 2025-02-07 19:35:35 +00:00
03a1a86dfe
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
125 lines
3.3 KiB
JavaScript
125 lines
3.3 KiB
JavaScript
import Modifier from 'ember-modifier';
|
|
import { action } from '@ember/object';
|
|
|
|
class ValidationError extends Error {}
|
|
|
|
export default class ValidateModifier extends Modifier {
|
|
item = null;
|
|
hash = null;
|
|
|
|
validate(value, validations = {}) {
|
|
if (Object.keys(validations).length === 0) {
|
|
return;
|
|
}
|
|
const errors = {};
|
|
Object.entries(this.hash.validations)
|
|
// filter out strings, for now these are helps, but ain't great if someone has a item.help
|
|
.filter(([key, value]) => typeof value !== 'string')
|
|
.forEach(([key, item]) => {
|
|
// optionally set things for you
|
|
if (this.item) {
|
|
this.item[key] = value;
|
|
}
|
|
(item || []).forEach((validation) => {
|
|
const re = new RegExp(validation.test);
|
|
if (!re.test(value)) {
|
|
errors[key] = new ValidationError(validation.error);
|
|
}
|
|
});
|
|
});
|
|
const state = this.hash.chart.state || {};
|
|
if (state.context == null) {
|
|
state.context = {};
|
|
}
|
|
if (Object.keys(errors).length > 0) {
|
|
state.context.errors = errors;
|
|
this.hash.chart.dispatch('ERROR', state.context);
|
|
} else {
|
|
state.context.errors = null;
|
|
this.hash.chart.dispatch('RESET', state.context);
|
|
}
|
|
}
|
|
|
|
@action
|
|
reset(e) {
|
|
if (e.target.value.length === 0) {
|
|
const state = this.hash.chart.state;
|
|
if (!state.context) {
|
|
state.context = {};
|
|
}
|
|
if (!state.context.errors) {
|
|
state.context.errors = {};
|
|
}
|
|
Object.entries(this.hash.validations)
|
|
// filter out strings, for now these are helps, but ain't great if someone has a item.help
|
|
.filter(([key, value]) => typeof value !== 'string')
|
|
.forEach(([key, item]) => {
|
|
if (typeof state.context.errors[key] !== 'undefined') {
|
|
delete state.context.errors[key];
|
|
}
|
|
});
|
|
if (Object.keys(state.context.errors).length === 0) {
|
|
state.context.errors = null;
|
|
this.hash.chart.dispatch('RESET', state.context);
|
|
}
|
|
}
|
|
}
|
|
|
|
async connect([value], _hash) {
|
|
this.element.addEventListener('input', this.listen);
|
|
this.element.addEventListener('blur', this.reset);
|
|
if (this.element.value.length > 0) {
|
|
await Promise.resolve();
|
|
if (this && this.element) {
|
|
this.validate(this.element.value, this.hash.validations);
|
|
}
|
|
}
|
|
}
|
|
|
|
@action
|
|
listen(e) {
|
|
this.validate(e.target.value, this.hash.validations);
|
|
}
|
|
|
|
disconnect() {
|
|
this.item = null;
|
|
this.hash = null;
|
|
this.element.removeEventListener('input', this.listen);
|
|
this.element.removeEventListener('blur', this.reset);
|
|
}
|
|
|
|
didReceiveArguments() {
|
|
const [value] = this.args.positional;
|
|
const _hash = this.args.named;
|
|
|
|
this.item = value;
|
|
this.hash = _hash;
|
|
|
|
if (typeof _hash.chart === 'undefined') {
|
|
this.hash.chart = {
|
|
state: {
|
|
context: {},
|
|
},
|
|
dispatch: (state) => {
|
|
switch (state) {
|
|
case 'ERROR':
|
|
_hash.onchange(this.hash.chart.state.context.errors);
|
|
break;
|
|
case 'RESET':
|
|
_hash.onchange();
|
|
break;
|
|
}
|
|
},
|
|
};
|
|
}
|
|
}
|
|
|
|
didInstall() {
|
|
this.connect(this.args.positional, this.args.named);
|
|
}
|
|
|
|
willRemove() {
|
|
this.disconnect();
|
|
}
|
|
}
|