mirror of https://github.com/status-im/consul.git
03a1a86dfe
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com> |
||
---|---|---|
.. | ||
README.mdx | ||
index.hbs | ||
index.js | ||
index.scss | ||
layout.scss | ||
pageobject.js | ||
skin.scss |
README.mdx
--- state: needs-love --- # TabNav `<TabNav />` renders a list of items as linked tabs (there is also an option to use labels vs anchors for links for radio button based tabs). Each item in the list should be a hash of `label`, `href` and `selected`. - `label`: The text to show - `href`: a href, probably generated via `href-to` - `selected`: whether the item is in the selected state or not, probably of the state to transition to. There are two similar event handlers, `@onclick` and `@onTabClick`. When using `@onclick`, the `item.label` is passed to the handler. When using `@onTabClick` the entire 'item' is passed instead, therefore you can add arbitrary properties to the 'item' to be used in the handler. **Please note:** This component should probably be rebuilt using contextual components, and real events. Alternatively this could be hand built with native HTML using the same `nav/ul/li/a` pattern and you could just use the CSS component to style it. Unless there is a reason to do this, this component should be used pending a refactor (please remove this note once refactored into contextual components) ```hbs preview-template <figure> <figcaption>A TabNav with a conditional button using `compact` which removes empty values from arrays</figcaption> <TabNav @items={{ compact (array (hash label="Health Checks" href="#" selected=true) (hash label="Service Instances" href="#" selected=(is-href "docs.something")) (if false (hash label="Don't show me" href="#" selected=false) '') (hash label="Lock Sessions" href="#" selected=false) (hash label="Metadata" href="#" selected=false) ) }}/> </figure> ``` A TabNav with using a `StateMachine.dispatch` ```hbs <figure> <figcaption>A TabNav with using a StateMachine.dispatch</figcaption> <TabNav @items={{ compact (array (hash label="1" selected=(state-matches fsm.state 'one') state="ONE" ) (hash label="2" selected=(state-matches fsm.state 'two') state="TWO" ) ) }} @onTabClicked={{pick 'state' fsm.dispatch}} /> </figure> ``` ```css .tab-nav { @extend %tab-nav; } ```