Michael Klein 03a1a86dfe
ui: chore - upgrade ember and friends (#14518)
* v3.20.2...v3.24.0

* Fix handle undefined outlet in route component

* Don't use template helper for optional modal.open

Using the optional-helper here will trigger a computation
in the same runloop error. This is because we are setting
the `modal`-property when the `<Ref>` component gets
rendered which will update the `this.modal`-property which
will then recompute the `optional`-helper leading to this
error.

Instead we will create an action that will call the `open`-method
on the modal when it is defined. This gets rid of the double
computation error as we will not access the modal property
twice in the same runloop when `modal` is getting set.

* Fix - fn needs to be passed function tab-nav

We create functions in the component file instead
so that fn-helper stops complaining about the
need to pass a function.

* Update ember-exam to 6.1 version

"Makes it compatible" with ember-qunit v5

* scheduleOnce setMaxHeight paged-collection

We need to schedule to get around double-computation error.

* Fix - model.data is removed from ember-data

This has been private API all along - we need to
work around the removal.

Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310

* Fix `propContains` instead of `deepEqual` policy

Recent model.data works differently than iterating attributes.
We use `propContains` instead of `deepEqual`. We are only
interested in the properties we assert against and match
the previous behavior with this change.

* Fix `propContains` instead of `deepEqual` token

* Better handling single-records repo test-helper

`model.data` has been removed we need to handle proxies and
model instances differently.

* Fix remaining repository tests with propContains

We don't want to match entire objects - we don't care
about properties we haven't defined in the assertion.

* Don't use template helper for optional modal.open

Using a template helper will give us a recomputation error -
we work around it by creating an explicit action on
the component instead.

* Await `I $verb the $pageObject object` step

* Fix no more customization ember-can

No need to customize, the helper handles destruction
fine on its own.

* Fix - don't pass `optional` functions to fn

We will declare the functions on the component instead.
This gives us the same behavior but no error from
`fn`, which expects a function to be passed.

* Fix - handle `undefined` state on validate modifier

StateChart can yield out an undefined `state` we need
to handle that in the validate modifier

* Fix linting errors tests directory

* Warn / turn off new ember linting issues

We will tackle them one by one and don't want to
autofix issues that could be dangerous to auto-fix.

* Auto-fix linting issues

* More linting configuration

* Fix remaining linting issues

* Fix linting issues new files after rebase

* ui: Remove ember-cli-uglify config now we are using terser (#14574)

Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
2022-09-15 09:43:17 +01:00

108 lines
2.4 KiB
JavaScript

import Modifier from 'ember-modifier';
import { inject as service } from '@ember/service';
import { action } from '@ember/object';
const TAB = 9;
const ESC = 27;
const END = 35;
const HOME = 36;
const ARROW_UP = 38;
const ARROW_DOWN = 40;
const keys = {
vertical: {
[ARROW_DOWN]: ($items, i = -1) => {
return (i + 1) % $items.length;
},
[ARROW_UP]: ($items, i = 0) => {
if (i === 0) {
return $items.length - 1;
} else {
return i - 1;
}
},
[HOME]: ($items, i) => {
return 0;
},
[END]: ($items, i) => {
return $items.length - 1;
},
},
horizontal: {},
};
const MENU_ITEMS = '[role^="menuitem"]';
export default class AriaMenuModifier extends Modifier {
@service('-document') doc;
orientation = 'vertical';
@action
async keydown(e) {
if (e.keyCode === ESC) {
this.options.onclose(e);
this.$trigger.focus();
return;
}
const $items = [...this.element.querySelectorAll(MENU_ITEMS)];
const pos = $items.findIndex(($item) => $item === this.doc.activeElement);
if (e.keyCode === TAB) {
if (e.shiftKey) {
if (pos === 0) {
this.options.onclose(e);
this.$trigger.focus();
}
} else {
if (pos === $items.length - 1) {
await new Promise((resolve) => setTimeout(resolve, 0));
this.options.onclose(e);
}
}
return;
}
if (typeof keys[this.orientation][e.keyCode] === 'undefined') {
return;
}
$items[keys[this.orientation][e.keyCode]($items, pos)].focus();
e.stopPropagation();
e.preventDefault();
}
@action
async focus(e) {
if (e.pointerType === '') {
await Promise.resolve();
this.keydown({
keyCode: HOME,
stopPropagation: () => {},
preventDefault: () => {},
});
}
}
connect(params, named) {
this.$trigger = this.doc.getElementById(this.element.getAttribute('aria-labelledby'));
if (typeof named.openEvent !== 'undefined') {
this.focus(named.openEvent);
}
this.doc.addEventListener('keydown', this.keydown);
}
disconnect() {
this.doc.removeEventListener('keydown', this.keydown);
}
didReceiveArguments() {
this.params = this.args.positional;
this.options = this.args.named;
}
didInstall() {
this.connect(this.args.positional, this.args.named);
}
willRemove() {
this.disconnect();
}
}