mirror of
https://github.com/status-im/consul.git
synced 2025-01-10 13:55:55 +00:00
78b170ad50
* Refactors the leafcert package to not have a dependency on agent/consul and agent/cache to avoid import cycles. This way the xds controller can just import the leafcert package to use the leafcert manager. The leaf cert logic in the controller: * Sets up watches for leaf certs that are referenced in the ProxyStateTemplate (which generates the leaf certs too). * Gets the leaf cert from the leaf cert cache * Stores the leaf cert in the ProxyState that's pushed to xds * For the cert watches, this PR also uses a bimapper + a thin wrapper to map leaf cert events to related ProxyStateTemplates Since bimapper uses a resource.Reference or resource.ID to map between two resource types, I've created an internal type for a leaf certificate to use for the resource.Reference, since it's not a v2 resource. The wrapper allows mapping events to resources (as opposed to mapping resources to resources) The controller tests: Unit: Ensure that we resolve leaf cert references Lifecycle: Ensure that when the CA is updated, the leaf cert is as well Also adds a new spiffe id type, and adds workload identity and workload identity URI to leaf certs. This is so certs are generated with the new workload identity based SPIFFE id. * Pulls out some leaf cert test helpers into a helpers file so it can be used in the xds controller tests. * Wires up leaf cert manager dependency * Support getting token from proxytracker * Add workload identity spiffe id type to the authorize and sign functions --------- Co-authored-by: John Murret <john.murret@hashicorp.com>
224 lines
5.7 KiB
Go
224 lines
5.7 KiB
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package connect
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/hashicorp/consul/agent/structs"
|
|
"github.com/hashicorp/consul/sdk/testutil"
|
|
)
|
|
|
|
func TestParseCertURIFromString(t *testing.T) {
|
|
defaultEntMeta := structs.DefaultEnterpriseMetaInDefaultPartition()
|
|
|
|
var cases = []struct {
|
|
Name string
|
|
URI string
|
|
Struct interface{}
|
|
ParseError string
|
|
}{
|
|
{
|
|
Name: "invalid scheme",
|
|
URI: "http://google.com/",
|
|
Struct: nil,
|
|
ParseError: "scheme",
|
|
},
|
|
{
|
|
Name: "basic service ID",
|
|
URI: "spiffe://1234.consul/ns/default/dc/dc01/svc/web",
|
|
Struct: &SpiffeIDService{
|
|
Host: "1234.consul",
|
|
Partition: defaultEntMeta.PartitionOrDefault(),
|
|
Namespace: "default",
|
|
Datacenter: "dc01",
|
|
Service: "web",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "basic service ID with partition",
|
|
URI: "spiffe://1234.consul/ap/bizdev/ns/default/dc/dc01/svc/web",
|
|
Struct: &SpiffeIDService{
|
|
Host: "1234.consul",
|
|
Partition: "bizdev",
|
|
Namespace: "default",
|
|
Datacenter: "dc01",
|
|
Service: "web",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "basic workload ID",
|
|
URI: "spiffe://1234.consul/ap/default/ns/default/identity/web",
|
|
Struct: &SpiffeIDWorkloadIdentity{
|
|
TrustDomain: "1234.consul",
|
|
Partition: defaultEntMeta.PartitionOrDefault(),
|
|
Namespace: "default",
|
|
WorkloadIdentity: "web",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "basic workload ID with nondefault partition",
|
|
URI: "spiffe://1234.consul/ap/bizdev/ns/default/identity/web",
|
|
Struct: &SpiffeIDWorkloadIdentity{
|
|
TrustDomain: "1234.consul",
|
|
Partition: "bizdev",
|
|
Namespace: "default",
|
|
WorkloadIdentity: "web",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "workload ID error - missing identity",
|
|
URI: "spiffe://1234.consul/ns/default",
|
|
Struct: &SpiffeIDWorkloadIdentity{
|
|
TrustDomain: "1234.consul",
|
|
Partition: defaultEntMeta.PartitionOrDefault(),
|
|
Namespace: "default",
|
|
WorkloadIdentity: "web",
|
|
},
|
|
ParseError: "SPIFFE ID is not in the expected format",
|
|
},
|
|
{
|
|
Name: "workload ID error - missing partition",
|
|
URI: "spiffe://1234.consul/ns/default/identity/web",
|
|
Struct: &SpiffeIDWorkloadIdentity{
|
|
TrustDomain: "1234.consul",
|
|
Partition: defaultEntMeta.PartitionOrDefault(),
|
|
Namespace: "default",
|
|
WorkloadIdentity: "web",
|
|
},
|
|
ParseError: "SPIFFE ID is not in the expected format",
|
|
},
|
|
{
|
|
Name: "workload ID error - missing namespace",
|
|
URI: "spiffe://1234.consul/ap/default/identity/web",
|
|
Struct: &SpiffeIDWorkloadIdentity{
|
|
TrustDomain: "1234.consul",
|
|
Partition: defaultEntMeta.PartitionOrDefault(),
|
|
Namespace: "default",
|
|
WorkloadIdentity: "web",
|
|
},
|
|
ParseError: "SPIFFE ID is not in the expected format",
|
|
},
|
|
{
|
|
Name: "basic agent ID",
|
|
URI: "spiffe://1234.consul/agent/client/dc/dc1/id/uuid",
|
|
Struct: &SpiffeIDAgent{
|
|
Host: "1234.consul",
|
|
Partition: defaultEntMeta.PartitionOrDefault(),
|
|
Datacenter: "dc1",
|
|
Agent: "uuid",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "basic agent ID with partition",
|
|
URI: "spiffe://1234.consul/ap/bizdev/agent/client/dc/dc1/id/uuid",
|
|
Struct: &SpiffeIDAgent{
|
|
Host: "1234.consul",
|
|
Partition: "bizdev",
|
|
Datacenter: "dc1",
|
|
Agent: "uuid",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "basic server",
|
|
URI: "spiffe://1234.consul/agent/server/dc/dc1",
|
|
Struct: &SpiffeIDServer{
|
|
Host: "1234.consul",
|
|
Datacenter: "dc1",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "mesh-gateway with no partition",
|
|
URI: "spiffe://1234.consul/gateway/mesh/dc/dc1",
|
|
Struct: &SpiffeIDMeshGateway{
|
|
Host: "1234.consul",
|
|
Partition: "default",
|
|
Datacenter: "dc1",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "mesh-gateway with partition",
|
|
URI: "spiffe://1234.consul/ap/bizdev/gateway/mesh/dc/dc1",
|
|
Struct: &SpiffeIDMeshGateway{
|
|
Host: "1234.consul",
|
|
Partition: "bizdev",
|
|
Datacenter: "dc1",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "service with URL-encoded values",
|
|
URI: "spiffe://1234.consul/ns/foo%2Fbar/dc/bar%2Fbaz/svc/baz%2Fqux",
|
|
Struct: &SpiffeIDService{
|
|
Host: "1234.consul",
|
|
Partition: defaultEntMeta.PartitionOrDefault(),
|
|
Namespace: "foo/bar",
|
|
Datacenter: "bar/baz",
|
|
Service: "baz/qux",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "service with URL-encoded values with partition",
|
|
URI: "spiffe://1234.consul/ap/biz%2Fdev/ns/foo%2Fbar/dc/bar%2Fbaz/svc/baz%2Fqux",
|
|
Struct: &SpiffeIDService{
|
|
Host: "1234.consul",
|
|
Partition: "biz/dev",
|
|
Namespace: "foo/bar",
|
|
Datacenter: "bar/baz",
|
|
Service: "baz/qux",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
{
|
|
Name: "signing ID",
|
|
URI: "spiffe://1234.consul",
|
|
Struct: &SpiffeIDSigning{
|
|
ClusterID: "1234",
|
|
Domain: "consul",
|
|
},
|
|
ParseError: "",
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.Name, func(t *testing.T) {
|
|
actual, err := ParseCertURIFromString(tc.URI)
|
|
if tc.ParseError != "" {
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), tc.ParseError)
|
|
testutil.RequireErrorContains(t, err, tc.ParseError)
|
|
} else {
|
|
require.NoError(t, err)
|
|
require.Equal(t, tc.Struct, actual)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestSpiffeIDServer_URI(t *testing.T) {
|
|
srv := &SpiffeIDServer{
|
|
Host: "1234.consul",
|
|
Datacenter: "dc1",
|
|
}
|
|
|
|
require.Equal(t, "spiffe://1234.consul/agent/server/dc/dc1", srv.URI().String())
|
|
}
|
|
|
|
func TestServerSAN(t *testing.T) {
|
|
san := PeeringServerSAN("dc1", TestTrustDomain)
|
|
expect := "server.dc1.peering." + TestTrustDomain
|
|
require.Equal(t, expect, san)
|
|
}
|