status-im
/
consul
mirror of https://github.com/status-im/consul.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
consul/internal/go-sso
History
Daniel Nephin e8312d6b5a testing: remove unnecessary calls to freeport 
Previously we believe it was necessary for all code that required ports
to use freeport to prevent conflicts.

https://github.com/dnephin/freeport-test shows that it is actually save
to use port 0 (`127.0.0.1:0`) as long as it is passed directly to
`net.Listen`, and the listener holds the port for as long as it is
needed.

This works because freeport explicitly avoids the ephemeral port range,
and port 0 always uses that range. As you can see from the test output
of https://github.com/dnephin/freeport-test, the two systems never use
overlapping ports.

This commit converts all uses of freeport that were being passed
directly to a net.Listen to use port 0 instead. This allows us to remove
a bit of wrapping we had around httptest, in a couple places.
 		2021-11-29 12:19:43 -05:00
..
oidcauth testing: remove unnecessary calls to freeport 2021-11-29 12:19:43 -05:00
README.md acl: add auth method for JWTs (#7846) 2020-05-11 20:59:29 -05:00
go.mod.sample acl: add auth method for JWTs (#7846) 2020-05-11 20:59:29 -05:00
go.sum.sample acl: add auth method for JWTs (#7846) 2020-05-11 20:59:29 -05:00

README.md

go-sso

This is a Go library that is being incubated in Consul to assist in doing opinionated OIDC-based single sign on.

The go.mod.sample and go.sum.sample files are what the overall real go.mod and go.sum files should end up being when extracted from the Consul codebase.