Pierre Souchay
1b4218a068
fix flaky TestReplication_FederationStates test due to race conditions ( #7612 ) ...
The test had two racy bugs related to memdb references.
The first was when we initially populated data and retained the FederationState objects in a slice. Due to how the `inmemCodec` works these were actually the identical objects passed into memdb.
The second was that the `checkSame` assertion function was reading from memdb and setting the RaftIndexes to zeros to aid in equality checks. This was mutating the contents of memdb which is a no-no.
With this fix, the command:
```
i=0; while /usr/local/bin/go test -count=1 -timeout 30s github.com/hashicorp/consul/agent/consul -run '^(TestReplication_FederationStates)$'; do i=$((i + 1)); printf "$i "; done
```
That used to break on my machine in less than 20 runs is now running 150+ times without any issue.
Might also fix #7575
2020-04-09 15:42:41 -05:00
2020-02-06 15:30:58 +01:00
2020-03-10 11:15:22 -05:00
2020-04-03 10:29:38 +02:00
2020-03-09 15:59:02 -05:00
2020-02-10 09:27:12 -07:00
2020-04-09 11:11:42 +02:00
2020-03-24 15:22:01 -04:00
2020-04-09 15:42:41 -05:00
2018-11-02 12:00:39 -05:00
2020-03-31 16:13:44 -04:00
2020-03-09 15:59:02 -05:00
2019-12-09 21:26:41 -05:00
2020-03-09 15:59:02 -05:00
2020-04-02 10:12:13 -05:00
2020-03-09 15:59:02 -05:00
2020-04-08 12:37:24 -06:00
2020-02-04 13:58:56 -07:00
2020-04-02 09:35:04 +02:00
2020-03-31 16:13:44 -04:00
2019-10-29 11:13:36 -07:00
2020-03-31 16:13:44 -04:00
2020-03-25 10:34:24 -04:00
2020-03-26 12:34:31 -04:00
2020-01-29 11:16:08 -06:00
2020-03-31 17:14:55 -04:00
2020-03-26 10:20:56 -06:00
2020-02-04 13:58:56 -07:00
2020-04-02 09:59:23 +02:00
2020-04-02 09:59:23 +02:00
2020-02-11 15:19:16 +00:00
2020-03-31 16:13:44 -04:00
2020-02-10 10:40:44 -05:00
2019-12-09 21:26:41 -05:00
2020-04-08 12:37:24 -06:00
2020-01-29 19:12:48 -05:00
2019-04-30 18:19:19 -04:00
2020-01-13 15:51:40 -05:00
2020-03-31 16:13:44 -04:00
2019-11-21 17:40:29 +00:00
2020-03-31 16:13:44 -04:00
2019-10-29 11:13:36 -07:00
2020-03-31 16:13:44 -04:00
2020-01-24 10:04:58 -05:00
2019-12-09 21:26:41 -05:00
2020-03-31 16:13:44 -04:00
2020-04-05 11:12:41 +02:00
2019-05-01 11:11:27 -04:00
2020-03-31 16:13:44 -04:00
2020-01-28 17:50:41 -06:00
2020-03-09 15:59:02 -05:00
2020-03-31 16:13:44 -04:00
2020-02-10 10:40:44 -05:00
2020-02-10 09:27:12 -07:00
2020-03-31 16:13:44 -04:00
2020-01-27 07:00:33 -06:00
2020-03-25 10:34:24 -04:00
2020-03-31 17:14:55 -04:00
2020-03-03 13:18:35 +00:00
2020-03-31 16:13:44 -04:00
2020-01-29 17:30:38 -05:00
2020-03-31 17:14:55 -04:00
2020-02-13 20:35:09 +01:00
2020-03-31 16:13:44 -04:00
2020-03-09 11:13:40 +01:00
2018-08-02 14:54:48 +01:00
2018-08-02 14:54:48 +01:00
2020-03-31 16:13:44 -04:00
2019-10-29 11:13:36 -07:00
2020-03-31 16:13:44 -04:00
2020-01-17 09:54:17 -05:00
2020-03-31 16:13:44 -04:00
2020-01-28 17:50:41 -06:00
2020-03-09 15:59:02 -05:00
2020-03-09 15:59:02 -05:00
2020-03-31 16:13:44 -04:00
2020-03-31 17:14:55 -04:00
2020-03-26 10:20:56 -06:00
2020-03-31 16:13:44 -04:00
2020-03-05 15:34:55 -05:00
2020-03-31 17:14:55 -04:00
2020-03-09 15:59:02 -05:00
2018-10-02 15:57:21 -05:00
2018-10-02 15:57:21 -05:00
2020-03-31 16:13:44 -04:00
2020-03-31 16:13:44 -04:00
2019-07-25 14:26:22 -04:00
2020-03-31 17:14:55 -04:00
2020-01-24 09:27:25 -05:00
2020-03-31 16:13:44 -04:00
2020-03-09 11:13:40 +01:00
2020-04-08 12:37:24 -06:00
2020-03-27 10:57:46 -04:00
2020-03-31 16:13:44 -04:00
2020-02-07 15:50:24 -06:00
2020-04-03 14:23:03 +02:00
2020-02-07 15:50:24 -06:00
2020-01-28 17:50:41 -06:00
2020-01-28 17:50:41 -06:00
1b4218a068