mirror of
https://github.com/status-im/consul.git
synced 2025-01-24 20:51:10 +00:00
03a1a86dfe
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
77 lines
3.1 KiB
JavaScript
77 lines
3.1 KiB
JavaScript
import { module, test, skip } from 'qunit';
|
|
import { setupTest } from 'ember-qunit';
|
|
import Route from '@ember/routing/route';
|
|
import Mixin from 'consul-ui/mixins/with-blocking-actions';
|
|
import sinon from 'sinon';
|
|
|
|
module('Unit | Mixin | with blocking actions', function (hooks) {
|
|
setupTest(hooks);
|
|
|
|
hooks.beforeEach(function () {
|
|
this.subject = function () {
|
|
const MixedIn = Route.extend(Mixin);
|
|
this.owner.register('test-container:with-blocking-actions-object', MixedIn);
|
|
return this.owner.lookup('test-container:with-blocking-actions-object');
|
|
};
|
|
});
|
|
|
|
// Replace this with your real tests.
|
|
test('it works', function (assert) {
|
|
const subject = this.subject();
|
|
assert.ok(subject);
|
|
});
|
|
skip('init sets up feedback properly');
|
|
test('afterCreate just calls afterUpdate', function (assert) {
|
|
const subject = this.subject();
|
|
const expected = [1, 2, 3, 4];
|
|
const afterUpdate = sinon.stub(subject, 'afterUpdate').returns(expected);
|
|
const actual = subject.afterCreate(expected);
|
|
assert.deepEqual(actual, expected);
|
|
assert.ok(afterUpdate.calledOnce);
|
|
});
|
|
test('afterUpdate calls transitionTo without the last part of the current route name', function (assert) {
|
|
const subject = this.subject();
|
|
const expected = 'dc.kv';
|
|
subject.routeName = expected + '.edit';
|
|
const transitionTo = sinon.stub(subject, 'transitionTo').returnsArg(0);
|
|
const actual = subject.afterUpdate();
|
|
assert.equal(actual, expected);
|
|
assert.ok(transitionTo.calledOnce);
|
|
});
|
|
test('afterDelete calls transitionTo without the last part of the current route name if the last part is not `index`', function (assert) {
|
|
const subject = this.subject();
|
|
const expected = 'dc.kv';
|
|
subject.routeName = expected + '.edit';
|
|
const transitionTo = sinon.stub(subject, 'transitionTo').returnsArg(0);
|
|
const actual = subject.afterDelete();
|
|
assert.equal(actual, expected);
|
|
assert.ok(transitionTo.calledOnce);
|
|
});
|
|
test('afterDelete calls refresh if the last part is `index`', function (assert) {
|
|
const subject = this.subject();
|
|
subject.routeName = 'dc.kv.index';
|
|
const expected = 'refresh';
|
|
const refresh = sinon.stub(subject, 'refresh').returns(expected);
|
|
const actual = subject.afterDelete();
|
|
assert.equal(actual, expected);
|
|
assert.ok(refresh.calledOnce);
|
|
});
|
|
test('the error hooks return type', function (assert) {
|
|
const subject = this.subject();
|
|
const expected = 'success';
|
|
['errorCreate', 'errorUpdate', 'errorDelete'].forEach(function (item) {
|
|
const actual = subject[item](expected, {});
|
|
assert.equal(actual, expected);
|
|
});
|
|
});
|
|
test('action cancel just calls afterUpdate', function (assert) {
|
|
const subject = this.subject();
|
|
const expected = [1, 2, 3, 4];
|
|
const afterUpdate = sinon.stub(subject, 'afterUpdate').returns(expected);
|
|
// TODO: unsure as to whether ember testing should actually bind this for you?
|
|
const actual = subject.actions.cancel.bind(subject)(expected);
|
|
assert.deepEqual(actual, expected);
|
|
assert.ok(afterUpdate.calledOnce);
|
|
});
|
|
});
|