mirror of
https://github.com/status-im/consul.git
synced 2025-01-10 13:55:55 +00:00
99eb583ebc
* testing: replace most goe/verify.Values with require.Equal One difference between these two comparisons is that go/verify considers nil slices/maps to be equal to empty slices/maps, where as testify/require does not, and does not appear to provide any way to enable that behaviour. Because of this difference some expected values were changed from empty slices to nil slices, and some calls to verify.Values were left. * Remove github.com/pascaldekloe/goe/verify Reduce the number of assertion packages we use from 2 to 1
119 lines
3.2 KiB
Go
119 lines
3.2 KiB
Go
package config
|
|
|
|
import (
|
|
"flag"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// TestParseFlags tests whether command line flags are properly parsed
|
|
// into the Flags/File structure. It contains an example for every type
|
|
// that is parsed. It does not test the conversion into the final
|
|
// runtime configuration. See TestConfig for that.
|
|
func TestParseFlags(t *testing.T) {
|
|
tests := []struct {
|
|
args []string
|
|
flags Flags
|
|
err error
|
|
}{
|
|
{},
|
|
{
|
|
args: []string{`-bind`, `a`},
|
|
flags: Flags{Config: Config{BindAddr: pString("a")}},
|
|
},
|
|
{
|
|
args: []string{`-bootstrap`},
|
|
flags: Flags{Config: Config{Bootstrap: pBool(true)}},
|
|
},
|
|
{
|
|
args: []string{`-bootstrap=true`},
|
|
flags: Flags{Config: Config{Bootstrap: pBool(true)}},
|
|
},
|
|
{
|
|
args: []string{`-bootstrap=false`},
|
|
flags: Flags{Config: Config{Bootstrap: pBool(false)}},
|
|
},
|
|
{
|
|
args: []string{`-config-file`, `a`, `-config-dir`, `b`, `-config-file`, `c`, `-config-dir`, `d`},
|
|
flags: Flags{ConfigFiles: []string{"a", "b", "c", "d"}},
|
|
},
|
|
{
|
|
args: []string{`-datacenter`, `a`},
|
|
flags: Flags{Config: Config{Datacenter: pString("a")}},
|
|
},
|
|
{
|
|
args: []string{`-dns-port`, `1`},
|
|
flags: Flags{Config: Config{Ports: Ports{DNS: pInt(1)}}},
|
|
},
|
|
{
|
|
args: []string{`-grpc-port`, `1`},
|
|
flags: Flags{Config: Config{Ports: Ports{GRPC: pInt(1)}}},
|
|
},
|
|
{
|
|
args: []string{`-http-port`, `1`},
|
|
flags: Flags{Config: Config{Ports: Ports{HTTP: pInt(1)}}},
|
|
},
|
|
{
|
|
args: []string{`-https-port`, `1`},
|
|
flags: Flags{Config: Config{Ports: Ports{HTTPS: pInt(1)}}},
|
|
},
|
|
{
|
|
args: []string{`-serf-lan-port`, `1`},
|
|
flags: Flags{Config: Config{Ports: Ports{SerfLAN: pInt(1)}}},
|
|
},
|
|
{
|
|
args: []string{`-serf-wan-port`, `1`},
|
|
flags: Flags{Config: Config{Ports: Ports{SerfWAN: pInt(1)}}},
|
|
},
|
|
{
|
|
args: []string{`-server-port`, `1`},
|
|
flags: Flags{Config: Config{Ports: Ports{Server: pInt(1)}}},
|
|
},
|
|
{
|
|
args: []string{`-join`, `a`, `-join`, `b`},
|
|
flags: Flags{Config: Config{StartJoinAddrsLAN: []string{"a", "b"}}},
|
|
},
|
|
{
|
|
args: []string{`-node-meta`, `a:b`, `-node-meta`, `c:d`},
|
|
flags: Flags{Config: Config{NodeMeta: map[string]string{"a": "b", "c": "d"}}},
|
|
},
|
|
{
|
|
args: []string{`-bootstrap`, `true`},
|
|
flags: Flags{Config: Config{Bootstrap: pBool(true)}, Args: []string{"true"}},
|
|
},
|
|
{
|
|
args: []string{`-primary-gateway`, `foo.local`, `-primary-gateway`, `bar.local`},
|
|
flags: Flags{Config: Config{PrimaryGateways: []string{
|
|
"foo.local", "bar.local",
|
|
}}},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(strings.Join(tt.args, " "), func(t *testing.T) {
|
|
flags := Flags{}
|
|
fs := flag.NewFlagSet("", flag.ContinueOnError)
|
|
AddFlags(fs, &flags)
|
|
err := fs.Parse(tt.args)
|
|
if got, want := err, tt.err; !reflect.DeepEqual(got, want) {
|
|
t.Fatalf("got error %v want %v", got, want)
|
|
}
|
|
flags.Args = fs.Args()
|
|
|
|
// Normalize the expected value because require.Equal considers
|
|
// empty slices/maps and nil slices/maps to be different.
|
|
if len(tt.flags.Args) == 0 && flags.Args != nil {
|
|
tt.flags.Args = []string{}
|
|
}
|
|
if len(tt.flags.Config.NodeMeta) == 0 {
|
|
tt.flags.Config.NodeMeta = map[string]string{}
|
|
}
|
|
|
|
require.Equal(t, tt.flags, flags)
|
|
})
|
|
}
|
|
}
|