mirror of
https://github.com/status-im/consul.git
synced 2025-01-16 16:54:55 +00:00
33d0383779
This PR uses the excellent a11y-dialog to implement our modal functionality across the UI. This package covers all our a11y needs - overlay click and ESC to close, controlling aria-* attributes, focus trap and restore. It's also very small (1.6kb) and has good DOM and JS APIs and also seems to be widely used and well tested. There is one downside to using this, and that is: We made use of a very handy characteristic of the relationship between HTML labels and inputs in order to implement our modals previously. Adding a for="id" attribute to a label meant you can control an <input id="id" /> from anywhere else in the page without having to pass javascript objects around. It's just based on using the same string for the for attribute and the id attribute. This allowed us to easily open our login dialog with CSS from anywhere within the UI without having to manage passing around a javascript object/function/method in order to open the dialog. We've PRed #9813 which includes an approach which would make passing around JS modal object easier to do. But in the meantime we've added a little 'hack' here using an additional <input /> element and a change listener which allows us to keep this label/input characteristic of our old modals. I'd originally thought this would be a temporary amend in order to wait on #9813 but the more I think about it, the more I think its quite a nice thing to keep - so longer term we may/may not keep this.
91 lines
3.4 KiB
Gherkin
91 lines
3.4 KiB
Gherkin
@setupApplicationTest
|
|
Feature: dc / intentions / create: Intention Create
|
|
In order to define intentions
|
|
As a user
|
|
I want to visit the intention create page, fill in the form and hit the create button and see a success notification
|
|
@onlyNamespaceable
|
|
Scenario: with namespaces enabled
|
|
Given 1 datacenter model with the value "datacenter"
|
|
And 3 service models from yaml
|
|
---
|
|
- Name: web
|
|
Kind: ~
|
|
- Name: db
|
|
Kind: ~
|
|
- Name: cache
|
|
Kind: ~
|
|
---
|
|
When I visit the intention page for yaml
|
|
---
|
|
dc: datacenter
|
|
---
|
|
Then the url should be /datacenter/intentions/create
|
|
And the title should be "New Intention - Consul"
|
|
# Set source
|
|
And I click "[data-test-source-element] .ember-power-select-trigger"
|
|
And I type "web" into ".ember-power-select-search-input"
|
|
And I click ".ember-power-select-option:first-child"
|
|
Then I see the text "web" in "[data-test-source-element] .ember-power-select-selected-item"
|
|
# Set destination
|
|
And I click "[data-test-destination-element] .ember-power-select-trigger"
|
|
And I type "db" into ".ember-power-select-search-input"
|
|
And I click ".ember-power-select-option:first-child"
|
|
Then I see the text "db" in "[data-test-destination-element] .ember-power-select-selected-item"
|
|
# Specifically set deny
|
|
And I click ".value-deny"
|
|
And I submit
|
|
# TODO: When namespace is empty we expect *
|
|
# Then a PUT request was made to "/v1/connect/intentions/exact?source=@namespace%2Fweb&destination=@namespace%2Fdb&dc=datacenter" from yaml
|
|
# ---
|
|
# body:
|
|
# SourceName: web
|
|
# DestinationName: db
|
|
# Action: deny
|
|
# ---
|
|
Then the url should be /datacenter/intentions
|
|
And the title should be "Intentions - Consul"
|
|
And "[data-notification]" has the "notification-update" class
|
|
And "[data-notification]" has the "success" class
|
|
@notNamespaceable
|
|
Scenario: with namespaces disabled
|
|
Given 1 datacenter model with the value "datacenter"
|
|
And 3 service models from yaml
|
|
---
|
|
- Name: web
|
|
Kind: ~
|
|
- Name: db
|
|
Kind: ~
|
|
- Name: cache
|
|
Kind: ~
|
|
---
|
|
When I visit the intention page for yaml
|
|
---
|
|
dc: datacenter
|
|
---
|
|
Then the url should be /datacenter/intentions/create
|
|
And the title should be "New Intention - Consul"
|
|
# Set source
|
|
And I click "[data-test-source-element] .ember-power-select-trigger"
|
|
And I type "web" into ".ember-power-select-search-input"
|
|
And I click ".ember-power-select-option:first-child"
|
|
Then I see the text "web" in "[data-test-source-element] .ember-power-select-selected-item"
|
|
# Set destination
|
|
And I click "[data-test-destination-element] .ember-power-select-trigger"
|
|
And I type "db" into ".ember-power-select-search-input"
|
|
And I click ".ember-power-select-option:first-child"
|
|
Then I see the text "db" in "[data-test-destination-element] .ember-power-select-selected-item"
|
|
# Specifically set deny
|
|
And I click ".value-deny"
|
|
And I submit
|
|
Then a PUT request was made to "/v1/connect/intentions/exact?source=default%2Fweb&destination=default%2Fdb&dc=datacenter" from yaml
|
|
---
|
|
body:
|
|
SourceName: web
|
|
DestinationName: db
|
|
Action: deny
|
|
---
|
|
Then the url should be /datacenter/intentions
|
|
And the title should be "Intentions - Consul"
|
|
And "[data-notification]" has the "notification-update" class
|
|
And "[data-notification]" has the "success" class
|