mirror of
https://github.com/status-im/consul.git
synced 2025-01-10 13:55:55 +00:00
03a1a86dfe
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
104 lines
3.3 KiB
JavaScript
104 lines
3.3 KiB
JavaScript
import domEventSourceCallable from 'consul-ui/utils/dom/event-source/callable';
|
|
import EventTarget from 'consul-ui/utils/dom/event-target/rsvp';
|
|
|
|
import { module, test, skip } from 'qunit';
|
|
import { setupTest } from 'ember-qunit';
|
|
import sinon from 'sinon';
|
|
|
|
module('Integration | Utility | dom/event-source/callable', function (hooks) {
|
|
setupTest(hooks);
|
|
test('it dispatches messages', function (assert) {
|
|
assert.expect(1);
|
|
const EventSource = domEventSourceCallable(EventTarget);
|
|
const listener = sinon.stub();
|
|
const source = new EventSource(
|
|
function (configuration) {
|
|
return new Promise((resolve) => {
|
|
setTimeout(() => {
|
|
this.dispatchEvent({
|
|
type: 'message',
|
|
data: null,
|
|
});
|
|
resolve();
|
|
}, configuration.milliseconds);
|
|
});
|
|
},
|
|
{
|
|
milliseconds: 100,
|
|
}
|
|
);
|
|
source.addEventListener('message', function () {
|
|
listener();
|
|
});
|
|
return new Promise(function (resolve) {
|
|
setTimeout(function () {
|
|
source.close();
|
|
assert.equal(listener.callCount, 5);
|
|
resolve();
|
|
}, 550);
|
|
});
|
|
});
|
|
// TODO: rsvp timing seems to have completely changed
|
|
// this test tests an API that is not used within the code
|
|
// (using an EventSource with no callable)
|
|
// so we'll come back here to investigate
|
|
skip('it dispatches a single open event and closes when called with no callable', function (assert) {
|
|
assert.expect(4);
|
|
const EventSource = domEventSourceCallable(EventTarget, Promise);
|
|
const listener = sinon.stub();
|
|
const source = new EventSource();
|
|
source.addEventListener('open', function (e) {
|
|
assert.deepEqual(e.target, this);
|
|
assert.equal(e.target.readyState, 1);
|
|
listener();
|
|
});
|
|
return Promise.resolve().then(function () {
|
|
assert.ok(listener.calledOnce);
|
|
assert.equal(source.readyState, 2);
|
|
});
|
|
});
|
|
test('it dispatches a single open event, and calls the specified callable that can dispatch an event', function (assert) {
|
|
assert.expect(1);
|
|
const EventSource = domEventSourceCallable(EventTarget);
|
|
const listener = sinon.stub();
|
|
const source = new EventSource(function () {
|
|
return new Promise((resolve) => {
|
|
setTimeout(() => {
|
|
this.dispatchEvent({
|
|
type: 'message',
|
|
data: {},
|
|
});
|
|
this.close();
|
|
}, 190);
|
|
});
|
|
});
|
|
source.addEventListener('open', function () {
|
|
// open is called first
|
|
listener();
|
|
});
|
|
return new Promise(function (resolve) {
|
|
source.addEventListener('message', function () {
|
|
// message is called second
|
|
assert.ok(listener.calledOnce);
|
|
resolve();
|
|
});
|
|
});
|
|
});
|
|
test("it can be closed before the first tick, and therefore doesn't run", function (assert) {
|
|
assert.expect(4);
|
|
const EventSource = domEventSourceCallable(EventTarget);
|
|
const listener = sinon.stub();
|
|
const source = new EventSource();
|
|
assert.equal(source.readyState, 0);
|
|
source.close();
|
|
assert.equal(source.readyState, 2);
|
|
source.addEventListener('open', function (e) {
|
|
listener();
|
|
});
|
|
return Promise.resolve().then(function () {
|
|
assert.notOk(listener.called);
|
|
assert.equal(source.readyState, 2);
|
|
});
|
|
});
|
|
});
|