Michael Klein 03a1a86dfe
ui: chore - upgrade ember and friends (#14518)
* v3.20.2...v3.24.0

* Fix handle undefined outlet in route component

* Don't use template helper for optional modal.open

Using the optional-helper here will trigger a computation
in the same runloop error. This is because we are setting
the `modal`-property when the `<Ref>` component gets
rendered which will update the `this.modal`-property which
will then recompute the `optional`-helper leading to this
error.

Instead we will create an action that will call the `open`-method
on the modal when it is defined. This gets rid of the double
computation error as we will not access the modal property
twice in the same runloop when `modal` is getting set.

* Fix - fn needs to be passed function tab-nav

We create functions in the component file instead
so that fn-helper stops complaining about the
need to pass a function.

* Update ember-exam to 6.1 version

"Makes it compatible" with ember-qunit v5

* scheduleOnce setMaxHeight paged-collection

We need to schedule to get around double-computation error.

* Fix - model.data is removed from ember-data

This has been private API all along - we need to
work around the removal.

Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310

* Fix `propContains` instead of `deepEqual` policy

Recent model.data works differently than iterating attributes.
We use `propContains` instead of `deepEqual`. We are only
interested in the properties we assert against and match
the previous behavior with this change.

* Fix `propContains` instead of `deepEqual` token

* Better handling single-records repo test-helper

`model.data` has been removed we need to handle proxies and
model instances differently.

* Fix remaining repository tests with propContains

We don't want to match entire objects - we don't care
about properties we haven't defined in the assertion.

* Don't use template helper for optional modal.open

Using a template helper will give us a recomputation error -
we work around it by creating an explicit action on
the component instead.

* Await `I $verb the $pageObject object` step

* Fix no more customization ember-can

No need to customize, the helper handles destruction
fine on its own.

* Fix - don't pass `optional` functions to fn

We will declare the functions on the component instead.
This gives us the same behavior but no error from
`fn`, which expects a function to be passed.

* Fix - handle `undefined` state on validate modifier

StateChart can yield out an undefined `state` we need
to handle that in the validate modifier

* Fix linting errors tests directory

* Warn / turn off new ember linting issues

We will tackle them one by one and don't want to
autofix issues that could be dangerous to auto-fix.

* Auto-fix linting issues

* More linting configuration

* Fix remaining linting issues

* Fix linting issues new files after rebase

* ui: Remove ember-cli-uglify config now we are using terser (#14574)

Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
2022-09-15 09:43:17 +01:00

135 lines
4.6 KiB
JavaScript

import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { clearRender, render, waitUntil } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';
import Service, { inject as service } from '@ember/service';
import DataSourceComponent from 'consul-ui/components/data-source/index';
import { BlockingEventSource as RealEventSource } from 'consul-ui/utils/dom/event-source';
import sinon from 'sinon';
const createFakeBlockingEventSource = function () {
const EventSource = function (cb) {
this.readyState = 1;
this.source = cb;
};
const o = EventSource.prototype;
[
'addEventListener',
'removeEventListener',
'dispatchEvent',
'close',
'open',
'getCurrentEvent',
].forEach(function (item) {
o[item] = function () {};
});
return EventSource;
};
const BlockingEventSource = createFakeBlockingEventSource();
module('Integration | Component | data-source', function (hooks) {
setupRenderingTest(hooks);
hooks.beforeEach(function () {
this.actions = {};
this.send = (actionName, ...args) => this.actions[actionName].apply(this, args);
});
test('open and closed are called correctly when the src is changed', async function (assert) {
// Set any properties with this.set('myProperty', 'value');
// Handle any actions with this.set('myAction', function(val) { ... });
assert.expect(9);
const close = sinon.stub();
const open = sinon.stub();
const addEventListener = sinon.stub();
const removeEventListener = sinon.stub();
let count = 0;
const fakeService = class extends Service {
close = close;
open(uri, obj) {
open(uri);
const source = new BlockingEventSource();
source.getCurrentEvent = function () {
return { data: uri };
};
source.addEventListener = addEventListener;
source.removeEventListener = removeEventListener;
return source;
}
};
this.owner.register('service:data-source/fake-service', fakeService);
this.owner.register(
'component:data-source',
class extends DataSourceComponent {
@service('data-source/fake-service') dataSource;
}
);
this.actions.change = (data) => {
count++;
switch (count) {
case 1:
assert.equal(data, 'a', 'change was called first with "a"');
setTimeout(() => {
this.set('src', 'b');
}, 0);
break;
case 2:
assert.equal(data, 'b', 'change was called second with "b"');
break;
}
};
this.set('src', 'a');
await render(hbs`<DataSource @src={{src}} @onchange={{action "change" value="data"}} />`);
assert.equal(this.element.textContent.trim(), '');
await waitUntil(() => {
return close.calledTwice;
});
assert.ok(open.calledTwice, 'open is called when src is set');
assert.ok(close.calledTwice, 'close is called as open is called');
await clearRender();
await waitUntil(() => {
return close.calledThrice;
});
assert.ok(open.calledTwice, 'open is _still_ only called when src is set');
assert.ok(close.calledThrice, 'close is called an extra time as the component is destroyed');
assert.equal(addEventListener.callCount, 4, 'all event listeners were added');
assert.equal(removeEventListener.callCount, 4, 'all event listeners were removed');
});
test('error actions are triggered when errors are dispatched', async function (assert) {
const source = new RealEventSource();
const error = sinon.stub();
const close = sinon.stub();
const fakeService = class extends Service {
close = close;
open(uri, obj) {
source.getCurrentEvent = function () {
return {};
};
return source;
}
};
this.owner.register('service:data-source/fake-service', fakeService);
this.owner.register(
'component:data-source',
class extends DataSourceComponent {
@service('data-source/fake-service') dataSource;
}
);
this.actions.change = (data) => {
source.dispatchEvent({ type: 'error', error: {} });
};
this.actions.error = error;
await render(
hbs`<DataSource @src="" @onchange={{action "change" value="data"}} @onerror={{action "error" value="error"}} />`
);
await waitUntil(() => {
return error.calledOnce;
});
assert.ok(error.calledOnce, 'error action was called');
assert.ok(close.calledOnce, 'close was called before the open');
await clearRender();
assert.ok(close.calledTwice, 'close was also called when the component is destroyed');
});
});