mirror of
https://github.com/status-im/consul.git
synced 2025-01-24 12:40:17 +00:00
03a1a86dfe
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
86 lines
2.0 KiB
JavaScript
86 lines
2.0 KiB
JavaScript
import { runInDebug } from '@ember/debug';
|
|
|
|
export const walk = function (routes) {
|
|
const keys = Object.keys(routes);
|
|
keys.forEach((item, i) => {
|
|
if (item === '_options') {
|
|
return;
|
|
}
|
|
if (routes[item] === null) {
|
|
return;
|
|
}
|
|
const options = routes[item]._options;
|
|
let cb;
|
|
if (Object.keys(routes[item]).length > 1) {
|
|
cb = function () {
|
|
walk.apply(this, [routes[item]]);
|
|
};
|
|
}
|
|
this.route(item, options, cb);
|
|
});
|
|
if (typeof routes.index === 'undefined') {
|
|
routes.index = {
|
|
_options: {
|
|
path: '',
|
|
},
|
|
};
|
|
}
|
|
};
|
|
|
|
/**
|
|
* Drop in for the Router.map callback e.g. `Router.map(walk(routes))`
|
|
* Uses { walk } to recursively walk through a JSON object of routes
|
|
* and use `Router.route` to define your routes for your ember application
|
|
*
|
|
* @param {object} routes - JSON representation of routes
|
|
*/
|
|
export default function (routes) {
|
|
return function () {
|
|
walk.apply(this, [routes]);
|
|
};
|
|
}
|
|
|
|
export let dump = (routes) => {};
|
|
|
|
runInDebug(() => {
|
|
const indent = function (num) {
|
|
return Array(num).fill(' ', 0, num).join('');
|
|
};
|
|
/**
|
|
* String dumper to produce Router.map code
|
|
* Uses { walk } to recursively walk through a JSON object of routes
|
|
* to produce the code necessary to define your routes for your ember application
|
|
*
|
|
* @param {object} routes - JSON representation of routes
|
|
* @example `console.log(dump(routes));`
|
|
*/
|
|
dump = function (routes) {
|
|
let level = 2;
|
|
const obj = {
|
|
out: '',
|
|
route: function (name, options, cb) {
|
|
this.out += `${indent(level)}this.route('${name}', ${JSON.stringify(options)}`;
|
|
if (cb) {
|
|
level++;
|
|
this.out += `, function() {
|
|
`;
|
|
cb.apply(this, []);
|
|
level--;
|
|
this.out += `${indent(level)}});
|
|
`;
|
|
} else {
|
|
this.out += ');';
|
|
}
|
|
this.out += `
|
|
`;
|
|
},
|
|
};
|
|
walk.apply(obj, [routes]);
|
|
return `Router.map(
|
|
function() {
|
|
${obj.out}
|
|
}
|
|
);`;
|
|
};
|
|
});
|