mirror of
https://github.com/status-im/consul.git
synced 2025-02-09 12:25:17 +00:00
03a1a86dfe
* v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>
92 lines
2.7 KiB
JavaScript
92 lines
2.7 KiB
JavaScript
import Component from '@ember/component';
|
|
import { inject as service } from '@ember/service';
|
|
import { get, set } from '@ember/object';
|
|
|
|
const replace = function (
|
|
obj,
|
|
prop,
|
|
value,
|
|
destroy = (prev = null, value) => (typeof prev === 'function' ? prev() : null)
|
|
) {
|
|
const prev = obj[prop];
|
|
if (prev !== value) {
|
|
destroy(prev, value);
|
|
}
|
|
return set(obj, prop, value);
|
|
};
|
|
export default Component.extend({
|
|
tagName: '',
|
|
dom: service('dom'),
|
|
logger: service('logger'),
|
|
data: service('data-source/service'),
|
|
closeOnDestroy: true,
|
|
onerror: function (e) {
|
|
this.logger.execute(e.error);
|
|
},
|
|
init: function () {
|
|
this._super(...arguments);
|
|
this._listeners = this.dom.listeners();
|
|
},
|
|
willDestroyElement: function () {
|
|
if (this.closeOnDestroy) {
|
|
this.actions.close.apply(this, []);
|
|
}
|
|
this._listeners.remove();
|
|
this._super(...arguments);
|
|
},
|
|
didReceiveAttrs: function () {
|
|
this._super(...arguments);
|
|
// only close and reopen if the uri changes
|
|
// otherwise this will fire whenever the proxies data changes
|
|
if (get(this, 'src.configuration.uri') !== get(this, 'source.configuration.uri')) {
|
|
this.actions.open.apply(this, []);
|
|
}
|
|
},
|
|
actions: {
|
|
open: function () {
|
|
replace(this, 'source', this.data.open(this.src, this), (prev, source) => {
|
|
// Makes sure any previous source (if different) is ALWAYS closed
|
|
if (typeof prev !== 'undefined') {
|
|
this.data.close(prev, this);
|
|
}
|
|
});
|
|
replace(this, 'proxy', this.src, (prev, proxy) => {
|
|
// Makes sure any previous proxy (if different) is ALWAYS closed
|
|
if (typeof prev !== 'undefined') {
|
|
prev.destroy();
|
|
}
|
|
});
|
|
const error = (err) => {
|
|
try {
|
|
const error = get(err, 'error.errors.firstObject');
|
|
if (get(error || {}, 'status') !== '429') {
|
|
this.onerror(err);
|
|
}
|
|
this.logger.execute(err);
|
|
} catch (err) {
|
|
this.logger.execute(err);
|
|
}
|
|
};
|
|
// set up the listeners (which auto cleanup on component destruction)
|
|
// we only need errors here as this only uses proxies which
|
|
// automatically update their data
|
|
const remove = this._listeners.add(this.source, {
|
|
error: (e) => {
|
|
error(e);
|
|
},
|
|
});
|
|
replace(this, '_remove', remove);
|
|
},
|
|
close: function () {
|
|
if (typeof this.source !== 'undefined') {
|
|
this.data.close(this.source, this);
|
|
replace(this, '_remove', undefined);
|
|
set(this, 'source', undefined);
|
|
}
|
|
if (typeof this.proxy !== 'undefined') {
|
|
this.proxy.destroy();
|
|
}
|
|
},
|
|
},
|
|
});
|