consul

Commit Graph

Author	SHA1	Message	Date
Daniel Nephin	6dc6507abc	Merge pull request #8469 from hashicorp/dnephin/config-source config: make Source an interface to avoid the marshal/unmarshal cycle in auto-config	2020-08-26 17:00:51 -04:00
Daniel Nephin	058114e82e	Merge pull request #7762 from hashicorp/dnephin/warn-on-unknown-service-file config: warn if a config file is being skipped because of its file extension	2020-06-17 15:21:34 -04:00
Pierre Souchay	be1c5c4b48	config: validate system limits against limits.http_max_conns_per_client (#7434 ) I spent some time today on my local Mac to figure out why Consul 1.6.3+ was not accepting limits.http_max_conns_per_client. This adds an explicit check on number of file descriptors to be sure it might work (this is no guarantee as if many clients are reaching the agent, it might consume even more file descriptors) Anyway, many users are fighting with RLIMIT_NOFILE, having a clear message would allow them to figure out what to fix. Example of message (reload or start): ``` 2020-03-11T16:38:37.062+0100 [ERROR] agent: Error starting agent: error="system allows a max of 512 file descriptors, but limits.http_max_conns_per_client: 8192 needs at least 8212" ```	2020-04-02 09:22:17 +02:00

Author

SHA1

Message

Date

Daniel Nephin

6dc6507abc

Merge pull request #8469 from hashicorp/dnephin/config-source

config: make Source an interface to avoid the marshal/unmarshal cycle in auto-config

2020-08-26 17:00:51 -04:00

Daniel Nephin

058114e82e

Merge pull request #7762 from hashicorp/dnephin/warn-on-unknown-service-file

config: warn if a config file is being skipped because of its file extension

2020-06-17 15:21:34 -04:00

Pierre Souchay

be1c5c4b48

config: validate system limits against limits.http_max_conns_per_client (#7434 )

I spent some time today on my local Mac to figure out why Consul 1.6.3+
was not accepting limits.http_max_conns_per_client.

This adds an explicit check on number of file descriptors to be sure
it might work (this is no guarantee as if many clients are reaching
the agent, it might consume even more file descriptors)

Anyway, many users are fighting with RLIMIT_NOFILE, having a clear
message would allow them to figure out what to fix.

Example of message (reload or start):

```
2020-03-11T16:38:37.062+0100 [ERROR] agent: Error starting agent: error="system allows a max of 512 file descriptors, but limits.http_max_conns_per_client: 8192 needs at least 8212"
```

2020-04-02 09:22:17 +02:00

3 Commits