Commit Graph

22 Commits

Author SHA1 Message Date
Frank Schroeder 80c990b449 test: Retry more aggressively 2017-04-27 10:34:30 -07:00
Frank Schroeder 3e00e36f41 golint: Untangle if blocks with return in else 2017-04-25 09:26:13 -07:00
Frank Schroeder eddb1af603 Remove duplicate constants
This patch removes duplicate internal copies of constants in the structs
package which are also defined in the api package. The api.KVOp type
with all its values for the TXN endpoint and the api.HealthXXX constants
are now used throughout the codebase.

This resulted in some circular dependencies in the testutil package
which have been resolved by copying code and constants and moving the
WaitForLeader function into a separate testrpc package.
2017-04-20 09:54:49 -07:00
James Phillips 4e7064023f
Makes WaitForResult always return an error if it times out. 2017-03-23 20:04:39 -07:00
Seth Vargo 3d830b3676
Reduce coupling with testing.T
This reduces the coupling with testing.T, allowing many of the
server's startup-related functions to return an error. This makes them
more re-usable.
2017-03-23 18:41:19 -04:00
James Phillips dcff5137f9
Adds a little wait after we get the event we were seeking. 2017-01-26 22:15:54 -08:00
James Phillips 8493d239ac
Run the waited-for function before sleeping, and ramp up the sleep exponentially. 2017-01-26 17:11:16 -08:00
James Phillips 8c33ddbee2
Drops the unit test wait time back down and turns initial wait into blocking query. 2017-01-26 16:57:44 -08:00
James Phillips 1f903547b5 Bumps the wait even more. 2017-01-26 09:15:29 -08:00
James Phillips 86368a467e Bumps the wait a little more. 2017-01-26 08:20:43 -08:00
James Phillips b4bbd2f441 Adds more time to WaitForResult.
The last change here made the time overall theoretically the same, but the overhead of running so quickly before probably meant that we were spending longer. Tests seemed marginal in Travis so doubling this to see how things go.
2017-01-26 08:04:48 -08:00
Seth Vargo e3a4b2128b
Sleep for longer, but try less often
This fixes an issue where the system can quickly run out of file
descriptors because they are accumulating faster than the kernel can
release them.
2017-01-26 00:13:34 -05:00
Armon Dadgar 1b15415616 testutil: Using the correct RPC struct 2014-06-10 19:12:36 -07:00
Nelson Elhage 2080122f38 WaitForLeader: Also wait for a non-zero index.
On my laptop, I'm currently seeing a huge number of intermittent test
failures all related to WaitForLeader returning after the test node has
become a leader, but before it has actually finished starting up, in
particular, performing the serf/Raft reconciliation.

Waiting for the index to become nonzero makes the tests pass reliably,
by also blocking until the new leader has started committing state.
2014-05-26 13:26:42 -07:00
Armon Dadgar 14be60aaca gofmt 2014-05-20 16:25:29 -07:00
William Tisäter 76d9fa255b Speed up test runs in `WaitForResult` 2014-05-09 03:00:43 +02:00
William Tisäter e1d111a43d Increase timeout for `WaitForResult` 2014-05-09 02:43:48 +02:00
William Tisäter 78145ecfd5 Require datacenter argument for `WaitForLeader` 2014-05-09 01:17:35 +02:00
William Tisäter c8168bd8fe Drop client arguments from `WaitForLeader` 2014-05-07 23:41:14 +02:00
William Tisäter aa00bfff7d Fix `TestCatalogListNodes_StaleRaad` with `WaitForLeader` 2014-05-07 13:53:29 +02:00
William Tisäter f1b9dbe5c3 Add `testutils.WaitForLeader` and truly wait 2014-05-07 11:43:42 +02:00
William Tisäter 028bc7e1b4 Proof of concept using `WaitForResult` in tests 2014-05-07 02:48:25 +02:00