Paul Banks
c501468d78
Fix panic bug in snapshot inspect ( #10091 )
...
* Fix panic bug in snapshot inspect
* Add changelog entry
* Update .changelog/10091.txt
* Undo bad GitHub UI merge
* Undo bad GitHub UI merge
2021-04-23 20:48:10 +01:00
Paul Banks
d717d2cdc4
CLI: Allow snapshot inspect to work on internal raft snapshots directly. ( #10089 )
...
* CLI: Add support for reading internal raft snapshots to snapshot inspect
* Add snapshot inspect test for raw state files
* Add changelog entry
* Update .changelog/10089.txt
2021-04-23 16:17:08 +01:00
Daniel Nephin
b9e60c0775
testing: skip slow tests with -short
...
Add a skip condition to all tests slower than 100ms.
This change was made using `gotestsum tool slowest` with data from the
last 3 CI runs of master.
See https://github.com/gotestyourself/gotestsum#finding-and-skipping-slow-tests
With this change:
```
$ time go test -count=1 -short ./agent
ok github.com/hashicorp/consul/agent 0.743s
real 0m4.791s
$ time go test -count=1 -short ./agent/consul
ok github.com/hashicorp/consul/agent/consul 4.229s
real 0m8.769s
```
2020-12-07 13:42:55 -05:00
Joel Watson
182333b645
Fix some minor wording issues
2020-11-11 11:33:38 -06:00
Joel Watson
94689b6ecd
Back out implicit -kvdetails functionality
2020-11-11 10:46:51 -06:00
Joel Watson
0d48559416
Length check is required here
...
If one isn't included, then the nil check in the formatter never fails due to an empty slice being passed in, which causes the kv output to always get printed.
2020-11-11 10:44:55 -06:00
Joel Watson
48a358df1b
Remove trailing tabs from output
2020-11-10 16:40:23 -06:00
Joel Watson
491f2f0a57
Add more func comments
2020-11-10 16:40:12 -06:00
Joel Watson
99ec1febcc
Move kvDetails default logic
2020-11-10 16:39:40 -06:00
Joel Watson
ea804e57b4
Check for nil rather than length
2020-11-10 16:39:12 -06:00
Joel Watson
7aebd179de
Update tests for new flag names
2020-11-10 11:18:21 -06:00
Joel Watson
40a8681816
Allow omission of -kvdetails if another -kv* flag is set
2020-11-10 10:55:30 -06:00
Joel Watson
1ef259b093
Rename params to better reflect their purpose
2020-11-10 10:44:09 -06:00
Joel Watson
5ad0db73c8
Make docs for params clearer
2020-11-10 10:35:24 -06:00
Joel Watson
fbe8503258
Break KV portion of enchance into separate func
2020-11-10 10:29:49 -06:00
Joel Watson
5dd703a62a
Move KV stat gen to separate func
2020-11-10 10:09:03 -06:00
Joel Watson
aabb537aed
Pull sorting into separate function
2020-11-05 16:25:21 -06:00
Joel Watson
3ee20d500a
Refactor to reduce how many vars are being passed around
2020-11-05 14:26:47 -06:00
Joel Watson
1a50aa023a
Fallback to alphabetic sorting if size is equal
2020-11-05 11:02:02 -06:00
Joel Watson
be2a212d75
Add tests for new snapshot inspect flags
2020-11-05 11:01:44 -06:00
Joel Watson
5f5b49955c
Update snapshot inspect formatter test
2020-11-05 10:40:02 -06:00
Joel Watson
eafc593d0f
Make key breakdown total size accurate
2020-11-05 10:32:23 -06:00
Joel Watson
4bf70dd857
Cleanup formatter
2020-11-04 14:36:42 -06:00
Joel Watson
208d6ebd95
Get JSON formatting working
2020-11-04 14:04:17 -06:00
Joel Watson
e7a88d4a30
This ended up not being used.
2020-11-04 10:30:38 -06:00
Joel Watson
262fb3a0c3
Add snapshot inspect filter param
2020-11-04 10:11:20 -06:00
Joel Watson
10f325dc81
Initial stab at snapshot inspect key breakdown
2020-11-03 18:00:44 -06:00
s-christoff
79ce24e9fc
cli: Add JSON and Pretty Print formatting for `consul snapshot inspect` ( #9006 )
2020-10-29 11:31:14 -05:00
s-christoff
9bb348c6c7
Enhance the output of consul snapshot inspect ( #8787 )
2020-10-09 14:57:29 -05:00
Daniel Nephin
d68edcecf4
testing: Remove all the defer os.Removeall
...
Now that testutil uses t.Cleanup to remove the directory the caller no longer has to manage
the removal
2020-08-14 19:58:53 -04:00
R.B. Boyer
4d083103e2
fix some flaky snapshot tests ( #8015 )
2020-06-03 14:18:52 -05:00
R.B. Boyer
b989967791
cli: ensure that 'snapshot save' is fsync safe and also only writes to the requested file on success ( #7698 )
2020-04-24 17:34:47 -05:00
R.B. Boyer
5f1518c37c
cli: fix usage of gzip.Reader to better detect corrupt snapshots during save/restore ( #7697 )
2020-04-24 17:18:56 -05:00
Daniel Nephin
475659a132
Remove name from NewTestAgent
...
Using:
git grep -l 'NewTestAgent(t, t.Name(),' | \
xargs sed -i -e 's/NewTestAgent(t, t.Name(),/NewTestAgent(t,/g'
2020-03-31 16:13:44 -04:00
Jeff Mitchell
4243c3ae42
Move internal/ to sdk/ ( #5568 )
...
* Move internal/ to sdk/
* Add a readme to the SDK folder
2019-03-27 08:54:56 -04:00
Jeff Mitchell
47c390025b
Convert to Go Modules ( #5517 )
...
* First conversion
* Use serf 0.8.2 tag and associated updated deps
* * Move freeport and testutil into internal/
* Make internal/ its own module
* Update imports
* Add replace statements so API and normal Consul code are
self-referencing for ease of development
* Adapt to newer goe/values
* Bump to new cleanhttp
* Fix ban nonprintable chars test
* Update lock bad args test
The error message when the duration cannot be parsed changed in Go 1.12
(ae0c435877d3aacb9af5e706c40f9dddde5d3e67). This updates that test.
* Update another test as well
* Bump travis
* Bump circleci
* Bump go-discover and godo to get rid of launchpad dep
* Bump dockerfile go version
* fix tar command
* Bump go-cleanhttp
2019-03-26 17:04:58 -04:00
Matt Keeler
766d771017
Pass a testing.T into NewTestAgent and TestAgent.Start ( #5342 )
...
This way we can avoid unnecessary panics which cause other tests not to run.
This doesn't remove all the possibilities for panics causing other tests not to run, it just fixes the TestAgent
2019-02-14 10:59:14 -05:00
Josh Soref
94835a2715
Spelling ( #3958 )
...
* spelling: another
* spelling: autopilot
* spelling: beginning
* spelling: circonus
* spelling: default
* spelling: definition
* spelling: distance
* spelling: encountered
* spelling: enterprise
* spelling: expands
* spelling: exits
* spelling: formatting
* spelling: health
* spelling: hierarchy
* spelling: imposed
* spelling: independence
* spelling: inspect
* spelling: last
* spelling: latest
* spelling: client
* spelling: message
* spelling: minimum
* spelling: notify
* spelling: nonexistent
* spelling: operator
* spelling: payload
* spelling: preceded
* spelling: prepared
* spelling: programmatically
* spelling: required
* spelling: reconcile
* spelling: responses
* spelling: request
* spelling: response
* spelling: results
* spelling: retrieve
* spelling: service
* spelling: significantly
* spelling: specifies
* spelling: supported
* spelling: synchronization
* spelling: synchronous
* spelling: themselves
* spelling: unexpected
* spelling: validations
* spelling: value
2018-03-19 16:56:00 +00:00
Kyle Havlovitz
921d2e1469
Fix a panic in snapshot inspect command
2017-10-30 14:51:08 -07:00
Frank Schroeder
b3292d13fb
commands: get HTTP API flags for usage automatically
2017-10-18 00:08:45 +02:00
Frank Schroeder
1b026de1db
commands: run all tests in parallel (again)
2017-10-18 00:08:45 +02:00
Frank Schroeder
56b24d3d4f
commands: cleanup help and synopsis.
...
* move Help and Synopsis to bottom
* make help and synopsis constants
* make sure help output is formatted
2017-10-18 00:08:45 +02:00
Frank Schroeder
d54a5ef8d8
commands: do not run cmd tests in parallel
...
Package level parallelization is sufficient.
2017-10-18 00:08:45 +02:00
Frank Schroeder
84a82cff3d
commands: cleanup test names
2017-10-18 00:08:45 +02:00
Frank Schroeder
51799e5d23
commands: move snapshot subcommands to subdirs
2017-10-18 00:08:45 +02:00
Frank Schroeder
c8992cbe28
commands: move snapshot command to separate pkg
2017-10-18 00:08:45 +02:00