5c77c59501
local state: refactor TestAgentAntiEntropy_EnableTagOverride
...
Make intent clearer by being more explicit and adding some comments.
Use verify.Values to compare service entries.
2017-10-23 10:56:04 +02:00
524981f367
local state: fix TestAgentAntiEntropy_EnableTagOverride
...
The test had a race condition where it relied on the first service to be
synced to the remote catalog which sometimes failed.
2017-10-23 10:56:04 +02:00
1181aaee6a
local state: rename tests
2017-10-23 10:56:04 +02:00
1602ac56b5
local state: drop retry loops from tests
...
Since the tests are now using synchronous calls for state syncing
we no longer need to use retry loops to wait for the changes to
propagate.
2017-10-23 10:56:04 +02:00
71c74e62c7
local state: fix anti-entropy state tests
...
The anti-entropy tests relied on the side-effect of the StartSync()
method to perform a full sync instead of a partial sync. This lead to
multiple anti-entropy go routines being started unnecessary retry loops.
This change changes the behavior to perform synchronous full syncs when
necessary removing the need for all of the time.Sleep and most of the
retry loops.
2017-10-23 10:56:04 +02:00
37b95ef98e
local state: fix test with updated error message
2017-10-23 10:56:04 +02:00
b803bf3091
local state: tests compile
2017-10-23 10:56:03 +02:00
0a9ac9749e
local state: replace multi-map state with structs
...
The state of the service and health check records was spread out over
multiple maps guarded by a single lock. Access to the maps has to happen
in a coordinated effort and the tests often violated this which made
them brittle and racy.
This patch replaces the multiple maps with a single one for both checks
and services to make the code less fragile.
This is also necessary since moving the local state into its own package
creates circular dependencies for the tests. To avoid this the tests can
no longer access internal data structures which they should not be doing
in the first place.
The tests still don't compile but this is a ncessary step in that
direction.
2017-10-23 10:56:03 +02:00
6027a9e2a5
local state: move to separate package
...
This patch moves the local state to a separate package to further
decouple it from the agent code.
The code compiles but the tests do not yet.
2017-10-23 10:56:03 +02:00
67a0689f71
Revert "local state: move to separate package"
...
This reverts commit d447e823c6
2017-10-23 10:08:34 +02:00
623e07760a
Revert "local state: replace multi-map state with structs"
...
This reverts commit ccbae7da5b
2017-10-23 10:08:34 +02:00
9ed4b2d631
Revert "local state: tests compile"
...
This reverts commit 1af52bf7be
2017-10-23 10:08:34 +02:00
5ae4c52ca6
Revert "local state: fix test with updated error message"
...
This reverts commit e9149f64d9
2017-10-23 10:08:34 +02:00
67cdfc038e
Revert "local state: fix anti-entropy state tests"
...
This reverts commit f8e20cd996
2017-10-23 10:08:34 +02:00
556bf3f85d
Revert "local state: drop retry loops from tests"
...
This reverts commit 2bdba8ab06
2017-10-23 10:08:34 +02:00
a3aa864d5b
Revert "local state: rename tests"
...
This reverts commit ff62eaf063
2017-10-23 10:08:34 +02:00
39615cb57b
Revert "local state: fix TestAgentAntiEntropy_EnableTagOverride"
...
This reverts commit 86f7ea6013
2017-10-23 10:08:34 +02:00
9fdea75d99
Revert "local state: refactor TestAgentAntiEntropy_EnableTagOverride"
...
This reverts commit c28e23eac8
2017-10-23 10:08:33 +02:00
46641e44d9
Revert "local state: address review comments"
...
This reverts commit 1d315075b1
2017-10-23 10:08:33 +02:00
abd83f2d28
Revert "local state: update comments"
...
This reverts commit 42188164f8
2017-10-23 10:08:33 +02:00
c6e441dd60
Revert "local state: update documentation of updateSyncState"
...
This reverts commit e86521e637
2017-10-23 10:08:33 +02:00
648b4da4f8
Revert "local state: move Metadata methods together"
...
This reverts commit 9bc8127728
2017-10-23 10:08:33 +02:00
fa45a6a547
Revert "local state: rename Add{Check,Service}State to Set{Check,Service}State"
...
This reverts commit 9280841a80
2017-10-23 10:08:33 +02:00
d6f52d9ed1
Revert "local state: use synchronized access to internal maps"
...
This reverts commit 39a2d8d25e
2017-10-23 10:08:32 +02:00
4e862d126d
Revert "local state: clone check to avoid side effect"
...
This reverts commit af1243c725
2017-10-23 10:08:32 +02:00
42af4cdc70
Revert "local state: make test more robust"
...
This reverts commit f9267380db
2017-10-23 10:08:32 +02:00
4ae8317fbf
Revert "local state: remove stale comment"
...
This reverts commit 35f4acdddc
2017-10-23 10:08:32 +02:00
223fae7d92
Revert "fix go vet issue"
...
This reverts commit 078e50b635
2017-10-23 10:00:26 +02:00
078e50b635
fix go vet issue
2017-10-23 08:13:52 +02:00
35f4acdddc
local state: remove stale comment
2017-10-23 08:03:18 +02:00
f9267380db
local state: make test more robust
2017-10-23 08:03:18 +02:00
af1243c725
local state: clone check to avoid side effect
2017-10-23 08:03:18 +02:00
39a2d8d25e
local state: use synchronized access to internal maps
2017-10-23 08:03:18 +02:00
9280841a80
local state: rename Add{Check,Service}State to Set{Check,Service}State
2017-10-23 08:03:18 +02:00
9bc8127728
local state: move Metadata methods together
2017-10-23 08:03:18 +02:00
e86521e637
local state: update documentation of updateSyncState
2017-10-23 08:03:18 +02:00
42188164f8
local state: update comments
2017-10-23 08:03:18 +02:00
1d315075b1
local state: address review comments
...
* move non-blocking notification mechanism into ae.Trigger
* move Pause/Resume into separate type
2017-10-23 08:03:18 +02:00
c28e23eac8
local state: refactor TestAgentAntiEntropy_EnableTagOverride
...
Make intent clearer by being more explicit and adding some comments.
Use verify.Values to compare service entries.
2017-10-23 08:03:18 +02:00
86f7ea6013
local state: fix TestAgentAntiEntropy_EnableTagOverride
...
The test had a race condition where it relied on the first service to be
synced to the remote catalog which sometimes failed.
2017-10-23 08:03:18 +02:00
ff62eaf063
local state: rename tests
2017-10-23 08:03:18 +02:00
2bdba8ab06
local state: drop retry loops from tests
...
Since the tests are now using synchronous calls for state syncing
we no longer need to use retry loops to wait for the changes to
propagate.
2017-10-23 08:03:18 +02:00
f8e20cd996
local state: fix anti-entropy state tests
...
The anti-entropy tests relied on the side-effect of the StartSync()
method to perform a full sync instead of a partial sync. This lead to
multiple anti-entropy go routines being started unnecessary retry loops.
This change changes the behavior to perform synchronous full syncs when
necessary removing the need for all of the time.Sleep and most of the
retry loops.
2017-10-23 08:03:18 +02:00
e9149f64d9
local state: fix test with updated error message
2017-10-23 08:03:18 +02:00
1af52bf7be
local state: tests compile
2017-10-23 08:03:18 +02:00
ccbae7da5b
local state: replace multi-map state with structs
...
The state of the service and health check records was spread out over
multiple maps guarded by a single lock. Access to the maps has to happen
in a coordinated effort and the tests often violated this which made
them brittle and racy.
This patch replaces the multiple maps with a single one for both checks
and services to make the code less fragile.
This is also necessary since moving the local state into its own package
creates circular dependencies for the tests. To avoid this the tests can
no longer access internal data structures which they should not be doing
in the first place.
The tests still don't compile but this is a ncessary step in that
direction.
2017-10-23 08:03:18 +02:00
d447e823c6
local state: move to separate package
...
This patch moves the local state to a separate package to further
decouple it from the agent code.
The code compiles but the tests do not yet.
2017-10-23 08:03:18 +02:00
Frank Schroeder