consul

Author SHA1 Message Date

Author	SHA1	Message	Date
Pierre Souchay	9dc7194321	Bump version of miekg/dns to 1.0.4 See https://github.com/hashicorp/consul/issues/3977 While trying to improve furthermore #3948 (This pull request is still valid since we are not using Compression to compute the result anyway). I saw a strange behaviour of dns library. Basically, msg.Len() and len(msg.Pack()) disagree on Message len. Thus, calculation of DNS response is false consul relies on msg.Len() instead of the result of Pack() This is linked to miekg/dns#453 and a fix has been provided with miekg/dns#454 Would it be possible to upgrade miekg/dns to a more recent function ? Consul might for instance upgrade to a post 1.0 release such as https://github.com/miekg/dns/releases/tag/v1.0.4	2018-03-28 10:23:57 -05:00
preetapan	285dbe2d76	Vendor update miekg/dns to pick up bugfixes and features (#3547 )	2017-10-06 11:34:41 -07:00
James Phillips	43564eea00	Updates miekg/dns. `75e6e86cc6...db96a2b759`	2016-08-09 16:27:11 -07:00

Pierre Souchay

9dc7194321

Bump version of miekg/dns to 1.0.4

See https://github.com/hashicorp/consul/issues/3977

While trying to improve furthermore #3948 (This pull request is still valid since we are not using Compression to compute the result anyway).

I saw a strange behaviour of dns library.
Basically, msg.Len() and len(msg.Pack()) disagree on Message len.

Thus, calculation of DNS response is false consul relies on msg.Len() instead of the result of Pack()

This is linked to miekg/dns#453 and a fix has been provided with miekg/dns#454

Would it be possible to upgrade miekg/dns to a more recent function ?

Consul might for instance upgrade to a post 1.0 release such as https://github.com/miekg/dns/releases/tag/v1.0.4

2018-03-28 10:23:57 -05:00

preetapan 285dbe2d76 Vendor update miekg/dns to pick up bugfixes and features (#3547 ) 2017-10-06 11:34:41 -07:00

James Phillips

43564eea00

Updates miekg/dns.

75e6e86cc6...db96a2b759

2016-08-09 16:27:11 -07:00

3 Commits