Commit Graph

5997 Commits

Author SHA1 Message Date
James Phillips 3baa703d02 Merge pull request #3077 from jwasinger/issue-2850
Prevent Session.Destroy from leaving open TCP connections
2017-06-02 21:43:55 -07:00
James Phillips b0b5df579f
Cleans up an unrelated vet error. 2017-06-02 21:07:15 -07:00
James Phillips b4b5036dfb
Adds back the port shuffle on agent start retries. 2017-06-02 20:53:20 -07:00
James Phillips 9c8f656a29
Takes parallel away from some currently flaky tests. 2017-06-02 18:07:27 -07:00
James Phillips 86003d91a2 Merge pull request #3104 from hashicorp/bad-shutdown
Cleans up incorrect router shutdown.
2017-06-02 16:38:08 -07:00
James Phillips 798120d0c4
Cleans up incorrect router shutdown.
Fixes #3102.
2017-06-02 16:33:48 -07:00
James Phillips da9ab5985f Merge pull request #3103 from hashicorp/fail-for-sure
Makes test target fail based on return code from go test.
2017-06-02 15:10:45 -07:00
James Phillips e9ee136baf
Makes test target fail based on return code from go test. 2017-06-02 15:09:07 -07:00
James Phillips d9fb90be6a Update CHANGELOG.md 2017-06-02 09:33:58 -07:00
James Phillips 555cc9b44a Update CHANGELOG.md 2017-06-02 09:07:31 -07:00
James Phillips 5f9776ac89 Merge pull request #2621 from alicebob/devwatch
reset watch's lastIndex on error
2017-06-02 09:06:02 -07:00
Frank Schroeder 68cac3d40c
Revert "test: run all tests together again"
This reverts commit e48df7b572.
2017-06-02 07:52:21 +02:00
Frank Schroeder 4403db0d63
vendor: Update github.com/shirou/gopsutil
Pull in fix for data race on host.BootTime.
2017-06-02 07:51:08 +02:00
Frank Schroeder c5ba51db19
vendor: upgrade github.com/armon/go-metrics
Pull in changes to fix race condition for concurrent tests.
2017-06-01 23:52:26 +02:00
Frank Schroeder 375825f34c Do not recurse when the service address is a local cname
Fixes #2795
2017-06-01 18:20:31 +02:00
Frank Schroeder 9956bc9b47 agent: LastContact cannot be negative (#3067)
The X-Consul-LastContact header cannot be negative.

Fixes #3067
2017-06-01 18:20:12 +02:00
Frank Schroeder e23cd5acb6
vendor: upgrade github.com/go-ole/go-ole
This replaces the monkey patch for github.com/go-ole/go-ole/pull/144

See #3097
2017-06-01 16:05:24 +02:00
Frank Schroeder 6c0bccbc06
vendor: monkey patch github.com/go-ole/go-ole support for s390x
Remove this once https://github.com/go-ole/go-ole/pull/144 gets
merged.

Fixes #3097
2017-06-01 15:31:29 +02:00
Frank Schroeder 8051d4a1da
Revert "vendor: monkey patch github.com/go-ole/go-ole support for s390x"
This reverts commit 50fe2148a8.
2017-06-01 15:31:02 +02:00
Frank Schroeder 50fe2148a8
vendor: monkey patch github.com/go-ole/go-ole support for s390x
Remove this once https://github.com/go-ole/go-ole/pull/144 gets
merged.
2017-06-01 15:29:47 +02:00
Frank Schroeder 8b9d1603ac
test: use random ports for consul tests 2017-05-31 12:15:55 +02:00
Frank Schroeder db15cd847a
test: replace one more BoolFalse with agent.Bool() 2017-05-31 11:41:17 +02:00
Frank Schroeder dcc68f0f85
test: we will not use dev mode for testing for now 2017-05-31 11:34:00 +02:00
Frank Schroeder f89ae9f7e7
test: stagger retry attempts of TestAgent.Start 2017-05-31 11:33:25 +02:00
Frank Schroeder bdfed817ee
test: make TestAgent setup reusable
Pick the random ports only once and try starting with them
a number of times so that the configuration can be re-used.
This is because the ports are written into the data files
and a subsequent agent reading the files needs to have the
same ports.

For the same reason we do not remove the data directory on
every attempt since this makes it impossible to re-read the
data files.
2017-05-31 11:32:31 +02:00
Frank Schroeder 4034d0ac0b
agent: use agent logger for consul client and deps 2017-05-31 11:05:02 +02:00
Frank Schroeder c1e6a77c75
test: start secondary agents also via TestAgent 2017-05-31 10:56:19 +02:00
Frank Schroeder a9451d596f
agent: set tcpKeepAliveListener when there is no error 2017-05-31 10:24:32 +02:00
Frank Schroeder e48df7b572
test: run all tests together again
Looks like I have eliminated the troublesome tests for now.
2017-05-31 10:00:10 +02:00
Frank Schroeder 345666bdb6
test: use test name as log prefix 2017-05-31 09:54:09 +02:00
Frank Schroeder d6c7404b34
agent: simplify shutdown timeout logging
Note that we are currently timing out every time. This still
needs to be investigated.
2017-05-31 09:41:58 +02:00
Frank Schroeder 30ba712857
agent: set proto to http since we are logging it now 2017-05-31 09:41:16 +02:00
Frank Schroeder ceda18366f
test: Use Bool() instead of &BoolTrue/False since 2017-05-31 09:21:01 +02:00
Frank Schroeder 1b0d58bb22
test: don't panic if there is no error 2017-05-31 08:59:41 +02:00
Frank Schroeder ec729693d7
Address review comments 2017-05-31 01:05:21 +02:00
Frank Schroeder 26200929c1
agent: start HTTPS only if there is a cert and key 2017-05-31 00:29:29 +02:00
Frank Schroeder b6c69ebf5d
agent: refactor DNS and HTTP server
* refactor DNS server to be ready for multiple bind addresses
* drop tcpKeepAliveListener since it is default for the HTTP servers
* add startup timeout watcher for HTTP servers identical to DNS server
2017-05-31 00:29:29 +02:00
Frank Schroeder f4aa2ada4f
test: fail if there is no leader 2017-05-31 00:29:29 +02:00
Frank Schroeder c0680660d5
vendor: patch github.com/mitchellh/cli until help output is fixed
We need to init the flagset that cli uses to generate the help
outside of the Run method since Run isn't called anymore for
printing help.
2017-05-31 00:29:29 +02:00
Frank Schroeder 205cbe5fc8
build: update makefile
* capture all output to test.log only and print only failures
* always print output on travis
* test github.com/hashicorp/consul/consul separately until we've
  found the interactions with the other packages during testing.
2017-05-31 00:29:28 +02:00
Frank Schroeder aa92adcdd5
test: increase sleep time for test 2017-05-31 00:29:28 +02:00
Frank Schroeder f498f24032
test: allow tests to control anti-entropy syncs 2017-05-31 00:29:28 +02:00
Frank Schroeder eea16e1640
test: run mock dns recursors on random ports 2017-05-31 00:29:28 +02:00
Frank Schroeder 6148910399
test: skip tests that use cmd.Run until signal handling is fixed 2017-05-31 00:29:28 +02:00
Frank Schroeder 56cf015117
test: add test for starting/stopping lots of agents 2017-05-31 00:29:28 +02:00
Frank Schroeder 7c5892a196
test: use UniqueID prefix for check tests to unify log output 2017-05-31 00:29:28 +02:00
Frank Schroeder 0a31094e06
test: improve TestAgent
* don't use retry to try restarting the agent
  this caused some issues when the startup would fail in
  a separate go routine

* clear out the data directory on every retry since the ports
  are stored in the raft data files

* set a unique id for every agent to allow for tracking of
  concurrent output
2017-05-31 00:29:28 +02:00
Frank Schroeder 10540f8d5f
agent: fix logging
* use agent logger for consul/serf/raft/dns/agent/...
* support optional id for concurrent tests
2017-05-31 00:29:27 +02:00
Frank Schroeder fe777852cd
test: call t.Fatal() from main go routine 2017-05-31 00:29:27 +02:00
Frank Schroeder 3e39f04527
dns: do not log socket close during shutdown 2017-05-31 00:29:27 +02:00