status-im
/
consul
mirror of https://github.com/status-im/consul.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
9,054 Commits 445 Branches 179 Tags 481 MiB
Commit Graph

164 Commits

Author SHA1 Message Date
John Cowen c01fb37c46 Don't clone prev, there's no need 2018-07-06 13:09:23 +01:00
John Cowen a5fa27d718 Fix a couple of typos in the comments 2018-07-06 11:01:45 +01:00
John Cowen 67402b3d26 Tests and comments regarding the previous 2 commits 2018-07-05 13:43:03 +01:00
John Cowen b29546e578 Looking into atob functionality, consequence of Value: null 
The Consul API can pass through `Value: null` which does not get cast to
a string by ember-data. This snowballs into problems with `atob` which
then tried to decode `null`.

There are 2 problems here.

1. `Value` should never be `null`
  - I've added a removeNull function to shallowly loop though props and
  remove properties that are `null`, for the moment this is only on
  single KV JSON responses - therefore `Value` will never be `null`
  which is the root of the problem

2. `atob` doesn't quite follow the `window.atob` API in that the
`window.atob` API casts everything down to a string first, therefore it
will try to decode `null` > `'null'` > `crazy unicode thing`.
  - I've commented in a fix for this, but whilst this shouldn't be
  causing anymore problems in our UI (now that `Value` is never `null`),
  I'll uncomment it in another future release. Tests are already written
  for it which more closely follow `window.atob` but skipped for now
  (next commit)
 2018-07-05 13:35:06 +01:00
John Cowen 6a407a044e Remove validation for presence of KV values 2018-07-05 13:33:02 +01:00
John Cowen 83caa6a296 Add some more detail to the README pre-adding a CONTRIBUTING 2018-07-05 09:20:58 +01:00
John Cowen 7b8b3a012c Upgrade consul-api-double for session destroy 2018-07-04 18:53:52 +01:00
John Cowen 15b627a517 Basic acceptance testing for navigating via cancel buttons 2018-07-04 18:39:15 +01:00
John Cowen f85369c375 Add some navigation testing for back buttons and create buttons 2018-07-04 17:23:33 +01:00
John Cowen 649d777714 Acceptance test for using tokens from listing and detail pages 2018-07-04 16:37:41 +01:00
John Cowen 701d6a3a72 Move deleting to a top level feature 2018-07-04 15:58:09 +01:00
John Cowen e0f7cdb128 Start purifying page objects 2018-07-04 15:06:20 +01:00
John Cowen e3ce2a8beb Lock Session invalidation acceptance test 2018-07-04 13:41:44 +01:00
John Cowen ed286585e9 Add some low hanging intention tests, basically add intentions to others 
1. There are various things tests that can just have intentions added
into them, like filters and such like, add intentions to these
2. Start thinking about being able to negate steps easily, which will
lead on to a cleanup of the steps
 2018-07-04 13:21:30 +01:00
John Cowen caf3bf17f0
Merge pull request #4326 from hashicorp/feature/embedded-test-api 
Move testing doubles to use data embedded in the HTML vs HTTP/fetch
 2018-07-03 16:45:13 +01:00
John Cowen 87a0ad9483
Merge pull request #4331 from hashicorp/feature/hedge-empty-node-ids 
Hedge for when consul sends nodes with an empty ID
 2018-07-03 16:11:31 +01:00
John Cowen b445df39bb Use html5 oninput instead of onkeyup for native textual inputs 
This enables people to enter things using the mouse to paste for
example, plus possible other things.

As an aside it also answers my query regarding `fillIn` for testing,
nothing needs to be actually _typed_ anymore! Doh
 2018-07-03 15:40:15 +01:00
John Cowen 6398fb02c7 Ensure we catch empty ID's for single nodes also 
I don't think this would have a large effect on the UI whichever but
best to make sure
 2018-07-03 14:48:04 +01:00
John Cowen a47a0b617f Hedge for when consul sends nodes with an empty ID 2018-07-03 13:23:45 +01:00
John Cowen aa067c049a
Merge pull request #4322 from hashicorp/feature/unignore-startup-tests 
Reset `<html class>` after every test, back to its original static value
 2018-07-03 10:45:08 +01:00
John Cowen f527eb1dd6
Merge pull request #4280 from hashicorp/bugfix/encode-all-svg-colors 
Encode all the hexcodes
 2018-07-03 10:44:36 +01:00
John Cowen df8506e200 Move testing doubles to use data embedded in the HTML vs HTTP/fetch 
Previously `api-double` usage in ember would require a bunch of `fetch`
requests to pull in the 'api double', this had a number of disadvantages.

1. The doubles needed to be available via HTTP, which meant a short term
solution of rsyncing the double files over to `public` in order to be served
over HTTP. An alternative to that would have been figuring out how to serve
something straight from `node_modules`, which would have been preferable.

2. ember/testem would not serve dot files (so anything starting with a
., like `.config`. To solve this via ember/testem would have involved
digging in to understand how to enable the serving of dot files.

3. ember/testem automatically rewrote urls for non-existant files to
folders, i.e. adding a slash for you, so `/v1/connect/intentions` would
be rewritten to `/v1/connect/intentions/`. This is undesirable, and
solving this via ember/testem would have involved digging deep to
disable that.

Serving the files via HTTP has now changed. The double files are now
embedded into the HTML has 'embedded templates' that can be found by
using the url of the file and a simple `querySelector`. This of course
only happens during testing and means I can fully control the 'serving'
of the doubles now, so I can say goodbye to the need to move files
around, worry about the need to serve dotfiles and the undesirable
trailing slashes rewriting. Winner!

Find the files and embedding them is done using a straightforward
recursive-readdir-sync (the `content-for` functionality is a synchronous
api) as oppose to getting stuck into `broccoli`.
 2018-07-02 19:02:16 +01:00
John Cowen b3d11dd880 Tweak vocabulary to match new step vocab 2018-07-02 16:49:13 +01:00
John Cowen 8e7e224f3f Encode all the hexcodes 2018-06-26 10:48:26 +01:00
mkeeler 6813a99081 Merge remote-tracking branch 'connect/f-connect' 2018-06-25 19:42:51 +00:00
John Cowen 5ac19b164e Change the appearance of `*` for intention listings 
1. Use 'All Services (*)' as opposed to '*'
2. Set 'Destination' in teh same bold font as 'Source'
3. Ensure you can search for all services by using '*' or 'All Services
(*)'
 2018-06-25 12:26:18 -07:00
John Cowen 9f8b87cdda Check for NOT connect-proxy 2018-06-25 12:25:40 -07:00
John Cowen cc3d578271 Filter Source and Destination menus by Kind 2018-06-25 12:25:40 -07:00
John Cowen d61a09ea28 Fix linting typo, caused the selection of future services to break 2018-06-25 12:25:40 -07:00
John Cowen f600d8fcc9 Move intentions menu item to after ACLs 2018-06-25 12:25:37 -07:00
John Cowen b0ff68cd7d Lint 2018-06-25 12:25:16 -07:00
John Cowen e736b546f8 Icons in the filter bar 2018-06-25 12:25:15 -07:00
John Cowen f4218b4bea Validate all the things, all the time 2018-06-25 12:25:15 -07:00
John Cowen ee3a32d771 More detailed error messages for duplicate intentions 2018-06-25 12:25:15 -07:00
John Cowen ea3e4a720a Only offer to create a future service if the name doesn't already exist 2018-06-25 12:25:15 -07:00
John Cowen 50507b34a5 Make sure future services are available when editing intentions 2018-06-25 12:25:15 -07:00
John Cowen 5575455053 Add support for specifying future services and wildcards 2018-06-25 12:25:15 -07:00
John Cowen 55bc45832e Tie up real endpoints 2018-06-25 12:25:15 -07:00
John Cowen 24f6155efc Switch to single selects rather than inputs 2018-06-25 12:25:15 -07:00
John Cowen 148621d98e Have a look at power select for select elements 2018-06-25 12:25:14 -07:00
John Cowen 8023bb9b03 Add intentions actions mixin 2018-06-25 12:25:14 -07:00
John Cowen 9d6b9b7717 Remove SourceType for the moment 2018-06-25 12:25:14 -07:00
John Cowen 871953ba39 Include logger for generated tests 2018-06-25 12:25:14 -07:00
John Cowen b38e5df630 WIP: First draft intentions 
1. Listing, filtering by action and searching by source name and
destination name
2. Edit/Create page, edits ping the API double fine, need to work through
creates and deletes
3. Currently uses a `Precedence` intention keyname that doesn't yet
exist in the real API
 2018-06-25 12:25:14 -07:00
John Cowen c3e92a236f WIP: Logger 2018-06-25 12:25:14 -07:00
John Cowen 44deab454d Reset `<html class>` after every test, back to its original static value 2018-06-25 12:11:01 +01:00
John Cowen 61e3fa3244 Make sure the dc menu is as useful as possible when things go wrong 
1. Check the dc's model for both dcs list and the requested dc.
2. If the dc model doesn't exist use and empty array for dcs and a fake
dc with the Name 'Error' as we can't even trust what is in the
`paramsFor`
 2018-06-22 17:23:00 +01:00
John Cowen fd60f225ec
Merge branch 'master' into feature/ui-node-ports-for-service 2018-06-22 17:17:03 +01:00
John Cowen b41d19c3c0
Merge pull request #4251 from hashicorp/bugfix/ui-null-tokens 
Ensure a blank/empty token is sent if the localStorage kv doesn't exist
 2018-06-22 16:36:20 +01:00
John Cowen 30402b51b1
Merge pull request #4253 from hashicorp/feature/ui-clearer-tags 
UI - Clearer tags
 2018-06-22 09:24:13 +01:00
John Cowen 3450aa81da
Merge pull request #4259 from hashicorp/feature/failing-ttl-test 
[BUGFIX] UI - Make sure lock session TTLs are shown
 2018-06-21 20:33:03 +01:00
John Cowen 2e293f2697 Add a beforeModel hook at dc/index to auto transition to services 2018-06-21 12:49:00 +01:00
John Cowen abf77b3c74 Merge remote-tracking branch 'shilov/master' into feature/failing-ttl-test 2018-06-21 11:14:01 +01:00
John Cowen 127a45a4ab Fix up following rebase, use array of strings rather than its own func 2018-06-21 11:06:45 +01:00
John Cowen 1881ec4824 Add a failing test to show that lock session TTL's are not shown 2018-06-21 10:56:38 +01:00
Matt Keeler 1b8f4e1697
Merge pull request #4245 from hashicorp/release-build-updates 
Release build updates
 2018-06-20 21:01:36 -04:00
John Cowen 3f0560d098 Add missing scss file 2018-06-20 15:33:42 +01:00
John Cowen 3161cf0c7d Make sure the updated tag view doesn't break the tests 2018-06-20 15:26:22 +01:00
John Cowen 0ad1d562db Use the pill styling elsewhere... 
TODO: Probably change the %tag to %pill now I've remembered the word I was
looking for!
 2018-06-20 15:14:16 +01:00
John Cowen 0f6214d0ce Make sure token is set to blank if nothing is typed in settings 2018-06-20 14:38:54 +01:00
John Cowen d2d501a4a4 Add a reusable %tag and use it for the ACL 'tags' ready to use elsewhere 2018-06-20 14:01:42 +01:00
John Cowen 76017b69b5 Make sure the colon doesn't wrap with lots of tags 2018-06-20 13:44:36 +01:00
John Cowen 484f6ccaf2 Add port the service is running on for each node in the service view 2018-06-20 13:08:59 +01:00
John Cowen 8c5416ecaf Ensure a blank token is sent if the localStorage kv doesn't exist 2018-06-20 10:32:35 +01:00
John Cowen 894667b87a
Merge pull request #4247 from hashicorp/feature/acl-sort-by-name 
UI - Sort ACL tokens by name
 2018-06-20 09:18:36 +01:00
John Cowen f960604bb5
Merge pull request #4242 from hashicorp/feature/ui-code-editor-autosizing 
Sets code editor height to be automatic (growable), with a reasonable min height
 2018-06-20 09:18:14 +01:00
John Cowen 4d7f15ce34
Merge branch 'master' into bugfix/gh-4203-multi-tags 2018-06-20 09:17:23 +01:00
John Cowen 1d816e85af
Merge pull request #4228 from hashicorp/feature/minor-css-amends 
UI - minor css amends
 2018-06-20 09:15:34 +01:00
Matt Keeler aff1b93268 Update ui-v2 makefile to handle updating node_modules when needed 
Also dont include the dist and node_modules folders in the build context.
 2018-06-19 13:51:49 -04:00
John Cowen 6949b22d5f Sort ACL tokens by name 2018-06-19 10:51:31 +01:00
John Cowen 3c02e17fa7 Make sure the body background is white 2018-06-19 10:25:41 +01:00
Stanley Shilov c06dfb3d2d Sessions TTL should be of type string in ui-v2 2018-06-18 13:41:22 -05:00
John Cowen 5909d5695e Sets code editor height to be auto, with a reasonable min height 2018-06-18 19:07:57 +01:00
John Cowen 04435dbdaf Ensure all tags for a service are listed on the service detail page 2018-06-18 15:38:52 +01:00
Matt Keeler 30ff8b195b Add rsync so the ui can build again 
Also add back the init target to the ui-v2 makefile
 2018-06-15 14:44:14 -04:00
Matt Keeler 13c72cac0e Merge remote-tracking branch 'origin/master' into release-build-updates 
# Conflicts:
#	scripts/consul-builder/Dockerfile
#	ui-v2/GNUmakefile
 2018-06-15 14:40:09 -04:00
John Cowen fb4643b062 Move the rsync dependency to the test scripts for now. 
1. You only need the fixtures for testing, don't force rsync on people
for just building
2. Eventually this will go and be replaced by something broccoli-y
 2018-06-15 16:11:14 +01:00
John Cowen bf4bcdd670 Find a way to test pre-ember load 
1. Also add index.html things to test/index.html
2. Use content-for to hedge against keeping content in sync (requires an
addon)
3. Test passes but only when run on its own, as we need to rely on
content in the QUnit runner, theoretically it is not running our test in
isolation. Skipping the test for the moment so we don't have a filaing
test when all run together
 2018-06-15 13:56:45 +01:00
John Cowen 5bee407319 Move healthcheck text down by 1px 2018-06-14 17:19:46 +01:00
John Cowen 11ec24fe48 Ensure startup/load image is removed if you hit an error on first load 2018-06-14 17:19:45 +01:00
John Cowen 71cef8b8cd
Merge pull request #4225 from hashicorp/bugfix/hide-anon-acl-delete 
[BUGFIX] Remove anonymous ACL delete button in the listing
 2018-06-14 16:58:07 +01:00
John Cowen 62a4c1098e Add test for not showing the delete button for the first acl... 
Also, change the action group page objects to use data-test attributes
instead of last-child which isn't reliable (and stay consistent)
 2018-06-14 15:01:54 +01:00
John Cowen 58f99703a4 Disable the delete button in the acl list for the anon token only 2018-06-14 13:34:38 +01:00
John Cowen 53b6e20040 Add a test for searching by token 2018-06-14 13:15:56 +01:00
John Cowen 005fbcd149 Add searching ACL's by token 2018-06-14 13:06:02 +01:00
John Cowen 4998029670 Comment up custom visitable and add a couple of comments to be clearer 2018-06-12 11:24:36 +01:00
John Cowen f87f410e3a Use defaultValue for making sure Name is at least '' 2018-06-12 11:24:36 +01:00
John Cowen e37136ecae Prevent being able to submit a create form with empty values 2018-06-12 11:24:36 +01:00
John Cowen 59ce55227c Explicitly sort by Key after folder/file 2018-06-12 11:24:36 +01:00
John Cowen d4328ffa09 Remove buts 2018-06-12 11:24:36 +01:00
John Cowen 28e56aa92f Make this steps file the same as the others... 
WIP: Ideally all of these would go
 2018-06-12 11:24:36 +01:00
John Cowen 947417689f Make sure KV clicking is tested (WIP) 2018-06-12 11:24:36 +01:00
John Cowen ae2da814d8 Tweak vocab 2018-06-12 11:24:36 +01:00
John Cowen 950a704b74 Add a couple more unit tests for the utils folder 2018-06-12 11:24:36 +01:00
John Cowen 7bd9088677 Upgrade consul-api-double 2018-06-12 11:24:36 +01:00
John Cowen 5e5fffe300 Add some delete testing to KV and ACL 2018-06-12 11:24:36 +01:00
John Cowen 46419ac466 QSA doesn't like searching with sibling selectors, make a `sibling` 2018-06-12 11:24:36 +01:00
John Cowen 4b46caf77a Make sure `didAppear` and therefore `resize` is called on change 
Tables need to calculate their sizing depending on other things in the
DOM. When a table is in a tab panel, some of these things aren't visible
and therefore some values are zero during `didInsertElement`.

This commit ensures that the resize calc of the table is performed when
it's parent tab is clicked (and therefore when the table 'appears')
 2018-06-12 11:24:36 +01:00
John Cowen f1b25c009e WIP: Make sure I can get the values I need to calculate sizing 
`rect.top` is zero until the tab panel becomes visible, resize will need
to be called when the tab is clicked also
 2018-06-12 11:24:36 +01:00
John Cowen 16fc7ebd8b Remove some pauses 2018-06-12 11:24:36 +01:00