consul

Commit Graph

Author	SHA1	Message	Date
Alex Dzyoba	4137d06f9f	command: change delim in columnize to funny node names (#6652 ) When node name contains vertical bar symbol some commands output is garbled because `\|` is used as a delimiter in `columnize.SimpleFormat`. This commit changes format string to use `\x1f` - ASCII unit separator[1] as a delimiter and also adds test to cover this case. Affected commands: * `consul catalog nodes` * `consul members` * `consul operator raft list-peers` * `consul intention get` Fixes #3951. [1]: https://en.wikipedia.org/wiki/Delimiter#Solutions	2020-03-09 11:24:56 +01:00
Matt Keeler	766d771017	Pass a testing.T into NewTestAgent and TestAgent.Start (#5342 ) This way we can avoid unnecessary panics which cause other tests not to run. This doesn't remove all the possibilities for panics causing other tests not to run, it just fixes the TestAgent	2019-02-14 10:59:14 -05:00
Mitchell Hashimoto	971b3c06a1	command/intention/get: tests	2018-06-14 09:42:19 -07:00

Author

SHA1

Message

Date

Alex Dzyoba

4137d06f9f

command: change delim in columnize to funny node names (#6652 )

When node name contains vertical bar symbol some commands output is
garbled because `|` is used as a delimiter in `columnize.SimpleFormat`.

This commit changes format string to use `\x1f` - ASCII unit
separator[1] as a delimiter and also adds test to cover this case.

Affected commands:

* `consul catalog nodes`
* `consul members`
* `consul operator raft list-peers`
* `consul intention get`

Fixes #3951.

[1]: https://en.wikipedia.org/wiki/Delimiter#Solutions

2020-03-09 11:24:56 +01:00

Matt Keeler

766d771017

Pass a testing.T into NewTestAgent and TestAgent.Start (#5342 )

This way we can avoid unnecessary panics which cause other tests not to run.

This doesn't remove all the possibilities for panics causing other tests not to run, it just fixes the TestAgent

2019-02-14 10:59:14 -05:00

Mitchell Hashimoto

971b3c06a1

command/intention/get: tests

2018-06-14 09:42:19 -07:00

3 Commits