Commit Graph

3569 Commits

Author SHA1 Message Date
Ryan Uber e115ada1e6 Merge pull request #1307 from hashicorp/f-rpc
Switch to net-rpc-msgpackrpc
2015-10-15 14:57:54 -07:00
Ryan Uber b6ca82dd41 consul: comment msgpack handle 2015-10-15 14:57:29 -07:00
Ryan Uber 2715b93619 Fix CHANGELOG 2015-10-15 14:52:58 -07:00
Ryan Uber d6af59cded Merge pull request #1309 from hashicorp/f-remove-migrate
Removes consul-migrate for 0.6
2015-10-15 14:50:19 -07:00
Jeff Mitchell b8e4c8deb8 Merge pull request #1310 from hashicorp/fix-http-defaultclient
Don't use http.DefaultClient
2015-10-15 17:49:55 -04:00
Jeff Mitchell f49fc095ef Don't use http.DefaultClient
Two of the changes are in tests; the one of consequence is in the API.
As explained in #1308 this can cause conflicts with downstream programs.

Fixes #1308.
2015-10-15 17:49:35 -04:00
Ryan Uber bdd1a9d064 Update CHANGELOG.md 2015-10-15 14:48:59 -07:00
Ryan Uber 3872e57b3b website: add note for consul migrate utility. 2015-10-15 14:42:46 -07:00
Ryan Uber de287e3efb agent: consolidates data dir checker 2015-10-15 14:21:35 -07:00
Ryan Uber 10b971df21 agent: test mdb dir protection 2015-10-15 14:15:41 -07:00
Ryan Uber d901fa6389 agent: remove migrator, refuse to start if mdb dir found 2015-10-15 14:15:08 -07:00
Ryan Uber e098b7592f consul: revert session endpoint test 2015-10-15 12:31:48 -07:00
Ryan Breen 8ecf4d1f6e Update datacenters.html.markdown
Fix GH-1305.
2015-10-15 14:36:54 -04:00
Ryan Uber 81a862d8b7 consul: initial pass at refactoring RPC using net-rpc-msgpackrpc 2015-10-13 22:15:23 -07:00
Ryan Breen 5d9530d7de Merge pull request #1300 from magsout/fix.Header-background-firefox/ie
Fixed Header background
2015-10-13 16:37:17 -04:00
Guillaume Demesy 809ed36344 Fixed Header background 2015-10-13 22:29:14 +02:00
Armon Dadgar d137a5fa82 agent: remove an N^2 check. See #1265 2015-10-12 20:30:11 -07:00
Sam Handler ea5d041ece bundle update middleman-hashicorp 2015-10-12 18:44:58 -04:00
Sam Handler d25e6390b6 Add edit this page link in footer 2015-10-12 18:44:22 -04:00
Sam Handler 30c4ef88af Add github_slug to website/config.rb 2015-10-12 18:43:15 -04:00
Sam Handler 4de2dd31f0 Add makefile and update readme 2015-10-09 18:29:08 -04:00
Seth Vargo e34c321fce Add shopt globs to include hidden files 2015-10-08 13:47:25 -04:00
Ryan Breen 78aa6f1443 Merge pull request #1270 from mpuncel/mpuncel/log-http-method
Add http method to log output
2015-10-02 21:49:40 -04:00
Michael Puncel a98d25b541 Add http method to log output 2015-10-02 18:33:06 -07:00
Ryan Breen 42aa817456 Merge pull request #1262 from norbertpotocki/master
Add cfg4j-pusher to tools section
2015-09-29 08:50:34 -04:00
Norbert Potocki 9dfdbb2d36 add cfg4j-pusher to tools section 2015-09-28 21:16:56 -07:00
James Phillips c74355fec0 Merge pull request #1041 from rboyer/api-fix-session-renew
Fix Session.Renew to care about 404s properly
2015-09-25 13:15:54 -07:00
Ryan Breen 662ca39104 Merge pull request #1258 from jeffawang/master
website: Make the DNS Interface documentation notation consistent with functionality
2015-09-24 08:43:32 -04:00
Jeff Wang 0488dfd366 Make service lookup DNS documentation consistent 2015-09-23 23:16:34 -07:00
Jeff Wang ce66db8157 Make node lookup DNS documentation consistent 2015-09-23 23:09:52 -07:00
James Phillips de080672fe Merge pull request #1251 from hashicorp/sethvargo/faster_deploy
Use a faster website deploy
2015-09-21 10:41:27 -07:00
Seth Vargo 85c66d4749 Use a faster middleman deploy 2015-09-20 14:03:38 -04:00
James Phillips 0b05dbeb21 Merge pull request #1235 from wuub/master
fix conflict between handleReload and antiEntropy critical sections
2015-09-17 07:28:39 -07:00
Wojciech Bederski c4537ed26f panic when unbalanced localState.Resume() is detected 2015-09-17 11:32:08 +02:00
Ryan Breen 1282a6ff95 Merge pull request #1242 from dwijnand/fix-typos
Fix a bunch of typos.
2015-09-15 08:41:22 -04:00
Dale Wijnand 5a28ebcaa3 Fix a bunch of typos. 2015-09-15 13:22:08 +01:00
James Phillips e029702e39 Merge pull request #1240 from hashicorp/sethvargo/link_warnings
Fix link warnings
2015-09-14 10:51:59 -07:00
Seth Vargo 7b4dcad487 Fix link warnings 2015-09-14 18:48:51 +01:00
R.B. Boyer 8b072467eb Correct the Session.Renew{,Periodic} to handle session expiration better 2015-09-14 08:52:32 -05:00
James Phillips 2f9ebdb135 Merge pull request #1187 from sfncook/enable_tag_drift_03
Enable tag drift 03
2015-09-11 15:35:32 -07:00
Shawn Cook 1f330add02 Doc changes in response to review. 2015-09-11 15:26:30 -07:00
Shawn Cook 598526eba2 Docs - add verbage to anti-entropy page. 2015-09-11 14:27:54 -07:00
Ryan Breen 0722c1521a Merge pull request #1236 from scalp42/typos
remove various typos
2015-09-11 15:47:32 -04:00
Anthony Scalisi 10e028d599 remove various typos 2015-09-11 12:29:54 -07:00
Shawn Cook 4caf049c4c Update documentation for service definition 2015-09-11 09:32:54 -07:00
Ryan Breen e347f20790 Merge pull request #1234 from jovandeginste/quote-variable
Add quotes to locations in case pwd contains spaces
2015-09-11 12:31:47 -04:00
Wojciech Bederski b014c0f91b make Pause()/Resume()/isPaused() behave more like a semaphore
see: https://github.com/hashicorp/consul/issues/1173 #1173

Reasoning: somewhere during consul development Pause()/Resume() and
PauseSync()/ResumeSync() were added to protect larger changes to
agent's localState.  A few of the places that it tries to protect are:

- (a *Agent) AddService(...)      # part of the method
- (c *Command) handleReload(...)  # almost the whole method
- (l *localState) antiEntropy(...)# isPaused() prevents syncChanges()

The main problem is, that in the middle of handleReload(...)'s
critical section it indirectly (loadServices()) calls  AddService(...).
AddService() in turn calls Pause() to protect itself against
syncChanges(). At the end of AddService() a defered call to Resume() is
made.

With the current implementation, this releases
isPaused() "lock" in the middle of handleReload() allowing antiEntropy
to kick in while configuration reload is still in progress.
Specifically almost all services and probably all check are unloaded
when syncChanges() is allowed to run.

This in turn can causes massive service/check de-/re-registration,
and since checks are by default registered in the critical state,
a majority of services on a node can be marked as failing.
It's made worse with automation, often calling `consul reload` in close
proximity on many nodes in the cluster.

This change basically turns Pause()/Resume() into P()/V() of
a garden-variety semaphore. Allowing Pause() to be called multiple times,
and releasing isPaused() only after all matching/defered Resumes() are
called as well.

TODO/NOTE: as with many semaphore implementations, it might be reasonable
to panic() if l.paused ever becomes negative.
2015-09-11 18:28:06 +02:00
Jo Vandeginste a626ae1892 Add quotes to locations in case pwd contains spaces 2015-09-11 18:19:22 +02:00
Wojciech Bederski 24bc17eaa1 failing test showing that nested Pause()/Resume() release too early
see: #1173 / https://github.com/hashicorp/consul/issues/1173
2015-09-11 17:52:57 +02:00
Shawn Cook 66fd8fb2a0 Rename EnableTagOverride and update formatting 2015-09-11 08:35:29 -07:00